Stream: t-lang/meta

Topic: generating the agenda


view this post on Zulip nikomatsakis (Nov 02 2020 at 13:34):

Hey @Santiago Pastorino are you around? I have a few questions about the triagebot code

view this post on Zulip Santiago Pastorino (Nov 02 2020 at 13:34):

:wave:

view this post on Zulip nikomatsakis (Nov 02 2020 at 13:35):

when I generate the lang-team agenda it generates bullet lists with leading spaces before the -

view this post on Zulip nikomatsakis (Nov 02 2020 at 13:35):

e.g.

view this post on Zulip nikomatsakis (Nov 02 2020 at 13:35):

## Pending proposals
  - "MCP: per-edition preludes" [lang-team#44](https://github.com/rust-lang/lang-team/issues/44)
  - "MCP: Rust-style `#[inline]` attribute." [lang-team#56](https://github.com/rust-lang/lang-team/issues/56)

view this post on Zulip nikomatsakis (Nov 02 2020 at 13:35):

this is annoying because when I edit in hackmd I can't make indented lists as easily

view this post on Zulip nikomatsakis (Nov 02 2020 at 13:35):

would it be easy to change the code to do

view this post on Zulip nikomatsakis (Nov 02 2020 at 13:35):

## Pending proposals
- foo
- bar

view this post on Zulip nikomatsakis (Nov 02 2020 at 13:36):

and if so what code do I edit :)

view this post on Zulip Santiago Pastorino (Nov 02 2020 at 13:36):

let me check quickly the code

view this post on Zulip nikomatsakis (Nov 02 2020 at 13:36):

I had another question that's a bit more involved -- I might like to scrape comments out of the issues too, in some cases

view this post on Zulip Santiago Pastorino (Nov 02 2020 at 13:36):

ok I see

view this post on Zulip Santiago Pastorino (Nov 02 2020 at 13:36):

so

view this post on Zulip Santiago Pastorino (Nov 02 2020 at 13:36):

some things are a bit hacky

view this post on Zulip Santiago Pastorino (Nov 02 2020 at 13:36):

but

view this post on Zulip Santiago Pastorino (Nov 02 2020 at 13:37):

{{-issues::render(issues=pending_proposals, indent=" ", empty="No pending proposals this time.")}}

view this post on Zulip Santiago Pastorino (Nov 02 2020 at 13:37):

change the indent to indent=""

view this post on Zulip Santiago Pastorino (Nov 02 2020 at 13:37):

nikomatsakis said:

I had another question that's a bit more involved -- I might like to scrape comments out of the issues too, in some cases

shoot the other question

view this post on Zulip nikomatsakis (Nov 02 2020 at 13:39):

Santiago Pastorino said:

change the indent to indent=""

oh, that's easy :)

view this post on Zulip Santiago Pastorino (Nov 02 2020 at 13:40):

yeah, originally I did something smarter like how real templates work

view this post on Zulip Santiago Pastorino (Nov 02 2020 at 13:41):

which was ... when the system needed to render a collection of object it just used the indentation that it found for every item in the collection

view this post on Zulip Santiago Pastorino (Nov 02 2020 at 13:41):

like

view this post on Zulip Santiago Pastorino (Nov 02 2020 at 13:41):

{{render collection}}

view this post on Zulip Santiago Pastorino (Nov 02 2020 at 13:41):

would render every item with 2 spaces

view this post on Zulip Santiago Pastorino (Nov 02 2020 at 13:42):

but then it turned out to be a problem with tera, so went for this solution :)

view this post on Zulip Santiago Pastorino (Nov 02 2020 at 13:42):

nikomatsakis said:

Santiago Pastorino said:

change the indent to indent=""

oh, that's easy :)

btw, you can remove indent, the default is to not indent

view this post on Zulip Santiago Pastorino (Nov 02 2020 at 13:42):

{% macro render(issues, indent="", empty="No issues this time.") %}

view this post on Zulip nikomatsakis (Nov 02 2020 at 13:43):

ok. regarding the second question, actually, it's not urgent

view this post on Zulip nikomatsakis (Nov 02 2020 at 13:44):

I kind of want to automate "scraping" issues for updates

view this post on Zulip nikomatsakis (Nov 02 2020 at 13:44):

and then encourage people to post them :)

view this post on Zulip nikomatsakis (Nov 02 2020 at 13:44):

but then we were thinking of changing how we handle issues etc

view this post on Zulip nikomatsakis (Nov 02 2020 at 13:44):

so i think it's a bit premature

view this post on Zulip nikomatsakis (Nov 02 2020 at 13:44):

thanks @Santiago Pastorino

view this post on Zulip Santiago Pastorino (Nov 02 2020 at 13:49):

:+1:

view this post on Zulip Santiago Pastorino (Nov 02 2020 at 13:49):

nikomatsakis said:

I kind of want to automate "scraping" issues for updates

ping me when you want to do this I guess :)

view this post on Zulip nikomatsakis (Nov 02 2020 at 15:44):

@Santiago Pastorino what workflow do you use for copying over the "summaries" for nominated issues and the like week to week?

view this post on Zulip nikomatsakis (Nov 02 2020 at 15:44):

do you just copy-and-paste from last week's agenda?

view this post on Zulip Santiago Pastorino (Nov 02 2020 at 15:57):

@nikomatsakis you meant, if there are things that we didn't have time to discuss?

view this post on Zulip Santiago Pastorino (Nov 02 2020 at 15:57):

anyway, besides from that question my workflow is right after we finish the meeting, I create the new agenda from the agenda template just using HackMD

view this post on Zulip Santiago Pastorino (Nov 02 2020 at 15:58):

after that I copy things we didn't have time over, like PRs waiting on team, undiscussed nominated issues, P-criticals and all the things that still apply to next week

view this post on Zulip Santiago Pastorino (Nov 02 2020 at 15:58):

and then during the week we keep executing our script and updating

view this post on Zulip Santiago Pastorino (Nov 02 2020 at 15:59):

potentially removing some P-criticals and such because they are already closed

view this post on Zulip Santiago Pastorino (Nov 02 2020 at 15:59):

https://forge.rust-lang.org/compiler/prioritization/procedure.html

view this post on Zulip Santiago Pastorino (Nov 02 2020 at 15:59):

in particular I was mainly describing this section https://forge.rust-lang.org/compiler/prioritization/procedure.html#follow-ups-from-previous-meeting


Last updated: Jan 26 2022 at 09:02 UTC