Stream: zulip

Topic: alexcrichton/jemallocator#64 test


view this post on Zulip pnkfelix (Nov 06 2018 at 10:54):

test

view this post on Zulip davidtwco (Nov 06 2018 at 10:54):

there are linkifiers set up for chalk and polonius but nothing else currently

view this post on Zulip pnkfelix (Nov 06 2018 at 10:55):

thanks. too bad.

view this post on Zulip davidtwco (Nov 06 2018 at 10:55):

You can only use one capture variable in the linkifier so I don't think we can make it generic enough to build any arbitrary GitHub url.

view this post on Zulip pnkfelix (Nov 06 2018 at 10:56):

I don't quite understand the architecture of what you describe, so I'm missing context

view this post on Zulip davidtwco (Nov 06 2018 at 10:56):

Can see it on "Organization Settings > Linkifiers" from the cog in the top right of Zulip.

view this post on Zulip pnkfelix (Nov 06 2018 at 10:56):

you cannot make a regexp that would match org/project#issuenum ?

view this post on Zulip davidtwco (Nov 06 2018 at 10:56):

It's basically a regex.

view this post on Zulip pnkfelix (Nov 06 2018 at 10:56):

Can see it on "Organization Settings > Linkifiers" from the cog in the top right of Zulip.

/me looks

view this post on Zulip davidtwco (Nov 06 2018 at 10:56):

I think we tried making it more generic and supporting arbitrary GitHub projects but I don't think it would let us.

view this post on Zulip pnkfelix (Nov 06 2018 at 10:58):

I see, I should be able to add a new linkifier there, so in theory there's no harm in trying. But I suspect I'm not likely to succeed if others have already tried this...

view this post on Zulip davidtwco (Nov 06 2018 at 10:58):

I just tried it on a private instance I've got for messing around: pasted image

view this post on Zulip davidtwco (Nov 06 2018 at 10:59):

Seems like they validate the URL format string in a too restrictive way.

view this post on Zulip davidtwco (Nov 06 2018 at 11:00):

Can't put links in topic titles either since there's a length cap.

view this post on Zulip pnkfelix (Nov 06 2018 at 11:00):

Oh! hmm, right. I had thought we could get away with just feeding in the whole captured text directly, but you're right; we'd need to inject "issues/" into the middle of the string... hmmm..

view this post on Zulip davidtwco (Nov 06 2018 at 11:02):

Unless there's some service out there that will take "alexcrichton/jemallocator#6" and redirect you to the GitHub page - then we could do it as one variable.

view this post on Zulip davidtwco (Nov 06 2018 at 11:02):

That'd be easy enough to make.

view this post on Zulip pnkfelix (Nov 06 2018 at 11:07):

a service called "github flavored markdown" ...

view this post on Zulip pnkfelix (Nov 06 2018 at 11:07):

:wink:

view this post on Zulip davidtwco (Nov 06 2018 at 11:09):

Actually, wouldn't be as easy, no server would be able to intercept the anchor and redirect it without some JS on the page doing that.

view this post on Zulip davidtwco (Nov 06 2018 at 11:19):

I've set up https://github-expander.dtw.io/alexcrichton/jemallocator/6 - with any repo it'll work.

view this post on Zulip davidtwco (Nov 06 2018 at 11:19):

We could set up a linkifier to match x/y/n and just pop that on the end of github-expander.dtw.io/ and it'd work.

view this post on Zulip davidtwco (Nov 06 2018 at 11:20):

It's not as nice as I can't use # but it's not awful.

view this post on Zulip davidtwco (Nov 06 2018 at 11:24):

Confirmed that this will work: pasted image

view this post on Zulip davidtwco (Nov 06 2018 at 11:24):

Might be a nice fallback for repos like this and we can keep the special casing directly for repos we reference all the time.

view this post on Zulip pnkfelix (Nov 06 2018 at 11:52):

hmm why can't it use #?

view this post on Zulip pnkfelix (Nov 06 2018 at 11:52):

oh you can't put it into the url ?

view this post on Zulip davidtwco (Nov 06 2018 at 11:52):

Part of the spec that defines urls mandates that # is handled client-side only.

view this post on Zulip pnkfelix (Nov 06 2018 at 11:52):

hmmmm......

view this post on Zulip davidtwco (Nov 06 2018 at 11:52):

So I can't use that in doing the redirects.

view this post on Zulip davidtwco (Nov 06 2018 at 11:52):

And therefore can't use it in the pattern.

view this post on Zulip davidtwco (Nov 06 2018 at 11:52):

Since that just gets appended on a URL.

view this post on Zulip DPC (Nov 06 2018 at 19:15):

maybe post a request to the zulip person on internals asking him if this can be done? will be helpful if #crate/xxx streams becomes a reality


Last updated: Oct 11 2021 at 22:34 UTC