Stream: t-compiler/wg-prioritization/alerts

Topic: #82665 regression: AsRef inference breakage


triagebot (Mar 01 2021 at 16:42, on Zulip):

@WG-prioritization/alerts issue #82665 has been requested for prioritization.

Procedure

Yuki Okushi (Mar 05 2021 at 10:08, on Zulip):

Mark says on the issue:

Usually we don't do anything here, but would be good to at least ping authors.

So we don't have to prioritize if it's a usual one actually?

apiraino (Mar 05 2021 at 11:59, on Zulip):

correct, when crater runs issues can be resolved by the crate author updating the crate => "not our problem" :-)
But in this case your comment (btw thanks for your improved bisection ^_^) seems to point to an actual regression so I'm inclined to open a specific issue (#75180) for that. Would that make sense?

Yuki Okushi (Mar 05 2021 at 12:07, on Zulip):

Yeah, this issue should be discussed on the libs team to introduce a fix or just close it (actually, it's nominated for the team)

Yuki Okushi (Mar 05 2021 at 12:08, on Zulip):

so could we drop the prioritize label?

Léo Lanteri Thauvin (Mar 05 2021 at 12:09, on Zulip):

What surprises me is that #75180 already had a crater run, but it seems like it didn't pick up this AsRef regression?

Léo Lanteri Thauvin (Mar 05 2021 at 12:10, on Zulip):

But anyway this is not a T-compiler issue, so we don't have to prioritize it

apiraino (Mar 05 2021 at 12:10, on Zulip):

makes sense, thanks :thumbs_up:

triagebot (Mar 05 2021 at 12:11, on Zulip):

Issue #82665's prioritization request has been removed.

Léo Lanteri Thauvin (Mar 05 2021 at 12:11, on Zulip):

Yuki Okushi said:

so could we drop the prioritize label?

I don't know if T-libs use it, they seem to use priority labels though

Yuki Okushi (Mar 05 2021 at 12:12, on Zulip):

ah, if they use it, it should be left

Léo Lanteri Thauvin (Mar 05 2021 at 12:13, on Zulip):

It's I-nominated for them, so I guess it doesn't really matter

apiraino (Mar 05 2021 at 12:14, on Zulip):

we're stuck in bureaucracy

Yuki Okushi (Mar 05 2021 at 12:14, on Zulip):

Léo Lanteri Thauvin said:

What surprises me is that #75180 already had a crater run, but it seems like it didn't pick up this AsRef regression?

Looks like they found it at least: https://github.com/rust-lang/rust/pull/75180#issuecomment-681492119

Léo Lanteri Thauvin (Mar 05 2021 at 12:15, on Zulip):

Oops, you're right

Léo Lanteri Thauvin (Mar 05 2021 at 12:16, on Zulip):

So the PR was approved while they were aware of these regressions

Léo Lanteri Thauvin (Mar 05 2021 at 12:17, on Zulip):

This issue will most likely be closed as wontfix then

Léo Lanteri Thauvin (Mar 05 2021 at 12:18, on Zulip):

I'll post a comment on the issue

Last update: Apr 11 2021 at 19:45UTC