@WG-prioritization/alerts issue #79890 has been requested for prioritization.
P-high maybe, someone ran into it almost immediately
out of curiosity, what is the issue here? Looks like that rustc is using some cached stuff when it should not?
looks like an issue with metadata serialization, maybe? I think there might be a hash collision
right, I thought maybe a hash of an external module that it's not there anymore becuase removed from the
anyway, not important just geek curiosity :smile:
I don't know, sorry
Issue #79890's prioritization request has been removed.
It really feels like we've been getting a lot of incr-comp issues recently...
they're all related
Ah, I see
which was in turn caused by https://github.com/rust-lang/rust/pull/74967, a pretty significant refactor of metadata loading
yeah, sorry about that
it's hard to test incremental changes in the same way that you test other changes
since doing a Crater run (or manually testing a bunch of crates) doesn't really exercise much code
we could run crater on each crate up to HEAD~1, and then incrementally build up to HEAD :smiley:
or well to previous version and then up to latest
previous versions would probably be better
HEAD~1 might just give you things like typo fixes/version bumps in a bunch of cases
which doesn't really exercise any incr comp code
anyway, I have a fix for this issue, an I'm currently adding the test case to
I'm not sure if doing something like that is reasonable and how much time would that take but something that may worth trying I guess
we'd also need to see how difficult it would be to add that to Crater
currently, I think Crater always re-tests the same crate version
I have no insight how hard this would be
File an issue though