Stream: t-compiler/wg-prioritization/alerts

Topic: I-prioritize #76679 wasi-sdk/bin/wasm-ld regression in 1.46…


triagebot (Sep 14 2020 at 00:06, on Zulip):

@WG-prioritization/alerts issue #76679 has been requested for prioritization.

Procedure

apiraino (Sep 14 2020 at 20:23, on Zulip):

A comment suggests this issue might be helped by merged PR:
https://github.com/rust-lang/rust/issues/76679#issuecomment-691855216
I didn't understand if that PR should fix all of the issue.

The part of the issue about the RUSTFLAGS='-C link-args=-Wl,-v' seems to be specific to a linux distro (so not sure it's relevant to the whole issue)

apiraino (Sep 16 2020 at 10:46, on Zulip):

I'd simply remove the I-prioritize label because of :point_up:

@WG-prioritization makes sense?

LeSeulArtichaut (Sep 16 2020 at 11:11, on Zulip):

+1 for unprioritizing

LeSeulArtichaut (Sep 16 2020 at 11:14, on Zulip):

I think what we should do is ask the issue author to confirm that it works on latest nightly, if it does we close the issue, if it doesn’t we would prioritize + bisect + find mcve

LeSeulArtichaut (Sep 16 2020 at 11:15, on Zulip):

Left a comment

DPC (Sep 16 2020 at 11:29, on Zulip):

yeah we can unprioritise and re-prio if the issue isn't fixed

LeSeulArtichaut (Sep 16 2020 at 11:51, on Zulip):

Issue isn’t fixed

LeSeulArtichaut (Sep 16 2020 at 11:51, on Zulip):

Going to ping cleanup for bisection/mcve

LeSeulArtichaut (Sep 16 2020 at 11:55, on Zulip):

Or maybe that’s not worth it...?

LeSeulArtichaut (Sep 16 2020 at 11:57, on Zulip):

As for the priority, I’d go for P-medium since it affects Wasi which is a tier 2 platform and it wasn’t spotted until it hit stable

Jonathan Chasteen (Sep 16 2020 at 11:59, on Zulip):

The guy mentions mcve and links a repo, but it seems that the actual reproduction is in the env variables. Am I reading this correctly?

LeSeulArtichaut (Sep 16 2020 at 12:10, on Zulip):

Ah you’re right, it’s just a hello world

DPC (Sep 16 2020 at 12:45, on Zulip):

tempted to defer on this till we have a mcve

Joshua Nelson (Sep 16 2020 at 12:55, on Zulip):

might be related to https://github.com/rust-lang/rust/issues/76679 ?

LeSeulArtichaut (Sep 16 2020 at 13:03, on Zulip):

@Joshua Nelson I guess you provided a wrong link :D

LeSeulArtichaut (Sep 16 2020 at 13:04, on Zulip):

DPC said:

tempted to defer on this till we have a mcve

Issue author says:

I tried to cross compile a hello world

So seems like a hello world is enough @DPC

apiraino (Sep 16 2020 at 13:21, on Zulip):

LeSeulArtichaut said:

Joshua Nelson I guess you provided a wrong link :D

though definitively related - I'd say :-)

Stu (Sep 16 2020 at 13:30, on Zulip):

P-Medium sounds like a good choice since wasi isn’t really stable, which is also mentioned in the docs he provided in the issue, so the user can’t expect to get it working flawlessly

Joshua Nelson (Sep 16 2020 at 13:51, on Zulip):

whoops, meant to link to https://github.com/rust-lang/rust/issues/76466

Stu (Sep 16 2020 at 14:43, on Zulip):

I don't think they are related to each other.
#76679 is an error that is caused by providing invalid arguments (or other errors that are caused by the linker).
In #76466 the linker doesn't even get invoked

Santiago Pastorino (Sep 16 2020 at 18:24, on Zulip):

this one is pending prioritization but it seems that we agreed on unprioritize it or P-medium

Santiago Pastorino (Sep 16 2020 at 18:25, on Zulip):

this seems also to be T-infra

triagebot (Sep 16 2020 at 18:25, on Zulip):

Issue #76679's prioritization request has been removed.

Joshua Nelson (Sep 16 2020 at 18:25, on Zulip):

I would expect it to be an issue in codegen, not in rustbuild or anything like that

Santiago Pastorino (Sep 16 2020 at 18:26, on Zulip):

:+1:

DPC (Sep 16 2020 at 18:59, on Zulip):

i thought and we were doing priorities only for compiler team, while for the rest teams we can nominate directly?

Joshua Nelson (Sep 16 2020 at 19:01, on Zulip):

Joshua Nelson said:

I would expect it to be an issue in codegen, not in rustbuild or anything like that

by this I meant I think it's a T-compiler issue

DPC (Sep 16 2020 at 19:02, on Zulip):

ah okay :smile:

Last update: Apr 15 2021 at 02:00UTC