Stream: t-compiler/wg-prioritization/alerts

Topic: I-prioritize #79908 regression 1.49: macro_rules unexpected…


triagebot (Dec 10 2020 at 18:33, on Zulip):

@WG-prioritization/alerts issue #79908 has been requested for prioritization.

Procedure

apiraino (Dec 16 2020 at 15:52, on Zulip):

I don't get it. Perhaps a P-medium because it involves a 3rd party lib that is being updated these days (prompted by this issue)?

apiraino (Dec 16 2020 at 15:53, on Zulip):

(or perhaps is just on the 3rd party lib)

Camelid (Dec 16 2020 at 21:27, on Zulip):

I just posted this:

@apiraino and I both feel unclear about this: Is this a Rust regression or a regression in a library that was then picked up by Crater?

apiraino (Dec 16 2020 at 21:32, on Zulip):

I think the answer is that crater is picking a library for the fourier tranform (for its test runs) that didnt release the last updates, so the maintainer is now pushing an update

apiraino (Dec 16 2020 at 21:32, on Zulip):

iiuc that should solve the issue

Camelid (Dec 16 2020 at 21:57, on Zulip):

This is a regression in the Rust compiler.

Camelid (Dec 16 2020 at 21:57, on Zulip):

(From simulacrum)

Camelid (Dec 16 2020 at 21:58, on Zulip):

IIUC the fourier thing was not a rustc bug, but the tiger one is.

apiraino (Dec 16 2020 at 22:03, on Zulip):

I see. I was confused, I admit this stuff is above my head :smiley:

Santiago Pastorino (Dec 16 2020 at 22:28, on Zulip):

@Camelid @apiraino it is unclear to me how bad this is

Santiago Pastorino (Dec 16 2020 at 22:28, on Zulip):

it doesn't seem too bad to deserve a P-critical but maybe it worth a P-high

apiraino (Dec 16 2020 at 22:34, on Zulip):

I don't have clear either what is broken but ... ok for a P-high out of caution.

apiraino (Dec 16 2020 at 22:34, on Zulip):

or maybe wait for a clearer mcve? can the team reason about this issue without a repro?

Santiago Pastorino (Dec 16 2020 at 22:36, on Zulip):

in general my reasoning is ... I try to add a priority to issues with the information we have and then maybe adjust later

Santiago Pastorino (Dec 16 2020 at 22:36, on Zulip):

mainly because we shouldn't miss something that looks like a P-critical or P-high because we still don't have a lot of information

Santiago Pastorino (Dec 16 2020 at 22:36, on Zulip):

I'd rather tag as high priority and then lower to just raise awareness

Santiago Pastorino (Dec 16 2020 at 22:36, on Zulip):

but unsure how others feels about this

Santiago Pastorino (Dec 16 2020 at 22:37, on Zulip):

cc @Joshua Nelson

Joshua Nelson (Dec 16 2020 at 22:37, on Zulip):

I think we should find if it affects crates other than fourier

Santiago Pastorino (Dec 16 2020 at 22:37, on Zulip):

the conversation we were just having is also about this I think :point_up:

Joshua Nelson (Dec 16 2020 at 22:37, on Zulip):

@Santiago Pastorino no, https://github.com/rust-lang/rust/issues/79904 is about trait bounds, not macros

Santiago Pastorino (Dec 16 2020 at 22:37, on Zulip):

Joshua Nelson said:

Santiago Pastorino no, https://github.com/rust-lang/rust/issues/79904 is about trait bounds, not macros

unsure what you meant :)

Joshua Nelson (Dec 16 2020 at 22:37, on Zulip):

Joshua Nelson said:

I think we should find if it affects crates other than fourier

looks like yes: https://github.com/rust-lang/rust/issues/79908#issuecomment-742733375

Santiago Pastorino (Dec 16 2020 at 22:38, on Zulip):

I was trying to say that in previous issues we were kind of discussing the same thing, like should we prioritize without a lot of info or should we wait

Joshua Nelson (Dec 16 2020 at 22:38, on Zulip):

Santiago Pastorino said:

the conversation we were just having is also about this I think :point_up:

I'm confused what this means then :sweat_smile: which conversation?

Joshua Nelson (Dec 16 2020 at 22:38, on Zulip):

ah ok

Santiago Pastorino (Dec 16 2020 at 22:38, on Zulip):

in another thread about another issue

Santiago Pastorino (Dec 16 2020 at 22:38, on Zulip):

that you were saying ... let's wait to prioritize and I was kind of preemptively trying to prioritize

Joshua Nelson (Dec 16 2020 at 22:39, on Zulip):

I think either P-high or wait for an MCVE

Joshua Nelson (Dec 16 2020 at 22:39, on Zulip):

but the fact that this affects multiple crates is slightly concerning

Santiago Pastorino (Dec 16 2020 at 22:39, on Zulip):

right, in general I guess I prefer to prioritize and then change

Santiago Pastorino (Dec 16 2020 at 22:39, on Zulip):

because it won't hurt anybody prioritizing this

Santiago Pastorino (Dec 16 2020 at 22:39, on Zulip):

and maybe somebody sees the issue and say, this is P-high then I'm going to pay closer attention

Santiago Pastorino (Dec 16 2020 at 22:40, on Zulip):

my guess is that by doing so ... we may get faster responses, results, fixes

Santiago Pastorino (Dec 16 2020 at 22:40, on Zulip):

we can even jump and try to fix them :)

Santiago Pastorino (Dec 16 2020 at 22:40, on Zulip):

for this one in particular then let's go with P-high

Santiago Pastorino (Dec 16 2020 at 22:41, on Zulip):

but I think this discussion is interesting

Santiago Pastorino (Dec 16 2020 at 22:41, on Zulip):

and I'd like to hear more thoughts :)

triagebot (Dec 16 2020 at 22:41, on Zulip):

Issue #79908's prioritization request has been removed.

apiraino (Dec 16 2020 at 22:47, on Zulip):

@Camelid nicely reduced to a small mcve, cool!

apiraino (Dec 16 2020 at 22:52, on Zulip):

Santiago Pastorino said:

my guess is that by doing so ... we may get faster responses, results, fixes

my reasoning (perhaps incorrect) is that an incomplete issue (without a clear analysis), even with a P-high label, is less useful for the team. it's like we're just signaling "hey look at this but we don't have a lot to say about it"

Santiago Pastorino (Dec 16 2020 at 23:01, on Zulip):

yes

Santiago Pastorino (Dec 16 2020 at 23:01, on Zulip):

let's create a topic about this conversation because it's basically the same thing we were just talking with @Joshua Nelson

Santiago Pastorino (Dec 16 2020 at 23:05, on Zulip):

#t-compiler/wg-prioritization > to prioritize or not to prioritize, that is the question

Camelid (Dec 16 2020 at 23:09, on Zulip):

Joshua Nelson said:

I think we should find if it affects crates other than fourier

@Joshua Nelson IIUC the fourier thing is totally unrelated.

Last update: Apr 15 2021 at 01:45UTC