Stream: t-compiler/wg-prioritization/alerts

Topic: I-prioritize #74702 ICE with the `(foo @ ..,)` pattern


triagebot (Jul 23 2020 at 23:38, on Zulip):

@WG-prioritization/alerts issue #74702 has been requested for prioritization.

Procedure

Yuki Okushi (Jul 24 2020 at 09:43, on Zulip):

this is an another case of #74539 (it's most recent stable-to-stable regression, the fix is backported to stable 1.45.1) and the fix needs some discussion (e.g. AST lowering vs. resolve), so I'd P-critical?

LeSeulArtichaut (Jul 26 2020 at 20:41, on Zulip):

I don't think we should tag this one P-critical since it is already fixed (fixed on nightly and stable, will be backported to stable).

the fix needs some discussion (e.g. AST lowering vs. resolve)

Then I think we should nominate it to raise awareness about this issue and start the discussion to properly fix this?

Yuki Okushi (Jul 26 2020 at 20:41, on Zulip):

nah, this one isn't fixed yet

Yuki Okushi (Jul 26 2020 at 20:42, on Zulip):

though the cause is the same, I believe

Santiago Pastorino (Jul 29 2020 at 14:53, on Zulip):

I'm just checking this one and this doesn't compile on older Rust versions

Santiago Pastorino (Jul 29 2020 at 14:54, on Zulip):

it started to ICE on 1.45 but before it didn't compile

Santiago Pastorino (Jul 29 2020 at 14:55, on Zulip):

so I don't think it should be P-critical

Santiago Pastorino (Jul 29 2020 at 14:56, on Zulip):

@WG-prioritization/alerts P-high? P-medium?

Santiago Pastorino (Jul 29 2020 at 14:56, on Zulip):

and btw, https://github.com/rust-lang/rust/issues/74539

Santiago Pastorino (Jul 29 2020 at 14:56, on Zulip):

shouldn't we prioritize that one?

LeSeulArtichaut (Jul 29 2020 at 14:57, on Zulip):

This is now fixed on master, right?

Santiago Pastorino (Jul 29 2020 at 14:57, on Zulip):

no idea :)

Santiago Pastorino (Jul 29 2020 at 14:58, on Zulip):

was just starting to check

Santiago Pastorino (Jul 29 2020 at 14:58, on Zulip):

related discussion https://rust-lang.zulipchat.com/#narrow/stream/245100-t-compiler.2Fwg-prioritization.2Falerts/topic/I-prioritize.20.2374539.20ICE.20with.20the.20.60.40.20.2E.2E.60.20binding.20pattern

LeSeulArtichaut (Jul 29 2020 at 14:58, on Zulip):

Ah nvm

Santiago Pastorino (Jul 29 2020 at 14:58, on Zulip):

but the thing is ... the issue is still open, why?

Santiago Pastorino (Jul 29 2020 at 14:58, on Zulip):

it's an issue on beta/stable? does it needs a backport then?

LeSeulArtichaut (Jul 29 2020 at 14:58, on Zulip):

I keep getting confused by #74539

Santiago Pastorino (Jul 29 2020 at 14:59, on Zulip):

@LeSeulArtichaut so ... is it really fixed on master?

Santiago Pastorino (Jul 29 2020 at 14:59, on Zulip):

I don't see a PR that references it

Santiago Pastorino (Jul 29 2020 at 14:59, on Zulip):

ohh sorry

Santiago Pastorino (Jul 29 2020 at 14:59, on Zulip):

yes

Santiago Pastorino (Jul 29 2020 at 14:59, on Zulip):

it was re-opened to track beta/stable backports

Santiago Pastorino (Jul 29 2020 at 14:59, on Zulip):

ok

Santiago Pastorino (Jul 29 2020 at 15:00, on Zulip):

nvm then

LeSeulArtichaut (Jul 29 2020 at 15:00, on Zulip):

I think #74702 isn’t fixed yet

Santiago Pastorino (Jul 29 2020 at 15:00, on Zulip):

@LeSeulArtichaut anyway back to #74702, P-high? P-medium?

Santiago Pastorino (Jul 29 2020 at 15:00, on Zulip):

LeSeulArtichaut said:

I think #74702 isn’t fixed yet

right, I was talking about the other one :), sorry for confusing you

LeSeulArtichaut (Jul 29 2020 at 15:01, on Zulip):

#74702 gives an error message before the ICE

LeSeulArtichaut (Jul 29 2020 at 15:01, on Zulip):

So I don’t think it should be P-high

LeSeulArtichaut (Jul 29 2020 at 15:01, on Zulip):

We might even want it to be P-low?

LeSeulArtichaut (Jul 29 2020 at 15:02, on Zulip):

Unless it is supposed to compile successfully?

Yuki Okushi (Jul 29 2020 at 15:02, on Zulip):

but it's the most resent stable regression

Yuki Okushi (Jul 29 2020 at 15:04, on Zulip):

and the fix needs discussion, we might want to revert the fix #74557 as Vadim Petrochenkov said

Santiago Pastorino (Jul 29 2020 at 15:04, on Zulip):

I think P-medium is fine and as an average :P

Santiago Pastorino (Jul 29 2020 at 15:05, on Zulip):

Yuki Okushi said:

and the fix needs discussion, we might want to revert the fix #74557 as Vadim Petrochenkov said

well that's important, maybe the issue needs to be nominated

LeSeulArtichaut (Jul 29 2020 at 15:05, on Zulip):

Yeah, seems like a good candidate for nomination?

Yuki Okushi (Jul 29 2020 at 15:05, on Zulip):

yeah, agreed

Santiago Pastorino (Jul 29 2020 at 15:05, on Zulip):

I'd say P-medium and nominate it then

LeSeulArtichaut (Jul 29 2020 at 15:05, on Zulip):

How many I-nominated do we have rn?

LeSeulArtichaut (Jul 29 2020 at 15:07, on Zulip):

We have 2 I-nominated T-compiler

triagebot (Jul 29 2020 at 15:08, on Zulip):

Issue #74702's prioritization request has been removed.

Last update: Apr 10 2021 at 22:00UTC