Stream: t-compiler/wg-prioritization/alerts

Topic: #82151 `undefined reference to` linker error when using dyl…


triagebot (Feb 15 2021 at 17:44, on Zulip):

@WG-prioritization/alerts issue #82151 has been requested for prioritization.

Procedure

Hameer Abbasi (Feb 15 2021 at 18:06, on Zulip):

Linking error on valid code, symbols not exported. Looks like a P-high, but goes to at least beginning 2018.

apiraino (Feb 15 2021 at 21:46, on Zulip):

hmm probably I would also say P-high as the previous linked issue.
I am missinf @Hameer Abbasi where you find a reference so back in time. At a cursory look, the linked issue go back up to mid 2019 with stable 1.36 (though I admit I got a bit lost exploring the linked issues).

apiraino (Feb 15 2021 at 21:46, on Zulip):

I am asking to understand if this can be considered a stable-to-stable regression (which I tend to say yes)

Hameer Abbasi (Feb 16 2021 at 05:00, on Zulip):

I used cargo-bisect-rustc with a start date set to 2018-01-01.

apiraino (Feb 17 2021 at 11:48, on Zulip):

@WG-prioritization I am re-reading this issue and I agree with Hameer Abbasi on a high priority, but I am also wondering about the impact, if this issue is really there since so long. The issue seems to be about working code not working anymore after updating dependencies.
Which team could be pinged to have a look at that?

Hameer Abbasi (Feb 17 2021 at 11:56, on Zulip):

To clarify: crates compile and test fine on both old and new versions. But externally, the linker doesn’t find symbols even though there’s a pub and a pub use. Is there a linking or exporting symbols team? 🙂

Hameer Abbasi (Feb 17 2021 at 11:58, on Zulip):

It may just be that the crate, when updated, introduced the bug. The question is, should pub use re-export symbols?

apiraino (Feb 17 2021 at 12:03, on Zulip):

I think t-compiler is fine. I don't have the context for more reasoning about this issue.
I'm asking myself the question if this needs to be pushed on the agenda table with an I-nominate :thinking:

by the way, could you add the results of your bisection? they could add interesting data

Hameer Abbasi (Feb 17 2021 at 12:24, on Zulip):

Added the results about the bisection, I agree with I-nominate.

apiraino (Feb 17 2021 at 12:33, on Zulip):

cool thanks!

apiraino (Feb 25 2021 at 16:35, on Zulip):

Brief discussion during the meeting.

Let's leave it I-nominate for discussion in 2 weeks (March, 11th) and assign P-high

triagebot (Feb 25 2021 at 16:36, on Zulip):

Issue #82151's prioritization request has been removed.

Last update: Apr 17 2021 at 00:00UTC