Stream: t-compiler/wg-prioritization/alerts

Topic: I-prioritize #78532 VecDeque from Vec fails with ZST

triagebot (Oct 29 2020 at 20:55, on Zulip):

@WG-prioritization/alerts issue #78532 has been requested for prioritization.


Camelid (Oct 29 2020 at 20:56, on Zulip):


lcnr (Oct 29 2020 at 20:57, on Zulip):

yeah, seems about right :thumbs_up: I fear that VecDeque probably has more issues with ZSTs than just that though

lcnr (Oct 29 2020 at 20:58, on Zulip):

there really shouldn't be a reason to use a queue of objects carrying no information, so we have close to no usage or test coverage here

Camelid (Oct 29 2020 at 20:58, on Zulip):

I'll wait for a bit to see if anyone disagrees with the priority

LeSeulArtichaut (Oct 29 2020 at 21:11, on Zulip):

Seems good to me, though maybe I'd have expected P-medium here

Joshua Nelson (Oct 29 2020 at 21:12, on Zulip):

P-medium sounds good to me, you'd have to do this intentionally and it's a panic, not a crash or unsoundness

LeSeulArtichaut (Oct 29 2020 at 21:13, on Zulip):

Plus IIUC it's been there for a long time?

Camelid (Oct 29 2020 at 21:27, on Zulip):

I still think P-high is better just to be on the safe side. It's possible there's some valid use case for a queue of ZSTs -- maybe something like Diesel's type magic

Camelid (Oct 29 2020 at 21:27, on Zulip):

But I'm okay with P-medium as well

lcnr (Oct 29 2020 at 21:28, on Zulip):

i am not completely certain that we can't cause ub here tbh

Camelid (Oct 29 2020 at 21:29, on Zulip):

Ok, going with P-high then

triagebot (Oct 29 2020 at 21:29, on Zulip):

Issue #78532's prioritization request has been removed.

Last update: Apr 16 2021 at 23:00UTC