Stream: t-compiler/wg-prioritization/alerts

Topic: I-prioritize #79103 Rustdoc takes 8.5 GB of memory to docum…


triagebot (Nov 16 2020 at 15:53, on Zulip):

@WG-prioritization/alerts issue #79103 has been requested for prioritization.

Procedure

Joshua Nelson (Nov 16 2020 at 15:54, on Zulip):

so I'm torn on this one, because on the one hand it's causing giant problems for docs.rs and stm32

Joshua Nelson (Nov 16 2020 at 15:55, on Zulip):

but on the other hand, it's been like this for ages

Joshua Nelson (Nov 16 2020 at 15:57, on Zulip):

for context, I've been talking with @seeplusplus about https://github.com/rust-lang/rust/issues/78761 and I'd guess they're probably 2-3 weeks from having working code

Joshua Nelson (Nov 16 2020 at 15:57, on Zulip):

and I don't even watn to start on https://github.com/rust-lang/rust/issues/76382 until I finish https://github.com/rust-lang/rust/pull/78082, which is itself a multi-month project IMO

Joshua Nelson (Nov 16 2020 at 15:58, on Zulip):

tl;dr rustdoc is a mess and I feel like I'm the only one cleaning it up :(

Jonas Schievink (Nov 16 2020 at 15:59, on Zulip):

we appreciate it :)

Jonas Schievink (Nov 16 2020 at 16:00, on Zulip):

these "janitorial" tasks are precisely what needs funding instead of volunteer work

Joshua Nelson (Nov 16 2020 at 16:00, on Zulip):

I'm looking for jobs

Joshua Nelson (Nov 16 2020 at 16:03, on Zulip):

but yeah realistically this is probably not something I can fix on my own, at least any sooner than ~a year from now

Camelid (Nov 16 2020 at 18:45, on Zulip):

This may be ridiculous but maybe there’s some way of doing a joint PR among many people?

Camelid (Nov 16 2020 at 18:46, on Zulip):

Then it wouldn’t fall all on one person.

Joshua Nelson (Nov 16 2020 at 19:02, on Zulip):

Well getting rid of doctree can be split in smaller PRs, that's not the issue

Joshua Nelson (Nov 16 2020 at 19:03, on Zulip):

It's just that no one else is working on this :/

Joshua Nelson (Nov 16 2020 at 19:03, on Zulip):

@Camelid are you volunteering? :P

Joshua Nelson (Nov 16 2020 at 19:04, on Zulip):

It also needs a fair amount of design work, mentoring someone to do it would be more work than doing it myself I think

Camelid (Nov 16 2020 at 19:05, on Zulip):

Yeah, I'm not sure if I know enough about rustdoc and its interaction with rustc to work on this.

Camelid (Nov 16 2020 at 19:06, on Zulip):

Is doctree the primary issue here?

Joshua Nelson (Nov 16 2020 at 19:06, on Zulip):

Like the html-diff PR came out of the existing tools not being good enough to debug the doctree failures, I wouldn't expect someone not familiar with rustdoc/bootstrap to take that up

Camelid (Nov 16 2020 at 19:06, on Zulip):

But I could try to help a bit :)

Joshua Nelson (Nov 16 2020 at 19:06, on Zulip):

No, doctree is just blocking the actual changes I want to do

Joshua Nelson (Nov 16 2020 at 19:07, on Zulip):

Which are things like getting rid of clean::Item and getting proper ParamEnvs for normalization

Joshua Nelson (Nov 16 2020 at 19:08, on Zulip):

Really DocContext is what's bad, not clean::Item

Joshua Nelson (Nov 16 2020 at 19:09, on Zulip):

It means rustdoc is holding all of the info about all of the crate through the life of the program

Joshua Nelson (Nov 16 2020 at 19:09, on Zulip):

It's as bad as calling Box::leak

Camelid (Nov 16 2020 at 19:15, on Zulip):

What does clean even do?

Joshua Nelson (Nov 16 2020 at 19:19, on Zulip):

I don't have time right now but ping me tomorrow and I can help

Joshua Nelson (Nov 16 2020 at 19:19, on Zulip):

or #rustdoc will know

triagebot (Dec 11 2020 at 22:31, on Zulip):

Issue #79103's prioritization request has been removed.

Camelid (Dec 11 2020 at 22:32, on Zulip):

P-medium. See issue for reasoning.

Joshua Nelson (Dec 11 2020 at 22:32, on Zulip):

@Camelid curious to hear your reasoning for P-medium?

Joshua Nelson (Dec 11 2020 at 22:32, on Zulip):

ah ok

Camelid (Dec 11 2020 at 22:32, on Zulip):

P-medium: it's annoying that it takes so much memory, but it's not like you can't document it. And it's being worked on.

Last update: Apr 10 2021 at 22:30UTC