Stream: t-compiler/wg-prioritization/alerts

Topic: I-prioritize #46345 thread::Builder::spawn returns WouldBlo…


triagebot (Oct 20 2020 at 20:45, on Zulip):

@WG-prioritization/alerts issue #46345 has been requested for prioritization.

Procedure

Joshua Nelson (Oct 20 2020 at 20:47, on Zulip):

there are two separate issues here and I'm not sure which @Camelid wanted us to prioritize

Joshua Nelson (Oct 20 2020 at 20:47, on Zulip):

the first is 'sometimes my computer runs out of available threads' which we can't do anything about

Joshua Nelson (Oct 20 2020 at 20:47, on Zulip):

the second is 'the error code is interpreted as EWOULDBLOCK instead of EAGAIN

Joshua Nelson (Oct 20 2020 at 20:48, on Zulip):

the second IMO is P-low, the only thing it affects is Debug output (not even Display)

Camelid (Oct 20 2020 at 20:48, on Zulip):

I thought the issue was that spawning the thread might take a few seconds, but rustc panics immediately

Camelid (Oct 20 2020 at 20:48, on Zulip):

Is that not correct?

Joshua Nelson (Oct 20 2020 at 20:50, on Zulip):

no, that's user code panicking, not hte compiler

Joshua Nelson (Oct 20 2020 at 20:50, on Zulip):

they need to handle the error somehow, the standard library can't do it for them

Joshua Nelson (Oct 20 2020 at 20:50, on Zulip):

https://github.com/rust-lang/rust/issues/46345#issuecomment-586383627

Camelid (Oct 20 2020 at 20:52, on Zulip):

Sorry, what I mean is this code seems to be used by the compiler, which can cause panics: #72482

Joshua Nelson (Oct 20 2020 at 20:52, on Zulip):

that's a separate issue

Joshua Nelson (Oct 20 2020 at 20:53, on Zulip):

I don't think it should have been marked as a duplicate

Camelid (Oct 20 2020 at 20:53, on Zulip):

Oh. Reopen it if you see fit!

Camelid (Oct 20 2020 at 20:54, on Zulip):

I may have been a bit over-eager when triaging :smile:

Joshua Nelson (Oct 20 2020 at 20:56, on Zulip):

done

Joshua Nelson (Oct 20 2020 at 20:56, on Zulip):

and my vote for the current issue (46345) is P-low

Joshua Nelson (Oct 20 2020 at 21:03, on Zulip):

left a comment on the issue

apiraino (Oct 21 2020 at 22:23, on Zulip):

thanks @Camelid and @Joshua Nelson for the analysis. Going for P-low as suggested :thumbs_up:

Camelid (Oct 21 2020 at 22:49, on Zulip):

I wonder why triagebot didn't pick up the state change...

apiraino (Oct 21 2020 at 22:52, on Zulip):

when the issue is renamed after it has been labeled for prioritisation, the notification arrives in the new thread :laughter_tears:

Last update: Apr 11 2021 at 18:00UTC