Stream: t-compiler/wg-prioritization/alerts

Topic: #80303 VecDeque's Hash::hash implementation is incorrect


triagebot (Jan 16 2021 at 21:02, on Zulip):

@WG-prioritization/alerts issue #80303 has been requested for prioritization.

Procedure

apiraino (Jan 17 2021 at 01:17, on Zulip):

I would assign a p-critical. At least a p-high. The reason I can think of is preventing to reach stable and cause (what I think could be) important regressions. This issue looks to already have a hero assigned Stu

Camelid (Jan 17 2021 at 01:50, on Zulip):

@apiraino IIUC, this isn't a regression.

Camelid (Jan 17 2021 at 01:50, on Zulip):

Seems like P-medium or P-high to me. Maybe P-high.

apiraino (Jan 17 2021 at 01:57, on Zulip):

hm ... interesting, then I probably misunderstood the context. I thought that the core of the problem was that vecdeque does not give the same result as another hashing package hasher (like, vecdeque doesn't find an element when it should).

Camelid (Jan 17 2021 at 01:59, on Zulip):

I'm not exactly sure what the underlying issue is, but I don't think it's a regression. Or, if it is, it's already hit stable.

apiraino (Jan 20 2021 at 12:34, on Zulip):

this issue is being taken care of, I see a PR in the pipeline.
I think I will assign a P-medium for now like Camelid suggested.

A P-high means that it would get briefly under the compiler team scrutiny tomorrow. If there's an advantage in that, then maybe better a P-high.

triagebot (Jan 20 2021 at 12:34, on Zulip):

Issue #80303's prioritization request has been removed.

Last update: Apr 10 2021 at 23:00UTC