Stream: t-compiler/wg-prioritization/alerts

Topic: I-prioritize #75804 "hello world" binary size increase in e…


triagebot (Aug 22 2020 at 13:53, on Zulip):

@WG-prioritization/alerts issue #75804 has been requested for prioritization.

Procedure

LeSeulArtichaut (Aug 22 2020 at 14:15, on Zulip):

I’d suggest to nominate this one to raise awareness

LeSeulArtichaut (Aug 22 2020 at 14:15, on Zulip):

I don’t think we have any other actionable items

DPC (Aug 24 2020 at 14:55, on Zulip):

isn't this tracked by perf already?

Joshua Nelson (Aug 24 2020 at 17:44, on Zulip):

it isn't, see discussion in #t-compiler/performance > Regression in helloworld binary size for each release

LeSeulArtichaut (Aug 24 2020 at 17:45, on Zulip):

it's long been desired for perf.rlo to track this, just not something we've done yet. shouldn't really even be all that hard to add -- just needs some design and thought.

Joshua Nelson (Aug 24 2020 at 17:45, on Zulip):

IMO I don't think nominating would help much, the only thing to say is "let's track this in perf"

LeSeulArtichaut (Aug 24 2020 at 17:45, on Zulip):

Let’s remove I-prioritize then?

Joshua Nelson (Aug 24 2020 at 17:47, on Zulip):

well, I guess it should be given a priority at least

Joshua Nelson (Aug 24 2020 at 17:47, on Zulip):

but the measurement was taken without much precision, not even panic = "abort", so I think P-low

Santiago Pastorino (Aug 26 2020 at 19:09, on Zulip):
RUST_DBG_FLAGS='-C debuginfo=1 -C panic=abort -C opt-level=0'
RUST_REL_FLAGS='-C debuginfo=0 -C panic=abort -C opt-level=3'
Santiago Pastorino (Aug 26 2020 at 19:10, on Zulip):

@Joshua Nelson :point_up: it has used panic=abort or am I wrong?

Joshua Nelson (Aug 26 2020 at 19:10, on Zulip):

oh I missed that, sorry

Santiago Pastorino (Aug 26 2020 at 19:11, on Zulip):

shouldn't we ping cleanup to at least search for the commit that made this huge regression between beta and nightly?

Santiago Pastorino (Aug 26 2020 at 19:11, on Zulip):

well if it's just one, maybe there is more than one

Santiago Pastorino (Aug 26 2020 at 19:11, on Zulip):

unsure what prioritity should we give to this one

Santiago Pastorino (Aug 26 2020 at 19:11, on Zulip):

P-medium maybe?

Santiago Pastorino (Aug 26 2020 at 19:42, on Zulip):

bump, this is pending ...

LeSeulArtichaut (Aug 26 2020 at 21:10, on Zulip):

P-medium seems fine

LeSeulArtichaut (Aug 26 2020 at 21:11, on Zulip):

I mean, it’s a long-standing issue that’s never been caught before and it’s only a hello world

LeSeulArtichaut (Aug 26 2020 at 21:11, on Zulip):

To me the real question is: does this issue affect more complex programs?

triagebot (Aug 27 2020 at 01:20, on Zulip):

Issue #75804's prioritization request has been removed.

Last update: Apr 11 2021 at 18:00UTC