Stream: t-compiler/wg-prioritization/alerts

Topic: I-prioritize #71104 Some `NodeId`/`LocalDefId` don't have a

triagebot (Jun 29 2020 at 15:07, on Zulip):

@WG-prioritization/alerts issue #71104 has been requested for prioritization.

Procedure

DPC (Jun 29 2020 at 15:17, on Zulip):

this issue is blocking intra-docs for a week and there is no clear path on how to proceed with it, so some compiler :eyes: would be useful

Joshua Nelson (Jun 29 2020 at 15:21, on Zulip):

Well, I have a path. I'm just not sure it's a very good one :laughing: https://github.com/rust-lang/rust/pull/73566

LeSeulArtichaut (Jun 29 2020 at 15:33, on Zulip):

I think we can I-nominated it

LeSeulArtichaut (Jun 29 2020 at 15:33, on Zulip):

That’s the best way to have T-compiler folks looking at it imo

LeSeulArtichaut (Jun 29 2020 at 15:33, on Zulip):

But that means that we’d have to wait until Thursday

DPC (Jun 29 2020 at 15:34, on Zulip):

I was tempted, but i thought better to get opinion first

DPC (Jun 29 2020 at 15:34, on Zulip):

that should be fine (that was the intention)

LeSeulArtichaut (Jun 29 2020 at 15:35, on Zulip):

In the meantime I think we can prioritize it to P-high or even P-critical as a "potential release blocker"?

Joshua Nelson (Jun 29 2020 at 15:38, on Zulip):

Note that a fair amount of rustdoc people have already looked at the PR so the question is more 'is this a reasonable tradeoff to make' than 'is there a solution that exists'

LeSeulArtichaut (Jun 29 2020 at 15:49, on Zulip):

Let’s nominate it already

triagebot (Jun 29 2020 at 15:49, on Zulip):

@WG-prioritization/alerts #71104 has been nominated for discussion in T-compiler meeting.

Procedure

LeSeulArtichaut (Jun 29 2020 at 16:03, on Zulip):

Hmm, that message isn’t supposed to pop up here

LeSeulArtichaut (Jun 29 2020 at 16:03, on Zulip):

Anyway, what do you think about the priority of this?

Joshua Nelson (Jun 29 2020 at 16:08, on Zulip):

I think it's P-high, @Manish Goregaokar will probably think P-critical (they really want to get intra-doc links out :laughing: )

Joshua Nelson (Jun 29 2020 at 16:09, on Zulip):

but yes this is definitely a blocker for intra-doc links, I don't even know if it's possible to make them work without since you need to know the parent module of the item and there's no way to do that without climbing the DefId tree

Joshua Nelson (Jun 29 2020 at 16:12, on Zulip):

oops sorry that wasn't addressed to me

LeSeulArtichaut (Jun 29 2020 at 16:15, on Zulip):

No, any opinion is welcome! :slight_smile:

LeSeulArtichaut (Jun 29 2020 at 16:16, on Zulip):

And you probably know this issue better than me or DPC

DPC (Jun 30 2020 at 12:11, on Zulip):

i'm going with p-high on this.

triagebot (Jun 30 2020 at 12:11, on Zulip):

Issue #71104's prioritization request has been removed.

LeSeulArtichaut (Jun 30 2020 at 12:20, on Zulip):

Agenda entry:

DPC (Jun 30 2020 at 12:29, on Zulip):

wait duh this was nominated, do we still p-* it?

LeSeulArtichaut (Jun 30 2020 at 13:40, on Zulip):

I believe we should

LeSeulArtichaut (Jun 30 2020 at 13:41, on Zulip):

Though this isn’t technically an issue, this is a blocker for other features so I think we should keep track of it

LeSeulArtichaut (Jun 30 2020 at 13:41, on Zulip):

That’s only my opinion though

Last update: Apr 10 2021 at 22:30UTC