@WG-prioritization/alerts issue #77477 has been requested for prioritization.
I think we need to confirm this is a bug before prioritizing it
(clearly the miri ICE is a bug, but not sure about the unsafe code)
looks like we don't actually valide this somewhere and miri expects it to be validated
I wasn't able to find if an incorrect index is supposed to be an error or UB :shrug:
anyways, I guess this looks
P-medium to me
seems fine to me, anywhere that has
unsafe I think it's reasonable to put the onus on the caller
seems fine to me, anywhere that has unsafe I think it's reasonable to put the onus on the caller
a bit unrelated but I actually disagree there :smile: even for unsafe code we should prevent as much "certainly wrong" unsafe code as possible.
CString::as_ptr adding the lint to the compiler is extremely valuable imo
yes, that's fair enough
Issue #77477's prioritization request has been removed.
Yeah you're supposed to generally have a bounded set of invariants to uphold, not literally anything.