Stream: t-compiler/wg-prioritization/alerts

Topic: I-prioritize #79560 Internal Compiler Error while compiling…


triagebot (Nov 30 2020 at 12:47, on Zulip):

@WG-prioritization/alerts issue #79560 has been requested for prioritization.

Procedure

Stu (Nov 30 2020 at 12:51, on Zulip):

P-critical IMO

triagebot (Nov 30 2020 at 13:23, on Zulip):

Issue #79560's prioritization request has been removed.

Hameer Abbasi (Nov 30 2020 at 13:59, on Zulip):

I've labelled it P-critical based on the thumbs-ups. :)

Santiago Pastorino (Nov 30 2020 at 14:03, on Zulip):

going to take a look at this, already assigned to myself

Santiago Pastorino (Nov 30 2020 at 14:04, on Zulip):

feeling the pressure now of introducing a P-critical issue to the compiler :)

matthiaskrgr (Nov 30 2020 at 14:17, on Zulip):

@Santiago Pastorino if you need a smaller datapoint, https://github.com/marwes/combine also crashes rustc but its probably a bit smaller than diesel :)

Santiago Pastorino (Nov 30 2020 at 14:18, on Zulip):

yeah, pinged cleanup to see if we're able to get an MCVE

Santiago Pastorino (Nov 30 2020 at 14:18, on Zulip):

btw

Santiago Pastorino (Nov 30 2020 at 14:18, on Zulip):

@weiznich you could make a PR to cargotest adding diesel. I don't think it would be a very controversial add, it exercises a lot more of the compiler than something like regex.

Santiago Pastorino (Nov 30 2020 at 14:19, on Zulip):

@Joshua Nelson what would adding diesel to cargotest mean?

Joshua Nelson (Nov 30 2020 at 14:19, on Zulip):

@Santiago Pastorino it would get run on every bors test

Joshua Nelson (Nov 30 2020 at 14:19, on Zulip):

There are already a lot crates that get run already

Santiago Pastorino (Nov 30 2020 at 14:19, on Zulip):

right, that makes sense

Santiago Pastorino (Nov 30 2020 at 14:20, on Zulip):

I understand maintainer's frustration with issues like this but as this group knows, there are always at least a couple of P-criticals that somebody hit

Santiago Pastorino (Nov 30 2020 at 14:20, on Zulip):

I think it's unavoidable on nightly

Joshua Nelson (Nov 30 2020 at 14:49, on Zulip):

I do think it has value in the sense that we catch regressions earlier

Joshua Nelson (Nov 30 2020 at 14:49, on Zulip):

like, diesel will catch a lot more bugs than what we test currently

Santiago Pastorino (Nov 30 2020 at 15:06, on Zulip):

yeah, right

Last update: Apr 10 2021 at 21:15UTC