Stream: t-compiler/wg-prioritization/alerts

Topic: I-prioritize #74780 Type-based search does not work since M…


triagebot (Jul 26 2020 at 15:26, on Zulip):

@WG-prioritization/alerts issue #74780 has been requested for prioritization.

Procedure

Yuki Okushi (Jul 26 2020 at 17:20, on Zulip):

(it's T-rustdoc issue but I'll leave a label since it's useful for that team, related: https://github.com/rust-lang/triagebot/issues/714)

Santiago Pastorino (Jul 29 2020 at 14:48, on Zulip):

@Yuki Okushi if other teams start using it, :+1: to your idea then

Yuki Okushi (Jul 29 2020 at 14:54, on Zulip):

yeah at least rustdoc team wants to use it

Santiago Pastorino (Jul 29 2020 at 15:08, on Zulip):

:+1:

LeSeulArtichaut (Jul 29 2020 at 15:10, on Zulip):

Maybe we should only be notified for T-compiler I-prioritize? Though it might have the same problems as I-nominated, where we don’t get pings when we should

apiraino (Sep 16 2020 at 16:42, on Zulip):

@LeSeulArtichaut thinking about implementing this. I was having a look at how the triagebot work:
https://github.com/rust-lang/rust/blob/5fae56971d8487088c0099c82c0a5ce1638b5f62/triagebot.toml#L75-L87

I'm still missing some pieces of how the bot works :thinking: could it be that we can exclude all teams but T-compiler and libs-impl and have it deliver us only notifications about issues we care?

cc: @Santiago Pastorino

Joshua Nelson (Sep 16 2020 at 16:44, on Zulip):

please don't change this

Joshua Nelson (Sep 16 2020 at 16:45, on Zulip):

rustdoc wants to be notified for all regressions

Joshua Nelson (Sep 16 2020 at 16:45, on Zulip):

if you want to automate something, automate pinging rust-lang/rustdoc anytime someone labels as regression

Joshua Nelson (Sep 16 2020 at 16:46, on Zulip):

and labelling as P-high, if you do both of those I'm fine with not notifying the wg-prioritization stream

Joshua Nelson (Sep 16 2020 at 16:46, on Zulip):

but otherwise the issues will just sit unnoticed for months

Joshua Nelson (Sep 16 2020 at 16:47, on Zulip):

more discussion: https://rust-lang.zulipchat.com/#narrow/stream/227806-t-compiler.2Fwg-prioritization/topic/triagebot.20I-prioritize

apiraino (Sep 16 2020 at 16:50, on Zulip):

yeah, we don't want that, I was trying to figure out how to automate letting the relevant team about their github issues, without changing the triagebot (but rather configuring it).
But I'm not sure it can be simply configured for that (e.g. adding another [notify-zulip.xxxx] section that sends them instead to us

apiraino (Sep 16 2020 at 16:50, on Zulip):

so probably like you say the best way is to configure the bot also on their repo

Joshua Nelson (Sep 16 2020 at 16:51, on Zulip):

well rustdoc isn't on zulip

Joshua Nelson (Sep 16 2020 at 16:51, on Zulip):

and I don't know if triagebot has discord permissions

Joshua Nelson (Sep 16 2020 at 16:51, on Zulip):

but it would be better to ping on github anyway

apiraino (Sep 16 2020 at 16:52, on Zulip):

ok, fair enough :) that's fine

edit : thanks :)

Joshua Nelson (Sep 16 2020 at 16:54, on Zulip):

sorry, didn't mean to jump down your throat

Joshua Nelson (Sep 16 2020 at 16:54, on Zulip):

just didn't want these issues to get lost

apiraino (Sep 16 2020 at 16:56, on Zulip):

no worries

LeSeulArtichaut (Sep 16 2020 at 17:24, on Zulip):

I think, as the team that uses I-prioritize the most, that we can afford having notifications from other teams

LeSeulArtichaut (Sep 16 2020 at 17:24, on Zulip):

We can just ignore them

LeSeulArtichaut (Sep 16 2020 at 17:25, on Zulip):

If we limit ourselves to T-compiler and libs-impl, I fear that we’re going to run into the same problem as with I-nominated (when we had pings for it) where triagebot didn’t trigger because there was no T-compiler label

LeSeulArtichaut (Sep 16 2020 at 17:27, on Zulip):

If we really want to only have pings for T-compiler, we should change how triagebot works (I was the one implementing the feature so it’s not great rn :grinning_face_with_smiling_eyes:)

Camelid (Sep 17 2020 at 19:18, on Zulip):

Should I remove I-prioritize? If so, should I add P-low or P-medium?

DPC (Sep 17 2020 at 19:29, on Zulip):

yeah in the past it didn't made sense, because rustdoc didn't have the bandwidth so anything being prioritised would stay on for months :stuck_out_tongue:

DPC (Sep 17 2020 at 19:29, on Zulip):

i guess that's settled now so should be fine

DPC (Sep 17 2020 at 19:35, on Zulip):

i'd suggest for other teams especially the smaller ones we can nominate them directly

Joshua Nelson (Sep 17 2020 at 21:04, on Zulip):

DPC said:

i'd suggest for other teams especially the smaller ones we can nominate them directly

again, nominating does nothing without weekly meetings

Joshua Nelson (Sep 17 2020 at 21:04, on Zulip):

you need to talk to the team to see what they want you to do

apiraino (Sep 17 2020 at 21:18, on Zulip):

Just curious, do you (or anyone) know if there's some automation to notify the team when a T-* tag is applied to an issue? By your response I'd say no, correct?

Joshua Nelson (Sep 17 2020 at 21:43, on Zulip):

not for rustdoc at least

Joshua Nelson (Sep 17 2020 at 21:43, on Zulip):

not sure about other teams

DPC (Sep 17 2020 at 22:02, on Zulip):

well general rule earlier was to nominate the issues, then team decides how they want to handle them- most of them check during meetings and for those without meetings they often check async-ly

Joshua Nelson (Sep 17 2020 at 22:08, on Zulip):

I just think you should ask :/

Joshua Nelson (Sep 17 2020 at 22:09, on Zulip):

they don't know to look for I-nominated unless you say that's what you're going to do

DPC (Sep 18 2020 at 00:38, on Zulip):

sure we can ask, but I-nominated has been around for a long time. It's up to the teams to decide how to process these

Last update: Apr 15 2021 at 02:15UTC