Stream: t-compiler/wg-prioritization/alerts

Topic: I-prioritize #80303 VecDeque's Hash::hash implementation is…


triagebot (Dec 22 2020 at 19:14, on Zulip):

@WG-prioritization/alerts issue #80303 has been requested for prioritization.

Procedure

Léo Lanteri Thauvin (Dec 22 2020 at 19:24, on Zulip):

If this is a T-libs issue we probably shouldn't prioritize it

Camelid (Dec 22 2020 at 23:23, on Zulip):

Why? We prioritize other T-libs issues.

Camelid (Dec 22 2020 at 23:24, on Zulip):

E.g. #79808

Léo Lanteri Thauvin (Dec 22 2020 at 23:24, on Zulip):

That is an implementation issue

Léo Lanteri Thauvin (Dec 22 2020 at 23:24, on Zulip):

i.e. libs-impl

Léo Lanteri Thauvin (Dec 22 2020 at 23:24, on Zulip):

Here this needs a decision from T-libs

Léo Lanteri Thauvin (Dec 22 2020 at 23:27, on Zulip):

Well, we could prioritize the issue at hand, that VecDeque is hashed differently after a few rotates when it should not

Camelid (Dec 22 2020 at 23:28, on Zulip):

Well this seems to be a libs-impl issue as well.

Camelid (Dec 22 2020 at 23:29, on Zulip):

We should still prioritize even if it needs a decision. It will help T-libs figure out which things that they need to decide on are high priority.

Camelid (Dec 22 2020 at 23:29, on Zulip):

I think P-high might be right. (Or maybe P-medium, but not sure.)

Léo Lanteri Thauvin (Dec 22 2020 at 23:33, on Zulip):

Note that this works with the standard DefaultHasher

Léo Lanteri Thauvin (Dec 22 2020 at 23:33, on Zulip):

It doesn't work with the hasher from ahash

Camelid (Dec 22 2020 at 23:34, on Zulip):

Huh, didn't realize that. Can you add that to the issue?

Camelid (Dec 22 2020 at 23:34, on Zulip):

Also, is it Hash's fault that ahash isn't working?

Léo Lanteri Thauvin (Dec 22 2020 at 23:35, on Zulip):

The point that cuviper made in their comment was that depending on the T-libs decision, this might either be a bug in VecDeque, the int types, or in ahash

Léo Lanteri Thauvin (Dec 22 2020 at 23:35, on Zulip):

Which is why I'd wait for T-libs decision here

triagebot (Dec 22 2020 at 23:37, on Zulip):

Issue #80303's prioritization request has been removed.

Léo Lanteri Thauvin (Dec 22 2020 at 23:37, on Zulip):

Removed I-prioritize and added I-needs-decision for T-libs

apiraino (Dec 30 2020 at 14:47, on Zulip):

Léo Lanteri Thauvin said:

Removed I-prioritize and added I-needs-decision for T-libs

@Léo Lanteri Thauvin how does the i-needs-decision label work? I mean what are the effects of applying it? Example: are some notifications broadcasted? Is anyone picking them up later or any automatic collection mechanism?

Léo Lanteri Thauvin (Dec 30 2020 at 14:47, on Zulip):

That's up to T-libs :shrug:

apiraino (Dec 30 2020 at 14:48, on Zulip):

ok thanks :-)

Léo Lanteri Thauvin (Dec 30 2020 at 14:48, on Zulip):

I know T-lang uses it

Léo Lanteri Thauvin (Dec 30 2020 at 14:48, on Zulip):

Unsure about T-libs

Léo Lanteri Thauvin (Dec 30 2020 at 14:48, on Zulip):

We might want to ping a T-libs member to know

Léo Lanteri Thauvin (Dec 30 2020 at 14:49, on Zulip):

Nevermind, they have been pinged on the issue already

Léo Lanteri Thauvin (Dec 30 2020 at 14:50, on Zulip):

I'll send a message in #t-libs

Léo Lanteri Thauvin (Dec 30 2020 at 14:56, on Zulip):

https://rust-lang.zulipchat.com/#narrow/stream/219381-t-libs/topic/I-nominated.20and.20I-needs-decision/near/221218029

apiraino (Dec 30 2020 at 15:02, on Zulip):

subscribed :sweat_smile:

Last update: Apr 16 2021 at 23:30UTC