Stream: t-compiler/wg-prioritization/alerts

Topic: I-prioritize #79498 Incorrect "unreachable pattern" warning

triagebot (Nov 28 2020 at 12:21, on Zulip):

@WG-prioritization/alerts issue #79498 has been requested for prioritization.

Procedure

Léo Lanteri Thauvin (Nov 28 2020 at 12:54, on Zulip):

Why is this unsound?

Léo Lanteri Thauvin (Nov 28 2020 at 12:55, on Zulip):

Is it because you can remove the supposedly unreachable pattern and it will compile?

Joshua Nelson (Nov 28 2020 at 12:55, on Zulip):

yes: https://play.rust-lang.org/?version=beta&mode=debug&edition=2018&gist=36e71a8f2d5d7deb36f6c42dcde3c672

Léo Lanteri Thauvin (Nov 28 2020 at 12:56, on Zulip):

Right, it’s #79048

Léo Lanteri Thauvin (Nov 28 2020 at 12:56, on Zulip):

I think we should close as duplicate?

Joshua Nelson (Nov 28 2020 at 12:58, on Zulip):

this is tracking the beta backport I think

Joshua Nelson (Nov 28 2020 at 12:58, on Zulip):

because it's p-critical I would not want to be missing a tracking issue for the backport

Léo Lanteri Thauvin (Nov 28 2020 at 12:59, on Zulip):

Right, though I think it might make more sense to have #79048 tracking the backport :shrug:

Léo Lanteri Thauvin (Nov 28 2020 at 12:59, on Zulip):

Doesn't really matter anyway

Léo Lanteri Thauvin (Nov 28 2020 at 13:00, on Zulip):

If we want to have an issue tracking the backport P-medium seems good

Joshua Nelson (Nov 28 2020 at 13:07, on Zulip):

I still think this is P-critical, if it lands on stable a lot of the ecosystem will suddenly be unsound

Joshua Nelson (Nov 28 2020 at 13:07, on Zulip):

ideally it would never have landed on beta

Léo Lanteri Thauvin (Nov 28 2020 at 13:08, on Zulip):

Right, but this is fixed and there is a backport pending

Joshua Nelson (Nov 28 2020 at 13:09, on Zulip):

that doesn't affect the priority IMO? it's still critical that the backport actually gets applied

Léo Lanteri Thauvin (Nov 28 2020 at 13:09, on Zulip):

IIRC what we have done in the past in those cases is just downgrade the priority to P-medium

Léo Lanteri Thauvin (Nov 28 2020 at 13:09, on Zulip):

I mean this is already under control

Joshua Nelson (Nov 28 2020 at 13:09, on Zulip):

cc @Santiago Pastorino , I know you have strong opinions on this :laughing:

Joshua Nelson (Nov 28 2020 at 13:09, on Zulip):

Léo Lanteri Thauvin said:

I mean this is already under control

right, I understand that, I just think that shouldn't affect the priority

Léo Lanteri Thauvin (Nov 28 2020 at 13:10, on Zulip):

Well I have to admit I haven't been very active recently, so... x)

Santiago Pastorino (Nov 30 2020 at 00:35, on Zulip):

I think we all agree that the most important thing is to track this :)

Santiago Pastorino (Nov 30 2020 at 00:36, on Zulip):

we've been tagging these kind of things as P-critical

Santiago Pastorino (Nov 30 2020 at 00:37, on Zulip):

my opinion differs on what we do but anyway it's not very important, so I'd keep doing what we've been doing, which is tracking these kind of problems with an issue and tag them with P-critical

Santiago Pastorino (Nov 30 2020 at 00:37, on Zulip):

my opinion, in case you guys are interested is that the issues should reflect what happens on master and we should be tracking backports through PRs with their corresponding tags

Santiago Pastorino (Nov 30 2020 at 00:37, on Zulip):

I think that's more consistent and enough

Santiago Pastorino (Nov 30 2020 at 00:38, on Zulip):

issues usually reflect the status of master, think for instance about an open issue that is closed in a PR that has a text that says "Closes #XYZ", that may still be an issue on beta/stable and we don't open new issues for those

Last update: Apr 11 2021 at 18:00UTC