Stream: t-compiler/wg-prioritization/alerts

Topic: I-prioritize #77819 Update crossbeam-channel to avoid UB


triagebot (Oct 11 2020 at 15:19, on Zulip):

@WG-prioritization/alerts issue #77819 has been requested for prioritization.

Procedure

Joshua Nelson (Oct 11 2020 at 15:19, on Zulip):

P-critical IMO - this is unsoundness in the compiler itself

Joshua Nelson (Oct 11 2020 at 15:20, on Zulip):

let me see how long we've been at 0.4.3

Stu (Oct 11 2020 at 15:21, on Zulip):

Do we prioritize PRs too?

Joshua Nelson (Oct 11 2020 at 15:21, on Zulip):

I mean, I don't see a big difference between a PR and an issue

Joshua Nelson (Oct 11 2020 at 15:21, on Zulip):

if there's a PR for an existing issue there's no need to prioritize it

Stu (Oct 11 2020 at 15:22, on Zulip):

Okay. Yeah critical seems right here

lcnr (Oct 11 2020 at 15:25, on Zulip):

Why should this be P-critical? Does rustc use the bounded channel for any types which have a relevant drop impl?

lcnr (Oct 11 2020 at 15:28, on Zulip):

nm, the drop impl isn't actually relevant here. We deallocate the wrong number of elements so we cause UB in the memory allocator

lcnr (Oct 11 2020 at 15:34, on Zulip):

I personally don't believe this alone warrants a point release by itself :thinking:

Joshua Nelson (Oct 11 2020 at 15:37, on Zulip):

UB in the memory allocator seems like it should need a point release to me :/ but anyway wg-prioritization doesn't decide on backports, I just nominated it

DPC (Oct 11 2020 at 15:47, on Zulip):

we normally don't prioritise a pr though, unless it really needs to be pushed

LeSeulArtichaut (Oct 11 2020 at 15:54, on Zulip):

We can nominate it though

LeSeulArtichaut (Oct 11 2020 at 15:54, on Zulip):

I don’t think a priority makes sense on a PR

Joshua Nelson (Oct 11 2020 at 15:55, on Zulip):

if it's beta nominated I don't think it also needs I-nominate

Joshua Nelson (Oct 11 2020 at 15:55, on Zulip):

LeSeulArtichaut said:

I don’t think a priority makes sense on a PR

the reason I think it should be prioritized is there's no issue tracking the unsoundness

Joshua Nelson (Oct 11 2020 at 15:55, on Zulip):

if you want to open an issue and prioritize that instead I'm fine with it

LeSeulArtichaut (Oct 11 2020 at 15:55, on Zulip):

I think I’d rather open an issue and apply the priority there

LeSeulArtichaut (Oct 11 2020 at 15:56, on Zulip):

Depends on the filters we use for P-critical in meetings too

LeSeulArtichaut (Oct 11 2020 at 16:02, on Zulip):

Joshua Nelson said:

if it's beta nominated I don't think it also needs I-nominate

I think these should be kept separate, because the don't call for the same type of discussion. {stable,beta}-nominated specifically asks if the PR should be backported.

I think, if we want to push a PR, I-nominated is the way to go rather than P-* labels, and we can also ping reviewers.

Camelid (Oct 11 2020 at 18:13, on Zulip):

The PR was approved. Should I remove I-prioritize?

Camelid (Oct 11 2020 at 18:13, on Zulip):

Or we can just wait until it's merged

triagebot (Oct 11 2020 at 18:18, on Zulip):

Issue #77819's prioritization request has been removed.

LeSeulArtichaut (Oct 11 2020 at 18:18, on Zulip):

Removed I-prioritize, I don’t think it’s useful anymore

Last update: Apr 10 2021 at 21:00UTC