Stream: t-compiler/wg-prioritization/alerts

Topic: I-prioritize #77585 Panic in Firefox (rusqlite/lru_cache/li…


triagebot (Oct 05 2020 at 18:11, on Zulip):

@WG-prioritization/alerts issue #77585 has been requested for prioritization.

Procedure

LeSeulArtichaut (Oct 05 2020 at 18:12, on Zulip):

Is it only for FreeBSD/amd64?

LeSeulArtichaut (Oct 05 2020 at 18:14, on Zulip):

I think we’d need to bisect this quickly but I’d prefer if we knew if this is a FreeBSD-only bug

lzutao (Oct 06 2020 at 01:06, on Zulip):

was UB code: https://github.com/rust-lang/rust/issues/77585#issuecomment-703826742

apiraino (Oct 07 2020 at 10:35, on Zulip):

By reading the comment thread, it looks like to be consistent with a previous patch? Could be perhaps closed unless other thoughts on the matter.

Joshua Nelson (Oct 07 2020 at 14:21, on Zulip):

yeah IMO this should be closed wontfix

triagebot (Oct 07 2020 at 14:22, on Zulip):

Issue #77585's prioritization request has been removed.

Joshua Nelson (Oct 07 2020 at 14:22, on Zulip):

yup, was closed

Joshua Nelson (Oct 07 2020 at 14:22, on Zulip):

@LeSeulArtichaut can we set up automation to remove I-prioritize if the issue is closed?

LeSeulArtichaut (Oct 07 2020 at 14:23, on Zulip):

We'd need to add a feature to triagebot

LeSeulArtichaut (Oct 07 2020 at 14:23, on Zulip):

Maybe extend autolabel

lzutao (Oct 07 2020 at 14:26, on Zulip):

what if the issue is accidentally closed ? Like one of the members on the phone and mistakenly do that.

Joshua Nelson (Oct 07 2020 at 14:26, on Zulip):

/me has never done that :innocent:

LeSeulArtichaut (Oct 07 2020 at 14:28, on Zulip):

Well, I guess either it's caught or it's not :innocent:

lzutao (Oct 07 2020 at 14:28, on Zulip):

I mean, they mistakenly close and they reopen it immediately.

LeSeulArtichaut (Oct 07 2020 at 14:30, on Zulip):

Then they could notice rustbot has removed the label?

LeSeulArtichaut (Oct 07 2020 at 14:31, on Zulip):

Or maybe one of us could notice

LeSeulArtichaut (Oct 07 2020 at 14:31, on Zulip):

I think at this point we're down to very specific cases

LeSeulArtichaut (Oct 07 2020 at 14:31, on Zulip):

:shrug:

lzutao (Oct 07 2020 at 14:32, on Zulip):

if it is closed by bors, I think it is good to remove the label.

LeSeulArtichaut (Oct 07 2020 at 14:32, on Zulip):

If it's closed as wontfix or duplicate?

lzutao (Oct 07 2020 at 14:33, on Zulip):

We have no automatic way to know that, do we ?
The person (often a org member) marks duplicated could remove the label.

LeSeulArtichaut (Oct 07 2020 at 14:35, on Zulip):

So we basically have a tradeoff between convenience and the rare risk of someone closing the issue by accident

lzutao (Oct 07 2020 at 14:36, on Zulip):

most of the time issues closed by bors

LeSeulArtichaut (Oct 07 2020 at 14:38, on Zulip):

I think we should move this conversation to #t-compiler/wg-prioritization and ask the rest of the WG.

lzutao (Oct 07 2020 at 14:51, on Zulip):

think of it again. It is just I-nominated label, we should get a comment by triagebot in this stream about label removed.
So I agree with removing it automatically.

Mason Stallmo (Oct 07 2020 at 15:02, on Zulip):

Automatic removal in this case seems like a good route. Even if an issue did get closed by accident I think it's likely that whomever closed it would notice the label getting removed and be able to re-add.

Mason Stallmo (Oct 07 2020 at 15:02, on Zulip):

Would adding a delay to triagebot between issue close and label removal mitigate the chance of it happening accidentally?

Last update: Apr 16 2021 at 22:30UTC