Stream: t-compiler/wg-prioritization/alerts

Topic: #81315 thread 'rustc' panicked at 'assertion failed: promot…


triagebot (Jan 23 2021 at 23:59, on Zulip):

@WG-prioritization/alerts issue #81315 has been requested for prioritization.

Procedure

Camelid (Jan 24 2021 at 23:14, on Zulip):

incorrect code with good error -> ICE without an error (so it's really confusing)

Camelid (Jan 24 2021 at 23:14, on Zulip):

regressed in 1.41

Camelid (Jan 24 2021 at 23:15, on Zulip):

I think P-medium or maybe even P-high.

Camelid (Jan 24 2021 at 23:21, on Zulip):

Minimized to:

struct A {
    data: &'static u32,
}

const aa_storage: [A; 32] = [A { data: &1 }; 32];
tm (Jan 24 2021 at 23:22, on Zulip):

It was reported a few more times, and there is a PR with a proposed fix, but lacks a reviewer.

Camelid (Jan 24 2021 at 23:23, on Zulip):

@tm Which PR is that?

Camelid (Jan 24 2021 at 23:24, on Zulip):

This can be repro'd so easily that I think it should be P-high.

tm (Jan 24 2021 at 23:24, on Zulip):

#80404

Camelid (Jan 24 2021 at 23:33, on Zulip):

I reassigned the PR to Oli since ecstatic-morse is no longer doing reviews.

Camelid (Jan 24 2021 at 23:38, on Zulip):

There seem to be at least 4 different issues that are all duplicates. The question is, which ones should we close? I marked #80404 as fixing all of them, so we could just leave them all open and then let them be closed by that PR (or another PR).

These are the issues:

Camelid (Jan 24 2021 at 23:39, on Zulip):

Two of those issues have been prioritized (and the one that this thread is for is of course requested for prioritization); one with P-medium and one with P-high.

Camelid (Jan 24 2021 at 23:39, on Zulip):

What a mess :laughing:

apiraino (Jan 27 2021 at 11:29, on Zulip):

@Camelid I was thinking if we could lower the priority #75682 from P-high to P-medium (since I think we now have a better idea of the issue) and assign a P-medium also to #80371 so they all have the same priority and are all link to the same PR that should solve them.

apiraino (Jan 27 2021 at 11:30, on Zulip):

(I'm not sure if this a usual thing to do with these priority labels)

apiraino (Jan 28 2021 at 11:44, on Zulip):

I'll stick to P-high as suggested.

triagebot (Jan 28 2021 at 11:44, on Zulip):

Issue #81315's prioritization request has been removed.

Last update: Apr 11 2021 at 19:15UTC