Stream: t-compiler/wg-prioritization/alerts

Topic: I-prioritize #79904 regression 1.49: trait bound no longer …


triagebot (Dec 10 2020 at 16:22, on Zulip):

@WG-prioritization/alerts issue #79904 has been requested for prioritization.

Procedure

apiraino (Dec 16 2020 at 16:13, on Zulip):

@WG-prioritization this needs a comment

Santiago Pastorino (Dec 16 2020 at 22:31, on Zulip):

what about this one?

Santiago Pastorino (Dec 16 2020 at 22:31, on Zulip):

I guess we should or either group as fallout of Matthew Jasper traits PR if that's the case

Santiago Pastorino (Dec 16 2020 at 22:31, on Zulip):

but maybe just even go with P-critical?

Santiago Pastorino (Dec 16 2020 at 22:32, on Zulip):

maybe it's a different flavor of the same kind of issue

Santiago Pastorino (Dec 16 2020 at 22:32, on Zulip):

but I guess if we have it open and with I-prioritize I'd go with P-critical

Joshua Nelson (Dec 16 2020 at 22:32, on Zulip):

this was marked as wontfix in the linked issue: https://github.com/rust-lang/rust/issues/77638#issuecomment-708074295

Joshua Nelson (Dec 16 2020 at 22:33, on Zulip):

so I don't think it makes sense to have an independent issue and prioritize that

Joshua Nelson (Dec 16 2020 at 22:33, on Zulip):

we should double check it is the same issue though

Santiago Pastorino (Dec 16 2020 at 22:33, on Zulip):

ok

Santiago Pastorino (Dec 16 2020 at 22:33, on Zulip):

@Joshua Nelson can you add a comment to the issue stating this?

Santiago Pastorino (Dec 16 2020 at 22:33, on Zulip):

given that you have more context

Joshua Nelson (Dec 16 2020 at 22:34, on Zulip):

done

Joshua Nelson (Dec 16 2020 at 22:34, on Zulip):

Santiago Pastorino said:

given that you have more context

well, not me personally :laughing: I just read the linked issue

Santiago Pastorino (Dec 16 2020 at 22:35, on Zulip):

yeah right :)

Ryan Levick (Dec 17 2020 at 11:15, on Zulip):

I added a comment to this issue stating that I don't believe we should close this (and that even closing #77638 seems suspect). Given this impacted several crates in the last crater run, I think the compiler team should at least discuss this.

Joshua Nelson (Dec 17 2020 at 13:33, on Zulip):

I-nominate definitely makes sense to me

Ryan Levick (Dec 17 2020 at 13:38, on Zulip):

Can I add I-nominate using @rustbot label?

Joshua Nelson (Dec 17 2020 at 13:40, on Zulip):

You may not have permissions - can you try? If it doesn't work I'll add it, but having the record is nice when T-compiler pings people in the meeting haha

Ryan Levick (Dec 17 2020 at 13:44, on Zulip):

Doesn't look like I do. Nothing happened :-)

Ryan Levick (Dec 17 2020 at 13:45, on Zulip):

@apiraino thanks for the help!

apiraino (Dec 17 2020 at 13:46, on Zulip):

tried, failed and manually applied the label :laughing:

apiraino (Dec 17 2020 at 13:46, on Zulip):

but that issue I think it belongs to a larger story with some other issues opened in the last days, they're all relevant to crater runs failing

Ryan Levick (Dec 17 2020 at 13:47, on Zulip):

Those other issues all seemed to be closed. The reason I decided to say something is I was worried the entire issue would be lost

apiraino (Dec 17 2020 at 13:48, on Zulip):

I'll try to quickly add something to the agenda about this issue (the meeting starts in ~1h)

apiraino (Dec 17 2020 at 13:50, on Zulip):

the "Nominated Issues" section looks already pretty packed, not sure the team can manage to look at everything (might slip to the next time)

apiraino (Dec 17 2020 at 16:09, on Zulip):

(note to self) issue didnt make it to the meeting, but it's on the radar

Ryan Levick (Dec 17 2020 at 16:32, on Zulip):

This is probably related to #78893 which was mentioned and noted as P-critical

triagebot (Dec 18 2020 at 21:36, on Zulip):

Issue #79904's prioritization request has been removed.

Camelid (Dec 18 2020 at 21:37, on Zulip):

simulacrum removed I-prioritize

Camelid (Dec 18 2020 at 21:38, on Zulip):

simulacrum: Okay, sounds like won't fix and that we should note the fix for #27675 as a compatibility note. Assigning to @XAMPPRocky to do so (and close this issue once you have done so).

Last update: Apr 11 2021 at 18:30UTC