Stream: t-compiler/wg-prioritization/alerts

Topic: #80365 UB inside Weak::into_raw


triagebot (Dec 25 2020 at 19:11, on Zulip):

@WG-prioritization/alerts issue #80365 has been requested for prioritization.

Procedure

Camelid (Dec 25 2020 at 19:12, on Zulip):

I don't think this is actually UB, but Miri thinks it is, so figured it was worth prioritizing.

Camelid (Dec 25 2020 at 19:12, on Zulip):

(aka, making sure other people take a look at it)

Camelid (Dec 26 2020 at 17:57, on Zulip):

Actually, based on what people said on the issue, it seems Miri is correct in thinking it's UB: somewhere internally in Weak::as_ptr (which is called by Weak::into_raw), it's creating a reference out of an invalid raw pointer.

Camelid (Dec 26 2020 at 17:57, on Zulip):

So this is unsound.

apiraino (Dec 30 2020 at 14:39, on Zulip):

hum ... we didnt assign a priority label but now there is already a PR for this issue. I would simply remove remove the I-prioritize label. @DPC would it make sense to assign a priority now?

apiraino (Dec 30 2020 at 14:40, on Zulip):

I mean: is it useful if it goes into this weeks' agenda?

Camelid (Dec 31 2020 at 01:16, on Zulip):

I think it's still useful to assign a priority; if the PR gets stuck it will help push it along and stop it from being lost.

Camelid (Dec 31 2020 at 01:16, on Zulip):

Seems like P-high to me.

Camelid (Dec 31 2020 at 01:33, on Zulip):

Ah, didn't realize the PR was merged.

Camelid (Dec 31 2020 at 01:33, on Zulip):

But still nice to assign a "post-mortem" priority as you say :)

Last update: Apr 11 2021 at 18:30UTC