Stream: t-compiler/wg-prioritization/alerts

Topic: I-prioritize #78474 `unconditional_recursion` lint doesn't …


triagebot (Oct 28 2020 at 11:28, on Zulip):

@WG-prioritization/alerts issue #78474 has been requested for prioritization.

Procedure

Hameer Abbasi (Oct 28 2020 at 11:29, on Zulip):

P-medium, maybe P-high, missing warning on obvious infinite recursion, regression from stable to stable.

apiraino (Oct 28 2020 at 11:31, on Zulip):

I'd say P-medium, too

James Gill (Oct 28 2020 at 11:42, on Zulip):

Just saw that @Jonas Schievink comment saying it was expected behaviour. In this case I assume if it would still be correct to fix, as it was intentional would P-low be more appropriate?

lcnr (Oct 28 2020 at 12:29, on Zulip):

I think P-medium is fine. If this behavior is intentional it would make more sense to just close this, wouldn't it :thinking:

DPC (Oct 28 2020 at 15:41, on Zulip):

just want to say recursion may not always be obvious (it in this case because it is a simplified example)

Joshua Nelson (Oct 28 2020 at 16:17, on Zulip):

The linked issue confuses me :/ I'm not sure why it was changed

lcnr (Oct 28 2020 at 16:19, on Zulip):

f() can panic, so foo() might now necessarily recurse here

fn foo() {
    f();
    foo();
}
lcnr (Oct 28 2020 at 16:19, on Zulip):

which we now consider when linting unconditional_recursion

lcnr (Oct 28 2020 at 16:20, on Zulip):

but imo should not

Joshua Nelson (Oct 28 2020 at 16:42, on Zulip):

right, I understand why it's possible, I just think the lint should still fire

Joshua Nelson (Oct 28 2020 at 16:43, on Zulip):

the example didn't seem very convincing of why you'd want to want to ignore that case

Santiago Pastorino (Oct 28 2020 at 19:06, on Zulip):

I guess I'd go with P-medium for this one

Santiago Pastorino (Oct 28 2020 at 19:07, on Zulip):

given that some people already said P-medium tagging it like so but feel free to comment if you want to change prio

triagebot (Oct 28 2020 at 19:08, on Zulip):

Issue #78474's prioritization request has been removed.

Last update: Apr 11 2021 at 19:30UTC