Stream: t-compiler/wg-prioritization/alerts

Topic: I-prioritize #79503 Clap derive expansion no longer works o…


triagebot (Nov 28 2020 at 14:02, on Zulip):

@WG-prioritization/alerts issue #79503 has been requested for prioritization.

Procedure

Léo Lanteri Thauvin (Nov 28 2020 at 14:53, on Zulip):

@Joshua Nelson This is a stable regression, right?

Joshua Nelson (Nov 28 2020 at 14:53, on Zulip):

I think so? It's hard to tell without replication steps

Joshua Nelson (Nov 28 2020 at 14:53, on Zulip):

@pksunkara did you ever replicate the issue locally?

Léo Lanteri Thauvin (Nov 28 2020 at 14:54, on Zulip):

It most recently worked on: Successfully compiles and runs on 1.46.0

Joshua Nelson (Nov 28 2020 at 14:55, on Zulip):

@Léo Lanteri Thauvin right, yes, but that's from the CI train

Joshua Nelson (Nov 28 2020 at 14:55, on Zulip):

so it's possible there's something different going on in their CI workflow for 1.46 and 1.48

pksunkara (Nov 28 2020 at 14:56, on Zulip):

It failed on EC2 using ssh

pksunkara (Nov 28 2020 at 14:56, on Zulip):

not my mac locally

Joshua Nelson (Nov 28 2020 at 14:57, on Zulip):

hmm, so it might be linux only? weird for it to be platform specific in name resolution

pksunkara (Nov 28 2020 at 14:57, on Zulip):

No, mac on CI fails

pksunkara (Nov 28 2020 at 14:57, on Zulip):

I linked the relevant mac CI run in my second comment

pksunkara (Nov 28 2020 at 15:00, on Zulip):

The replication step is basically the following command in clap repo: cargo test -p clap_derive --test nested

Léo Lanteri Thauvin (Nov 28 2020 at 15:00, on Zulip):

Sorry for the dumb question, what is EC2?

pksunkara (Nov 28 2020 at 15:00, on Zulip):

AWS EC2 instance

pksunkara (Nov 28 2020 at 15:00, on Zulip):

I used it to test linux because my local was passing

pksunkara (Nov 28 2020 at 15:01, on Zulip):

On EC2 SSH, cargo +1.46.0 test -p clap_derive --test nested succeeds but cargo +stable test -p clap_derive --test nested fails

Joshua Nelson (Nov 28 2020 at 15:01, on Zulip):

testing locally

Léo Lanteri Thauvin (Nov 28 2020 at 15:01, on Zulip):

Did you check 1.47.0 too?

Joshua Nelson (Nov 28 2020 at 15:02, on Zulip):

it fails for me locally

pksunkara (Nov 28 2020 at 15:02, on Zulip):

@Joshua Nelson What's the os?

Joshua Nelson (Nov 28 2020 at 15:02, on Zulip):

linux, ubuntu 20.04

Joshua Nelson (Nov 28 2020 at 15:02, on Zulip):

trying 1.47 now

pksunkara (Nov 28 2020 at 15:04, on Zulip):

It works on 1.47 on linux

Joshua Nelson (Nov 28 2020 at 15:04, on Zulip):

yup, works for me on 1.47

pksunkara (Nov 28 2020 at 15:06, on Zulip):

Might be related note: The original error was even weirder. https://github.com/clap-rs/clap/runs/1465456535#step:6:196

pksunkara (Nov 28 2020 at 15:06, on Zulip):

error[E0423]: expected value, found macro `matches`

Léo Lanteri Thauvin (Nov 28 2020 at 15:06, on Zulip):

I think cargo-bisect-rustc would allow us to bisect the culprit commit

pksunkara (Nov 28 2020 at 15:06, on Zulip):

And then I changed the variable name from matches to arg_matches in this commit. Then the error became: error[E0425]: cannot find value `arg_matches` in this scope

pksunkara (Nov 28 2020 at 15:07, on Zulip):

How do I run it?

Léo Lanteri Thauvin (Nov 28 2020 at 15:08, on Zulip):

I wonder if it can run tests, but I guess so

Joshua Nelson (Nov 28 2020 at 15:08, on Zulip):

yeah, I'm running it now

Joshua Nelson (Nov 28 2020 at 15:08, on Zulip):

wow my poor battery :laughing: time to plug in my charger

Joshua Nelson (Nov 28 2020 at 15:08, on Zulip):

@pksunkara https://github.com/rust-lang/cargo-bisect-rustc/blob/master/TUTORIAL.md

Joshua Nelson (Nov 28 2020 at 15:20, on Zulip):

ugh I'm having trouble getting it to work, if someone else wants to try feel free

Joshua Nelson (Nov 28 2020 at 15:21, on Zulip):

oh I forgot to add ./ in front of the script :face_palm:

Joshua Nelson (Nov 28 2020 at 15:21, on Zulip):

wow these error messages are unhelpful

Léo Lanteri Thauvin (Nov 28 2020 at 15:22, on Zulip):

Joshua Nelson said:

wow these error messages are unhelpful

From cargo-bisect-rustc?

Joshua Nelson (Nov 28 2020 at 15:22, on Zulip):

yeah, all it said was ERROR: the start of the range (nightly-2020-07-11) must not reproduce the regression

Léo Lanteri Thauvin (Nov 28 2020 at 15:24, on Zulip):

Should be failry easy to fix I guess

Léo Lanteri Thauvin (Nov 28 2020 at 15:35, on Zulip):

As I expected, cargo-bisect-rustc doesn't differenciate between an error in the shell script and a "command not found" error

pksunkara (Nov 28 2020 at 15:43, on Zulip):

How do I run this single test using cargo-bisect-rustc?

Joshua Nelson (Nov 28 2020 at 15:50, on Zulip):

I found it, one sec

Joshua Nelson (Nov 28 2020 at 15:50, on Zulip):

https://github.com/rust-lang/rust/issues/79503#issuecomment-735247581

Léo Lanteri Thauvin (Nov 28 2020 at 15:50, on Zulip):

Isn't it possible to run cargo-bisect-rustc -- test -p clap_derive --test nested?

Joshua Nelson (Nov 28 2020 at 15:51, on Zulip):

is it?

Léo Lanteri Thauvin (Nov 28 2020 at 15:52, on Zulip):

Well I don't know for sure, but I thought it would work

Joshua Nelson (Nov 28 2020 at 15:52, on Zulip):

huh, look at that, it does :)

Léo Lanteri Thauvin (Nov 28 2020 at 15:54, on Zulip):

My understanding is that it can run any cargo command

Léo Lanteri Thauvin (Nov 28 2020 at 15:54, on Zulip):

But I never tried with cargo test, only cargo check to avoid a full cargo build when possible

Last update: Apr 10 2021 at 21:15UTC