@WG-prioritization/alerts issue #74657 has been requested for prioritization.
this went unnoticed, taking a look at it right now
and is the last one lacking prioritization :)
P-high maybe :thinking:
yeah I was wondering the same
I think we need a mvce here though
but I'm right now thinking loudly, why not
I'm trying to think, what kind of peculiarity this have that is uncommon
my first reaction was, if Firefox doesn't compile then
RUSTFLAGS="-Clinker-plugin-lto=LLVMgold.so" and only on some target apparently
yeah saw the flags, but didn't realize about the targets
so most firefox targets still work here
at least from what I can tell it would be quite bad if this weren't the case
I guess this was fixed on Firefox’s side, see the linkrf bugzilla issue
yeah they worked around the issue
this even hit archlinux firefox builds
or am I wrong?
wasn't that fix for a build perf regression?
to be honest unsure
too long didn't properly read :)
@lcnr thoughts about what to do here?
ping ICE breakers and hope they are able to somehow minimize this :sweat_smile:
This seems like an annoying bug to track down
hehe, but should we start with
A comment in the that thread mentions that some args to
rustc changed with that version
Since the original problem is that cargo >= 1.45 passes extra flags (-C embed-bitcode=no) to rustc that are incompatible with -Clto, and while it knows to adjust based on the lto setting in the build profile (which CARGO_PROFILE_RELEASE_LTO overrides the default of), cargo ignores flags passed via cargo rustc -- ... when making those adjustments. So, we need to override with -C embed-bitcode=yes on our own at the same time we pass -Clto. But doing that through cargo rustc -- ... is not enough because all the dependencies of the crate built with -Clto need to be built with -C embed-bitcode=yes. So we need to override with RUSTFLAGS, which will affect all the dependencies. But we also need to do this consistently across all crates, not only the dependencies of crates built with -Clto, otherwise we'd still end up building crates twice (once with and once without the override).
maybe :/ from what I can see the issue isn't really
P-critical, but I also don't know what causes it
I guess I'd go with
P-high until someone figures out something that gives more light
we should also ping cleanup here I think
if someone wants to spend a few hours building firefox
right, I've pinged them
P-highfor now then
IIRC this was also reproducible with rusqlite?
hmm, yeah. Looks like the issue was with
so maybe it's not "if someone wants to spend a few hours building firefox" bad
We already have the bisection though
but no mvce, if I didn't miss something here
We should ping Alex Crichton I think
hmm, yeah... might help
You do it or shall I?
feel free, I should actually be working for uni rn :sweat_smile: