Stream: t-compiler/wg-prioritization/alerts

Topic: I-prioritize #78724 Broken links in rustdoc search results


triagebot (Nov 04 2020 at 21:37, on Zulip):

@WG-prioritization/alerts issue #78724 has been requested for prioritization.

Procedure

Camelid (Nov 04 2020 at 21:38, on Zulip):

I think this is P-medium or P-high.

Camelid (Nov 04 2020 at 21:38, on Zulip):

It's possible that it's specific to something in the compiler, but there's a good chance this affects other crates as well

Joshua Nelson (Nov 04 2020 at 21:39, on Zulip):

I think we should get an MCVE before prioritizing

Camelid (Nov 04 2020 at 21:40, on Zulip):

Well should we prioritize to get more eyeballs on it?

Joshua Nelson (Nov 04 2020 at 21:40, on Zulip):

who would look at it? rustdoc is me and guillaume

Joshua Nelson (Nov 04 2020 at 21:40, on Zulip):

I can ping guillaume if you want

Camelid (Nov 04 2020 at 21:41, on Zulip):

People looking through issues who want to help out

Camelid (Nov 04 2020 at 21:41, on Zulip):

But yeah, it might make sense to ping T-rustdoc

Joshua Nelson (Nov 04 2020 at 21:42, on Zulip):

I don't thing we should ping for every issue

Camelid (Nov 04 2020 at 21:46, on Zulip):

Well, you suggested it :)

Joshua Nelson (Nov 04 2020 at 21:46, on Zulip):

touche

apiraino (Nov 05 2020 at 14:18, on Zulip):

I don't remember if we said to remove I-prioritize on T-rustdoc issues :thinking:

DPC (Nov 06 2020 at 00:57, on Zulip):

yes other teams don't require prioritisation

Joshua Nelson (Nov 06 2020 at 00:58, on Zulip):

we agreed to add p-high and ping the team

Joshua Nelson (Nov 06 2020 at 00:58, on Zulip):

should we write it down somewhere?

Joshua Nelson (Nov 06 2020 at 00:58, on Zulip):

https://rust-lang.zulipchat.com/#narrow/stream/227806-t-compiler.2Fwg-prioritization/topic/triagebot.20I-prioritize/near/209649094

Joshua Nelson (Nov 06 2020 at 00:59, on Zulip):

I would like this to be institutional knowledge and not require me to keep telling people 'yes please ping rustdoc or they won't see it'

Camelid (Nov 06 2020 at 01:15, on Zulip):

We could have some kind of triagebot thing that is triggered by the labels T-rustdoc combined with I-prioritize and removes I-prioritize and adds P-high, but we'd have to change triagebot in order to ping the team.

Camelid (Nov 06 2020 at 01:15, on Zulip):

We could record it in Forge, but I doubt people will look there, which defeats the purpose. We could have an Inside Rust blog post too, but not sure how effective or worthwhile that would be.

Camelid (Nov 06 2020 at 01:16, on Zulip):

@Joshua Nelson Do you want me to add P-high and ping? Not sure if this is a regression though

Joshua Nelson (Nov 06 2020 at 01:21, on Zulip):

oh right

Joshua Nelson (Nov 06 2020 at 01:21, on Zulip):

I think we just shouldn't prioritize it then tbh

Joshua Nelson (Nov 06 2020 at 01:21, on Zulip):

since it's not a regession

Camelid (Nov 06 2020 at 01:23, on Zulip):

Should we just do P-medium or should we not prioritize it at all?

DPC (Nov 06 2020 at 01:32, on Zulip):

i'd say i-nominated and pinging the team is a better option (But that's me)

Camelid (Nov 06 2020 at 01:55, on Zulip):

I'm not sure if rustdoc uses I-nominated though

Joshua Nelson (Nov 06 2020 at 02:04, on Zulip):

like I said last time, nominated is useless because we don't have meetings

Joshua Nelson (Nov 06 2020 at 02:05, on Zulip):

like these issues that have been nominated for years and I never saw until I was scrolling through issues yesterday https://github.com/rust-lang/rust/issues?q=is%3Aissue+is%3Aopen+label%3AT-rustdoc+label%3AI-nominated

Joshua Nelson (Nov 06 2020 at 02:08, on Zulip):

(because I just removed the label: https://github.com/rust-lang/rust/issues/53143 and https://github.com/rust-lang/rust/issues/49514)

DPC (Nov 06 2020 at 02:35, on Zulip):

yeh i know :stuck_out_tongue: just saying nominated doesn't have to imply that there is a meeting to triage them, it is the similar to "waiting on team" where the wait can be infinite (it just makes it consistent with other teams)

Joshua Nelson (Nov 06 2020 at 04:13, on Zulip):

I guess I don't see the point :shrug:

Joshua Nelson (Nov 06 2020 at 04:14, on Zulip):

if rustdoc doesn't use it, why add the label?

apiraino (Nov 06 2020 at 09:35, on Zulip):

fair enough. I would then simply leave everything as it is, just let's share the "tribal knowledge" to remember to ping either Joshua Nelson of GuillaumeGomez (don't know if he follows zulip) in case something slips through the cracks.
It's not perfect but I'd rather avoid adding further burden on their shoulders about micro-managing things :)

DPC (Nov 06 2020 at 15:14, on Zulip):

Joshua Nelson said:

if rustdoc doesn't use it, why add the label?

because then we can differentiate between that and other rustdoc issues, p-high could do the same but then members here have to remember what to do for each team

Joshua Nelson (Nov 06 2020 at 15:14, on Zulip):

but then members here have to remember what to do for each team

wouldn't they have to do that anyway with I-nominate?

apiraino (Nov 18 2020 at 12:19, on Zulip):

@Joshua Nelson would it help calling the ICE team to help with your mcve requst?

Joshua Nelson (Nov 18 2020 at 13:28, on Zulip):

Sure, that would be helpful :) right now the issue is not really actionable unless I first put in a lot of time to see what's actually going wrong

triagebot (Dec 11 2020 at 22:29, on Zulip):

Issue #78724's prioritization request has been removed.

Camelid (Dec 11 2020 at 22:29, on Zulip):

Prioritized as P-medium for now: it seems people are only running into this in compiler docs and it's not catastrophic.

Last update: Apr 11 2021 at 17:45UTC