Stream: t-compiler/meetings

Topic: [weekly meeting] 2020-08-27 #54818


Santiago Pastorino (Aug 26 2020 at 20:52, on Zulip):

Hi @T-compiler/meeting; the triage meeting will happen tomorrow at

Santiago Pastorino (Aug 26 2020 at 20:53, on Zulip):

The @WG-prioritization have done pre-triage in #t-compiler/wg-prioritization/alerts

Santiago Pastorino (Aug 26 2020 at 20:53, on Zulip):

@WG-prioritization have prepared the meeting agenda

simulacrum (Aug 26 2020 at 20:53, on Zulip):

Should probably use the new Zulip thing btw,

Santiago Pastorino (Aug 26 2020 at 20:54, on Zulip):

We will have checkins from @WG-diagnostics and @WG-async-foundations

Santiago Pastorino (Aug 26 2020 at 20:59, on Zulip):

@Esteban Küber do you have something you want to share about @WG-diagnostics?

Santiago Pastorino (Aug 26 2020 at 20:59, on Zulip):

@nikomatsakis and/or @tmandry do you have something you want to share about @WG-async-foundations?

Santiago Pastorino (Aug 26 2020 at 21:01, on Zulip):

as always, feel free to nominate something you want to discuss during tomorrow's meeting

Esteban Küber (Aug 27 2020 at 05:54, on Zulip):

@Santiago Pastorino can't edit the hackmd, but for diagnostics:

Changes requiring to be signed off (or closed)

Feeling fancy and wanting to highlight still unmerged change that I'm proud of:

apiraino (Aug 27 2020 at 08:22, on Zulip):

^ added to the agenda :thumbs_up:

oli (Aug 27 2020 at 11:34, on Zulip):

I also added

Kind of major change announcement:

to the diagnostics section of the agenda

Wesley Wiser (Aug 27 2020 at 13:15, on Zulip):

@Esteban Küber I added you to the hackmd team so you can edit next time.

Santiago Pastorino (Aug 27 2020 at 13:19, on Zulip):

Hi @T-compiler/meeting, triage meeting will be starting in 42 minutes, at

Santiago Pastorino (Aug 27 2020 at 13:19, on Zulip):

Check out the meeting agenda

Santiago Pastorino (Aug 27 2020 at 13:19, on Zulip):

I'm still reviewing some last details of it

Wesley Wiser (Aug 27 2020 at 14:04, on Zulip):

:wave:

Santiago Pastorino (Aug 27 2020 at 14:05, on Zulip):

:wave:

pnkfelix (Aug 27 2020 at 14:05, on Zulip):

oh :wave:

pnkfelix (Aug 27 2020 at 14:06, on Zulip):

sorry had to take care of a few things and time got away from me

pnkfelix (Aug 27 2020 at 14:06, on Zulip):

Hi @T-compiler/meeting! Add a :wave: emoji to show you're here :)

pnkfelix (Aug 27 2020 at 14:06, on Zulip):

(we'll count the ones above too)

pnkfelix (Aug 27 2020 at 14:06, on Zulip):

we will start off with 5 minutes for ...

Announcements

pnkfelix (Aug 27 2020 at 14:06, on Zulip):
pnkfelix (Aug 27 2020 at 14:07, on Zulip):
pnkfelix (Aug 27 2020 at 14:07, on Zulip):
pnkfelix (Aug 27 2020 at 14:07, on Zulip):
pnkfelix (Aug 27 2020 at 14:07, on Zulip):
pnkfelix (Aug 27 2020 at 14:08, on Zulip):
pnkfelix (Aug 27 2020 at 14:08, on Zulip):
pnkfelix (Aug 27 2020 at 14:08, on Zulip):
pnkfelix (Aug 27 2020 at 14:08, on Zulip):
pnkfelix (Aug 27 2020 at 14:08, on Zulip):

WG checkins

pnkfelix (Aug 27 2020 at 14:09, on Zulip):

@WG-diagnostics checkin by @Esteban Küber

pnkfelix (Aug 27 2020 at 14:09, on Zulip):
pnkfelix (Aug 27 2020 at 14:10, on Zulip):

Changes requiring to be signed off (or closed)

Feeling fancy and wanting to highlight still unmerged change that I'm proud of:

pnkfelix (Aug 27 2020 at 14:10, on Zulip):

Kind of major change announcement:

pnkfelix (Aug 27 2020 at 14:10, on Zulip):

@WG-async-foundations checkin by @nikomatsakis and @tmandry

Work on the compiler has, I believe, been slow lately. There has been progress towards an RFC for the Stream trait and experiments for a lint around values that should be live over yields. -- nikomatsakis, who may be a bit behind

pnkfelix (Aug 27 2020 at 14:10, on Zulip):

Beta-nominations

T-compiler

pnkfelix (Aug 27 2020 at 14:11, on Zulip):
simulacrum (Aug 27 2020 at 14:11, on Zulip):

What do we mean by "already in stable"? Did this get backported into stable?

pnkfelix (Aug 27 2020 at 14:11, on Zulip):

I was just going to ask that

Esteban Küber (Aug 27 2020 at 14:12, on Zulip):

The bad diagnostic is visible in stable

pnkfelix (Aug 27 2020 at 14:12, on Zulip):

oh oh

Santiago Pastorino (Aug 27 2020 at 14:12, on Zulip):

was the beta cut already I guess?

simulacrum (Aug 27 2020 at 14:12, on Zulip):

beta was cut tuesday

Esteban Küber (Aug 27 2020 at 14:12, on Zulip):

Also, I think it will be cut in this beta

Esteban Küber (Aug 27 2020 at 14:12, on Zulip):

So.the point is moot

Esteban Küber (Aug 27 2020 at 14:12, on Zulip):

:blush:

pnkfelix (Aug 27 2020 at 14:12, on Zulip):

(Also: A bug already in stable is usually a justification for not nominating or at least not beta backporting...)

Santiago Pastorino (Aug 27 2020 at 14:12, on Zulip):

backporting now is almost like if this was merged since a couple of days ago :)

simulacrum (Aug 27 2020 at 14:13, on Zulip):

The diagnostic does look pretty bad:

error[E0261]: use of undeclared lifetime name `'somelifetime`
 --> src/lib.rs:3:31
  |
3 |     async fn buggy(&self) -> &'somelifetime str {
  |                               ^^^^^^^^^^^^^ undeclared lifetime
  |
help: consider introducing lifetime `'somelifetime` here
  |
2 | impl<'somelifetime> Bug {
  |     ^^^^^^^^^^^^^^^
help: consider introducing lifetime `'somelifetime` here
  |
3 |     async fn buggy('somelifetime, &self) -> &'somelifetime str {
  |                    ^^^^^^^^^^^^^^
simulacrum (Aug 27 2020 at 14:14, on Zulip):

eh, I'm ambivalent

Wesley Wiser (Aug 27 2020 at 14:14, on Zulip):

So, to clarify, as of today, the bad diagnostic is happening in beta and this PR resolves that?

Esteban Küber (Aug 27 2020 at 14:15, on Zulip):

I think this is now included in beta, it was cut immediately after

Esteban Küber (Aug 27 2020 at 14:15, on Zulip):

Otherwise yes

pnkfelix (Aug 27 2020 at 14:15, on Zulip):

By "this"

pnkfelix (Aug 27 2020 at 14:15, on Zulip):

you cannot mean the PR

pnkfelix (Aug 27 2020 at 14:15, on Zulip):

since that hasn't landed on nightly yet

pnkfelix (Aug 27 2020 at 14:16, on Zulip):

right?

Esteban Küber (Aug 27 2020 at 14:16, on Zulip):

Sorry my mistake (half asleep)

Esteban Küber (Aug 27 2020 at 14:16, on Zulip):

Correct

pnkfelix (Aug 27 2020 at 14:16, on Zulip):

Okay.

nikomatsakis (Aug 27 2020 at 14:16, on Zulip):

the fix looks quite small in diff, anyway

Esteban Küber (Aug 27 2020 at 14:16, on Zulip):

This error is still in beta, this pr would fix it

Esteban Küber (Aug 27 2020 at 14:16, on Zulip):

(misread open date with merge date)

Wesley Wiser (Aug 27 2020 at 14:16, on Zulip):

Got it, thanks!

pnkfelix (Aug 27 2020 at 14:16, on Zulip):

Normally I'd let P-low things ride the trains

pnkfelix (Aug 27 2020 at 14:17, on Zulip):

but this looks so incredibly low risk that I'm willing to beta-approve

pnkfelix (Aug 27 2020 at 14:17, on Zulip):

anyone object?

pnkfelix (Aug 27 2020 at 14:17, on Zulip):

okay, beta-approved

nagisa (Aug 27 2020 at 14:17, on Zulip):

:ditto: I think there's some value in relying on the status quo of the process. (This was in response in P-low)

Santiago Pastorino (Aug 27 2020 at 14:18, on Zulip):

question, is it really P-low this issue?

pnkfelix (Aug 27 2020 at 14:18, on Zulip):

/me 's mind is circling around "the status quo of the process"

pnkfelix (Aug 27 2020 at 14:18, on Zulip):

I think the issue is P-low in terms of prioritizing a fix

pnkfelix (Aug 27 2020 at 14:19, on Zulip):

but now that a fix is available, and seems trivial, I am inclined to beta-approve. At same time, it hasn't yet landed on nightly

nagisa (Aug 27 2020 at 14:19, on Zulip):

we have 4 :back: so I think we have a decision.

pnkfelix (Aug 27 2020 at 14:19, on Zulip):

anyway @nagisa should I actually interpret your response as an objection ?

pnkfelix (Aug 27 2020 at 14:20, on Zulip):

okay

pnkfelix (Aug 27 2020 at 14:20, on Zulip):
nagisa (Aug 27 2020 at 14:21, on Zulip):

I’m of an opinion that we should backport a lint level downgrade instead.

simulacrum (Aug 27 2020 at 14:21, on Zulip):

I am generally :thumbs_up: on that as well.

pnkfelix (Aug 27 2020 at 14:21, on Zulip):

indeed, I think @simulacrum proposed that in the linked "backport reasons" ?

nikomatsakis (Aug 27 2020 at 14:21, on Zulip):

that sounds prudent to me

nagisa (Aug 27 2020 at 14:22, on Zulip):

Note: similarly this hasn’t even landed to nightly yet either.

pnkfelix (Aug 27 2020 at 14:22, on Zulip):

yep

pnkfelix (Aug 27 2020 at 14:22, on Zulip):

okay lets just re-commit the previous beta-backport that allowed this lint by default then.

pnkfelix (Aug 27 2020 at 14:22, on Zulip):

if you object, say something (interrupt meeting if necessary)

pnkfelix (Aug 27 2020 at 14:23, on Zulip):

(in case someone else is posting the comments on the PR's: I'd call that a "declining to backport" and then link to the previous beta-comit that allowed the lint by default)

pnkfelix (Aug 27 2020 at 14:23, on Zulip):

libs-impl

T-rustdoc

pnkfelix (Aug 27 2020 at 14:23, on Zulip):

Stable-nominations

T-compiler

libs-impl

T-rustdoc

pnkfelix (Aug 27 2020 at 14:23, on Zulip):

PRs S-waiting-on-team

T-compiler

libs-impl

pnkfelix (Aug 27 2020 at 14:23, on Zulip):

Issues of Note

Short Summary

pnkfelix (Aug 27 2020 at 14:24, on Zulip):

wow 0 P-critical issues

pnkfelix (Aug 27 2020 at 14:24, on Zulip):

does anyone know how many weeks its been since we've had a meeting with 0 P-critical issues?

pnkfelix (Aug 27 2020 at 14:24, on Zulip):

this is so exciting I'm going to paste the rest of the template

pnkfelix (Aug 27 2020 at 14:24, on Zulip):

P-critical

T-compiler

libs-impl

T-rustdoc

pnkfelix (Aug 27 2020 at 14:25, on Zulip):

Unassigned P-high regressions

Beta regressions

pnkfelix (Aug 27 2020 at 14:25, on Zulip):
pnkfelix (Aug 27 2020 at 14:26, on Zulip):

(to be clear: The theory we posited last week was that this bug could be thread-scheduler dependent, right?)

pnkfelix (Aug 27 2020 at 14:26, on Zulip):

(and that that is why we may only see it on QEMU; but I think it would be a mistake to then conclude that you couldn't see it on any real hardware in the wild...)

nikomatsakis (Aug 27 2020 at 14:26, on Zulip):

or something to do w/ panic machinery

pnkfelix (Aug 27 2020 at 14:26, on Zulip):

oh right

nikomatsakis (Aug 27 2020 at 14:27, on Zulip):

so I believe the panic results from lock poisoning

nikomatsakis (Aug 27 2020 at 14:27, on Zulip):

but I'm not convinced it is scheduler related

nikomatsakis (Aug 27 2020 at 14:27, on Zulip):

it seems more likely that an unexpected panic is occurring for some reason, or maybe catch_unwind is not working, idk

nikomatsakis (Aug 27 2020 at 14:28, on Zulip):

i.e., and hence the lock is becoming poisoned

pnkfelix (Aug 27 2020 at 14:28, on Zulip):

okay. Worth further investigation

pnkfelix (Aug 27 2020 at 14:28, on Zulip):

but its also pretty certain to become a stable-to-stable regression at this point

pnkfelix (Aug 27 2020 at 14:29, on Zulip):

(and I think when it does turn into a stable-to-stable regression, that will imply that we won't visit it every week in this meeting, even if it remains P-high, which I think it probably should.)

pnkfelix (Aug 27 2020 at 14:30, on Zulip):

it also might be something that we should investigate more before making an ARM Tier1 architecture, right?

nikomatsakis (Aug 27 2020 at 14:30, on Zulip):

that sounds reasonable

pnkfelix (Aug 27 2020 at 14:30, on Zulip):

/me looks for issue describing that tier 1 addition

Wesley Wiser (Aug 27 2020 at 14:31, on Zulip):

You mean https://github.com/rust-lang/rfcs/pull/2959?

Wesley Wiser (Aug 27 2020 at 14:31, on Zulip):

Or https://github.com/rust-lang/rust/pull/75914? Er, that's tier-2.

pnkfelix (Aug 27 2020 at 14:31, on Zulip):

that's one of them, thank you

pnkfelix (Aug 27 2020 at 14:31, on Zulip):

and another

pnkfelix (Aug 27 2020 at 14:32, on Zulip):

and of course https://github.com/rust-lang/rust/issues/73908

pnkfelix (Aug 27 2020 at 14:32, on Zulip):

(i.e. Linux, Windows, and Mac ARM, respectively)

nagisa (Aug 27 2020 at 14:33, on Zulip):

I notice that we haven’t pinged our ARM experts.

nikomatsakis (Aug 27 2020 at 14:33, on Zulip):

I thought we did so

nagisa (Aug 27 2020 at 14:33, on Zulip):

/me looks again

simulacrum (Aug 27 2020 at 14:33, on Zulip):

We did, and they tested on hardware and said it didn't fail

nikomatsakis (Aug 27 2020 at 14:33, on Zulip):

pretty sure I also pestered @Robin Randhawa in a previous meeting as well :)

nagisa (Aug 27 2020 at 14:34, on Zulip):

ah we did, I missed it.

pnkfelix (Aug 27 2020 at 14:34, on Zulip):

clearly we need a QEMU ping group. :wink:

nikomatsakis (Aug 27 2020 at 14:34, on Zulip):

heh I was just thinking that :P

nagisa (Aug 27 2020 at 14:34, on Zulip):

AFAIK cross uses binfmt support, which I found wonky many times in the past.

nagisa (Aug 27 2020 at 14:35, on Zulip):

it is not really a VM and more like an… interpreter.

pnkfelix (Aug 27 2020 at 14:35, on Zulip):

you know, an AMD ping group might actually makes sense, since hardware is not as easy to "just grab" as a QEMU binary...

pnkfelix (Aug 27 2020 at 14:35, on Zulip):

but now I'm super-digressing

nagisa (Aug 27 2020 at 14:35, on Zulip):

if we can confirm this to be the case I’d be inclined to call this not-a-bug in rust in the first place.

pnkfelix (Aug 27 2020 at 14:36, on Zulip):

interesting

nikomatsakis (Aug 27 2020 at 14:37, on Zulip):

(I remain kind of unclear on how much to prioritize a QEMU-only bug)

nikomatsakis (Aug 27 2020 at 14:37, on Zulip):

I think it'd be "ok" to file it as medium or low and wait to see if we see similar symptoms crop up in real hardware ever

pnkfelix (Aug 27 2020 at 14:38, on Zulip):

I would add one note to that suggestion: In general, if we were to take that tack ...

pnkfelix (Aug 27 2020 at 14:38, on Zulip):

... I would want us to add the code illustrating the bug to our test suite

pnkfelix (Aug 27 2020 at 14:38, on Zulip):

to sort of force people to find out about where the problem occurs

pnkfelix (Aug 27 2020 at 14:38, on Zulip):

However, in this particular case

pnkfelix (Aug 27 2020 at 14:38, on Zulip):

I think the code is already in our test suite

pnkfelix (Aug 27 2020 at 14:39, on Zulip):

that is, it looks like a dirt-simple check of #[should_panic] support

pnkfelix (Aug 27 2020 at 14:39, on Zulip):

so yeah, shall we lower priority of this to P-medium then?

pnkfelix (Aug 27 2020 at 14:40, on Zulip):

(there's also the detail that we may need QEMU support to work in practice for some of our volunteers to be able to double-check that their code works for those targets...)

pnkfelix (Aug 27 2020 at 14:41, on Zulip):

but that's a broader question that gets into "what priority do we give QEMU support", and I don't want to try to answer that question today.

pnkfelix (Aug 27 2020 at 14:41, on Zulip):

It sounds like people are generally okay with lowering priority to P-medium

pnkfelix (Aug 27 2020 at 14:42, on Zulip):

next up

pnkfelix (Aug 27 2020 at 14:42, on Zulip):
nikomatsakis (Aug 27 2020 at 14:43, on Zulip):

hmm

nikomatsakis (Aug 27 2020 at 14:43, on Zulip):

#72493 ( move leak-check to during coherence, candidate eval)

nikomatsakis (Aug 27 2020 at 14:43, on Zulip):

that's the obvious candidate

nikomatsakis (Aug 27 2020 at 14:43, on Zulip):

there is some other bug assigned to me related to that

nikomatsakis (Aug 27 2020 at 14:44, on Zulip):

I've been 110% swamped with just 0 time for coding, reviews, etc

nikomatsakis (Aug 27 2020 at 14:44, on Zulip):

the error is correct

nikomatsakis (Aug 27 2020 at 14:45, on Zulip):

the diagnostics are not good, though, it's not showing where the binder occurs

pnkfelix (Aug 27 2020 at 14:45, on Zulip):

is it just not printing a for or something?

nikomatsakis (Aug 27 2020 at 14:45, on Zulip):

yeah basically

nikomatsakis (Aug 27 2020 at 14:45, on Zulip):

we have specialized output for impls

nikomatsakis (Aug 27 2020 at 14:45, on Zulip):

but not types

nikomatsakis (Aug 27 2020 at 14:45, on Zulip):

also referring to this as "mismatched types" is weird itself

nikomatsakis (Aug 27 2020 at 14:46, on Zulip):

remove_file however implements FnMut(?P) for some ?P, where in this case it is &'a Path for some 'a

nikomatsakis (Aug 27 2020 at 14:46, on Zulip):

but we need for<'b> FnMut(&'b Path)

pnkfelix (Aug 27 2020 at 14:46, on Zulip):

(Would "incompatible types" be better?)

nikomatsakis (Aug 27 2020 at 14:46, on Zulip):

I'm not sure, maybe, it doesn't feel like types at all

nikomatsakis (Aug 27 2020 at 14:46, on Zulip):

i.e., there is no FnMut type here (that's a trait)

pnkfelix (Aug 27 2020 at 14:46, on Zulip):

oh okay sure

nikomatsakis (Aug 27 2020 at 14:47, on Zulip):

we do in some cases have output that tries to say

pnkfelix (Aug 27 2020 at 14:47, on Zulip):

so hold on

nikomatsakis (Aug 27 2020 at 14:47, on Zulip):

"this implements Foo<&'a u32>for some 'a but we need it for any 'a"

pnkfelix (Aug 27 2020 at 14:47, on Zulip):

lets not get in the weeds

pnkfelix (Aug 27 2020 at 14:47, on Zulip):

I know that @nikomatsakis is swamped

pnkfelix (Aug 27 2020 at 14:48, on Zulip):

@nikomatsakis is there anyone currently active other than you with good enough knowledge of this code that you might be able to mentor a fix?

pnkfelix (Aug 27 2020 at 14:48, on Zulip):

or at least delegate investigation?

nikomatsakis (Aug 27 2020 at 14:49, on Zulip):

I left a comment to start

pnkfelix (Aug 27 2020 at 14:49, on Zulip):

(and maybe delegate issue #74400 as well, which I think is the other one that @nikomatsakis alluded to above...)

nikomatsakis (Aug 27 2020 at 14:49, on Zulip):

I'm not sure, maybe @Esteban Küber or maybe @Matthew Jasper

pnkfelix (Aug 27 2020 at 14:49, on Zulip):

okay well for now we've made some headway

nikomatsakis (Aug 27 2020 at 14:49, on Zulip):

but I'm also happy to try and at least leave some mentoring tips

nikomatsakis (Aug 27 2020 at 14:49, on Zulip):

pointing at the right points of the code

nikomatsakis (Aug 27 2020 at 14:50, on Zulip):

I left an initial comment and I'll leave some more :)

pnkfelix (Aug 27 2020 at 14:50, on Zulip):

okay

nikomatsakis (Aug 27 2020 at 14:50, on Zulip):

(I'm also thinking about what I can do to get "unswamped", because this isn't sustainable I think)

nikomatsakis (Aug 27 2020 at 14:50, on Zulip):

(but that's kind of an :evergreen_tree: thought =)

pnkfelix (Aug 27 2020 at 14:50, on Zulip):

I won't assign it to @nikomatsakis though because, well, they're currently swamped.)

pnkfelix (Aug 27 2020 at 14:50, on Zulip):

Nightly regressions

pnkfelix (Aug 27 2020 at 14:51, on Zulip):

right we just discussed this, sort of

pnkfelix (Aug 27 2020 at 14:51, on Zulip):

Performance logs

This week saw an upgrade to LLVM 11, which resulted in large speedups to
optimized builds. This offsets the slowdown we observed as part of the
upgrade to LLVM 10. Many thanks to rust-lang and LLVM contributor
@nikic for their work to measure LLVM performance. That upgrade did cause slight regressions to check and
debug builds, but on the whole it is a significant win for compile times.

Triage done by @ecstaticmorse.
Revision range: 67e7b9b8cf776222825dbbd4cb1e39b7765ef27c..03017003c77d782cf7ed841a05d7c628a9b93f25

1 Regression, 4 Improvements, 0 of them in rollups.

pnkfelix (Aug 27 2020 at 14:51, on Zulip):

whoops

pnkfelix (Aug 27 2020 at 14:52, on Zulip):

why didn't those links work?

simulacrum (Aug 27 2020 at 14:53, on Zulip):

hm I think because they're the "distance" Markdown links, and zulip only understands inline markdown links?

simulacrum (Aug 27 2020 at 14:53, on Zulip):

https://github.com/rust-lang/rustc-perf/blob/master/triage/2020-08-24.md

simulacrum (Aug 27 2020 at 14:53, on Zulip):

that's the report in rendered form

pnkfelix (Aug 27 2020 at 14:54, on Zulip):

okay well I edited the message

pnkfelix (Aug 27 2020 at 14:54, on Zulip):

I guess we'll see how the rest of the report looks

pnkfelix (Aug 27 2020 at 14:54, on Zulip):

Regressions

#75555 Cargo update (almost) all the things!

pnkfelix (Aug 27 2020 at 14:54, on Zulip):

Improvements

#75145 Reference lang items during AST lowering

#75590 Add a packed/tagged pointer abstraction and utilize it for ParamEnv

#73526 Upgrade to LLVM 11 (rc2)

#75813 Lazy decoding of DefPathTable from crate metadata (non-incremental case)

pnkfelix (Aug 27 2020 at 14:54, on Zulip):

Nags requiring follow up

None

nikomatsakis (Aug 27 2020 at 14:56, on Zulip):

seems good

pnkfelix (Aug 27 2020 at 14:56, on Zulip):

Nominated Issues

T-compiler

pnkfelix (Aug 27 2020 at 14:56, on Zulip):
pnkfelix (Aug 27 2020 at 14:57, on Zulip):

this is probably too in-depth for us to discuss in three minutes

pnkfelix (Aug 27 2020 at 14:57, on Zulip):

lets leave that nominated for next week

pnkfelix (Aug 27 2020 at 14:57, on Zulip):
pnkfelix (Aug 27 2020 at 14:58, on Zulip):

Notably: "This promotes aarch64-pc-windows-msvc from a Tier 2 Compilation Target (std) to a Tier 2 Development Platform (std+rustc+cargo+tools)."

Pietro Albini (Aug 27 2020 at 14:59, on Zulip):

@pnkfelix yeah the compiler team needs to approve the tier bump

pnkfelix (Aug 27 2020 at 14:59, on Zulip):

So @Pietro Albini made a point of saying that this promotion (#75914) requires sign-off from both teams

pnkfelix (Aug 27 2020 at 15:00, on Zulip):

Should we actually post an @rfcbot fcp merge for it?

pnkfelix (Aug 27 2020 at 15:00, on Zulip):

or is it sufficient to just use the people present here as the representative body of the compiler team?

nikomatsakis (Aug 27 2020 at 15:01, on Zulip):

I'd prefer to make approval to tier 2 an FCP I think

nikomatsakis (Aug 27 2020 at 15:01, on Zulip):

it feels like a "real decision" to me

pnkfelix (Aug 27 2020 at 15:01, on Zulip):

okay lets do that then

pnkfelix (Aug 27 2020 at 15:01, on Zulip):

@Pietro Albini that means that T-infra will need to check off their boxes too, okay?

Pietro Albini (Aug 27 2020 at 15:02, on Zulip):

@pnkfelix infra already signed off

Pietro Albini (Aug 27 2020 at 15:02, on Zulip):

each team can do the approval however they prefer :)

pnkfelix (Aug 27 2020 at 15:02, on Zulip):

I'm just saying in terms of the bots

pnkfelix (Aug 27 2020 at 15:02, on Zulip):

well whatever

Pietro Albini (Aug 27 2020 at 15:02, on Zulip):

I don't think it's necessary

Pietro Albini (Aug 27 2020 at 15:02, on Zulip):

feel free to remove the T-infra label

pnkfelix (Aug 27 2020 at 15:02, on Zulip):

okay that's what you meant

pnkfelix (Aug 27 2020 at 15:03, on Zulip):

Okay I'll remove T-infra, do @rfcbot fcp merge, and then readd T-infra

pnkfelix (Aug 27 2020 at 15:04, on Zulip):

libs-impl

pnkfelix (Aug 27 2020 at 15:04, on Zulip):

and that's everything!

pnkfelix (Aug 27 2020 at 15:04, on Zulip):

thanks to everyone in @T-compiler/meeting for attending!

eddyb (Aug 27 2020 at 17:03, on Zulip):

pnkfelix said:

this is probably too in-depth for us to discuss in three minutes

that's great because I forgot about it and wasn't even awake to participate :sweat_smile:

Last update: Nov 25 2020 at 02:00UTC