FWIW the clippy thing has seemed to just work, though I do think we've not had a bump yet and such
(and IIRC someone reported git subtree just segfaulting for them which is not great)
yea, git subtree has problems
they have an upstream fix
but it hasn't been merged yet
we can merge changes from clippy to rustc, but not the other way around without losing history
so right now we're doing the merge changes from rustc to clippy manually
(switched to a new topic)
@oli do we have some sense for if we've "hit all the bugs" yet?
or when you would feel comfortable making a call at least on whether to roll out further or not
I wouldn't roll out further until we either get the upstream thing merged and have an easy way of running upstream git anywhere, or have a script that does the "lose history push" for us in a nice encapsulated way
we're discussing the upstream fix at https://github.com/rust-lang/rust-clippy/issues/5565
basically I just need to find a day where I'm feeling up to diving into very dense bash scripts and documenting the patch's changes. The actual implementation is already there
FWIW we can totally host some git binaries for y'all to download as needed.
I presume that's not really "the issue" though.
Let me know please if there's something I can do to help or when you get it resolved