Stream: t-compiler/major changes

Topic: clippy subtree


simulacrum (May 08 2020 at 16:11, on Zulip):

FWIW the clippy thing has seemed to just work, though I do think we've not had a bump yet and such

simulacrum (May 08 2020 at 16:12, on Zulip):

(and IIRC someone reported git subtree just segfaulting for them which is not great)

oli (May 08 2020 at 16:12, on Zulip):

yea, git subtree has problems

oli (May 08 2020 at 16:12, on Zulip):

they have an upstream fix

oli (May 08 2020 at 16:12, on Zulip):

but it hasn't been merged yet

oli (May 08 2020 at 16:13, on Zulip):

we can merge changes from clippy to rustc, but not the other way around without losing history

oli (May 08 2020 at 16:13, on Zulip):

so right now we're doing the merge changes from rustc to clippy manually

simulacrum (May 08 2020 at 16:14, on Zulip):

ah okay

simulacrum (May 08 2020 at 16:14, on Zulip):

(switched to a new topic)

simulacrum (May 08 2020 at 16:14, on Zulip):

@oli do we have some sense for if we've "hit all the bugs" yet?

simulacrum (May 08 2020 at 16:15, on Zulip):

or when you would feel comfortable making a call at least on whether to roll out further or not

oli (May 08 2020 at 16:18, on Zulip):

I wouldn't roll out further until we either get the upstream thing merged and have an easy way of running upstream git anywhere, or have a script that does the "lose history push" for us in a nice encapsulated way

oli (May 08 2020 at 16:19, on Zulip):

we're discussing the upstream fix at https://github.com/rust-lang/rust-clippy/issues/5565

oli (May 08 2020 at 16:20, on Zulip):

basically I just need to find a day where I'm feeling up to diving into very dense bash scripts and documenting the patch's changes. The actual implementation is already there

simulacrum (May 08 2020 at 18:00, on Zulip):

FWIW we can totally host some git binaries for y'all to download as needed.

simulacrum (May 08 2020 at 18:00, on Zulip):

I presume that's not really "the issue" though.

simulacrum (May 08 2020 at 18:01, on Zulip):

Let me know please if there's something I can do to help or when you get it resolved

Last update: May 07 2021 at 08:00UTC