Stream: t-compiler/major changes

Topic: TypeVisitor: do not hard-code a `ControlF… compiler-team#383


triagebot (Nov 05 2020 at 15:41, on Zulip):

A new proposal has been announced: TypeVisitor: do not hard-code a ControlFlow<()> result #383. It will be announced at the next meeting to try and draw attention to it, but usually MCPs are not discussed during triage meetings. If you think this would benefit from discussion amongst the team, consider proposing a design meeting.

oli (Nov 05 2020 at 15:42, on Zulip):

that was fast :laughter_tears:

LeSeulArtichaut (Nov 05 2020 at 15:43, on Zulip):

You think so? :innocent:

LeSeulArtichaut (Nov 05 2020 at 15:43, on Zulip):

I'm currently experimeting with it so I thought I'd open an MCP

LeSeulArtichaut (Nov 05 2020 at 15:43, on Zulip):

Though it doesn't mean it has to be accepted now, I think?

oli (Nov 05 2020 at 15:44, on Zulip):

all good :grinning: I knew about the plans for this, and I definitely think we should do it

triagebot (Nov 05 2020 at 15:55, on Zulip):

@T-compiler: Proposal #383 has been seconded, and will be approved in 10 days if no objections are raised.

Jonas Schievink (Nov 05 2020 at 15:57, on Zulip):

Introduce a BreakTy associated type in TypeVisitor (which could default to ())

+1 for dogfooding associated type defaults more

Jack Huey (Nov 05 2020 at 15:59, on Zulip):

huh..so this ends up being like Chalk's VisitResult...

Jack Huey (Nov 05 2020 at 15:59, on Zulip):

So, what are the potential uses of this?

LeSeulArtichaut (Nov 05 2020 at 16:00, on Zulip):

See the review of #78182 for examples

nikomatsakis (Nov 05 2020 at 19:38, on Zulip):

I didn't see the examples in #78182

LeSeulArtichaut (Nov 05 2020 at 19:56, on Zulip):

nikomatsakis said:

I didn't see the examples in #78182

Those are:

LeSeulArtichaut (Nov 05 2020 at 19:57, on Zulip):

I just implemented them in #78779 but CI is failing, I need to investigate

triagebot (Nov 15 2020 at 16:50, on Zulip):

This proposal has been accepted: #383.

Last update: May 07 2021 at 07:30UTC