Stream: t-compiler/major changes

Topic: Preserve `PlaceContext` through projection compiler-team#300


triagebot (Jun 02 2020 at 18:29, on Zulip):

A new proposal has been announced #300. It will be brought up at the next meeting.

ecstatic-morse (Jun 02 2020 at 18:32, on Zulip):

I was originally going to just submit a PR, but PlaceContext is used in quite a few places in librustc_mir.

Jonas Schievink (Jun 02 2020 at 18:32, on Zulip):

cc @Santiago Pastorino

Santiago Pastorino (Jun 02 2020 at 19:22, on Zulip):

hey @Jonas Schievink, unsure why did you ping me but let me read the proposal I guess :)

Jonas Schievink (Jun 02 2020 at 19:23, on Zulip):

Because MIR Visitors seem to be something you tend to maintain :)

Santiago Pastorino (Jun 02 2020 at 19:24, on Zulip):

do I? :joy:

Santiago Pastorino (Jun 02 2020 at 19:24, on Zulip):

thanks for pointing that out to me :)

Santiago Pastorino (Jun 02 2020 at 19:30, on Zulip):

so I think the proposal makes sense yeah

Santiago Pastorino (Jun 02 2020 at 19:30, on Zulip):

@oli may have a better idea though

pnkfelix (Jun 02 2020 at 20:12, on Zulip):

I've often wondered whether all the visitors should have a Zipper-like parameter that provides such contextual info

pnkfelix (Jun 02 2020 at 20:12, on Zulip):

(but that is a bigger more global revision)

pnkfelix (Jun 02 2020 at 20:13, on Zulip):

(now I'm wondering whether one automatically define a set of zippers for a given data-type via a macro)

nikomatsakis (Jun 02 2020 at 22:00, on Zulip):

(this looks pretty good to me)

nikomatsakis (Jun 02 2020 at 22:00, on Zulip):

I would happily second

ecstatic-morse (Jun 02 2020 at 22:39, on Zulip):

FYI, the implementation is blocked on #72931.

triagebot (Jun 03 2020 at 07:10, on Zulip):

@T-compiler: Proposal #300 has been seconded, and will be approved in 10 days if no objections are raised.

Last update: May 07 2021 at 08:00UTC