Stream: t-compiler/major changes

Topic: Add different entry points for x.py compiler-team#396


triagebot (Jan 01 2021 at 20:10, on Zulip):

A new proposal has been announced: Add different entry points for x.py #396. It will be announced at the next meeting to try and draw attention to it, but usually MCPs are not discussed during triage meetings. If you think this would benefit from discussion amongst the team, consider proposing a design meeting.

Joshua Nelson (Jan 01 2021 at 20:12, on Zulip):

previous discussion in https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/different.20entry.20points.20for.20x.2Epy ; if someone with admin access could combine the streams that would be great.

simulacrum (Jan 01 2021 at 20:13, on Zulip):

I don't think this is describing the steps completely as I was expecting, the experimental nature and starting with std only is missing. It also has same name for all the scripts, whereas I think different names are indeed better.

Joshua Nelson (Jan 01 2021 at 20:14, on Zulip):

I updated the names

Joshua Nelson (Jan 01 2021 at 20:14, on Zulip):

I'll change it to say I'll implement std first

Joshua Nelson (Jan 01 2021 at 20:16, on Zulip):

done

Joshua Nelson (Jan 01 2021 at 20:16, on Zulip):

I don't feel super strongly about the naming, happy to bikeshed that

scottmcm (Jan 01 2021 at 22:48, on Zulip):

It would be great to have smaller commands that are focused on specific groups of contributors

:+1: to that, but as an alternative, we could also consider things like x.py bikesheds -- like x.py std-addition that builds and tests the appropriate things for that kind of contribution.

Joshua Nelson (Jan 01 2021 at 22:49, on Zulip):

if you want to use the existing x.py I would rather expand default profiles to have a 'default filter'

Joshua Nelson (Jan 01 2021 at 22:49, on Zulip):

so that x.py build for profile = "library", which already defaults to only stage 0, would additionally default to a library/std filter

Joshua Nelson (Jan 01 2021 at 22:49, on Zulip):

and then we really can give people a command to copy paste

Joshua Nelson (Jan 01 2021 at 22:49, on Zulip):

https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/the.20rustc-dev-guide.20is.20confusing/near/221141303

Aaron Hill (Jan 02 2021 at 01:41, on Zulip):

What do you mean by 'profile'?

Aaron Hill (Jan 02 2021 at 01:42, on Zulip):

is that something you would set in config.toml?

Joshua Nelson (Jan 02 2021 at 03:32, on Zulip):

@Aaron Hill yes, profiles are what x.py setup sets to have persistent state

Joshua Nelson (Jan 02 2021 at 03:34, on Zulip):

But you can write them manually too. The profiles currently are compiler, library, codegen, and user. I also plan to add tools once https://github.com/rust-lang/rust/pull/79540 is merged.

Joshua Nelson (Jan 02 2021 at 03:35, on Zulip):

(zulip doesn't let me edit this late: "default profiles" is a typo, it should just say "profiles")

apiraino (Apr 14 2021 at 16:36, on Zulip):

Head-up! As per MCP policy, this MCP will soon be closed for inactivity.

Should instead the discussion go on, please don't hesitate to add comments here or on github.
Else, you don't have to do anything, I will take care of closing it soon.

Joshua Nelson (Apr 14 2021 at 16:37, on Zulip):

I think we could make some improvement here. I don't know if it necessarily has to be different entrypoints.

Joshua Nelson (Apr 14 2021 at 16:38, on Zulip):

maybe x.py could be more aggressive about giving warnings/errors if you're doing something that doesn't make sense for the current profile?

Last update: May 07 2021 at 06:45UTC