Stream: t-compiler/wg-prioritization

Topic: I-prioritize #71471 thread 'rustc' panicked at 'begin <= end


triagebot (Apr 23 2020 at 16:01, on Zulip):

@WG-prioritization issue #71471 has been requested for prioritization.

LeSeulArtichaut (Apr 23 2020 at 16:06, on Zulip):

Seems like a P-low for me

LeSeulArtichaut (Apr 23 2020 at 16:11, on Zulip):

I wonder when this bug appeared

LeSeulArtichaut (Apr 23 2020 at 16:12, on Zulip):

Oh, this nightly, ok

Santiago Pastorino (Apr 23 2020 at 17:15, on Zulip):

P-low, if someone has a different idea for some reason let us know

triagebot (Apr 23 2020 at 17:17, on Zulip):

Issue #71471's prioritization request has been removed.

Russell Cohen (Apr 23 2020 at 17:19, on Zulip):

I'm doing a quick investigation, but it probably came from my changes to allow more invalid raw strings into the parser level to give better errors.

Santiago Pastorino (Apr 23 2020 at 17:26, on Zulip):

link to your changes?

Santiago Pastorino (Apr 23 2020 at 17:27, on Zulip):

@Russell Cohen maybe add the link to your changes in the issue

Russell Cohen (Apr 23 2020 at 17:41, on Zulip):

https://github.com/rust-lang/rust/pull/70522

Russell Cohen (Apr 23 2020 at 17:57, on Zulip):

Actually I'm pretty sure this is from https://github.com/rust-lang/rust/pull/71372/files

Russell Cohen (Apr 23 2020 at 18:06, on Zulip):

@Santiago Pastorino I think we may want to actually prioritize this? It causes things that aren't shebangs (because it's not actually the first line of the file) to be interpreted as a shebang (which then is ignored by the rust compiler). It seems like it _could_ break actual valid code in weird cases although I can't think of anything off the top of my head. It would have to begin with #! but have a third character that wasn't [ which is explicitly checked for

Santiago Pastorino (Apr 23 2020 at 19:32, on Zulip):

yeah, unsure what that may be

Santiago Pastorino (Apr 23 2020 at 19:33, on Zulip):

I'm inclined to leave this as P-low but if this breaks something that's actually possible in Rust code yeah we should bump priority for sure

Santiago Pastorino (Apr 23 2020 at 19:33, on Zulip):

cc @WG-prioritization

Santiago Pastorino (Apr 23 2020 at 19:34, on Zulip):

@Russell Cohen anyway, if you're working on a fix it would be great :)

DPC (Apr 23 2020 at 19:34, on Zulip):

i'd say maybe P-medium?

Santiago Pastorino (Apr 23 2020 at 19:46, on Zulip):

yeah, to be honest no idea, I haven't looked hard at it but I guess until we don't see real Rust code that this break, it's not really important in my opinion

Last update: Jun 05 2020 at 23:15UTC