Stream: t-compiler/wg-prioritization

Topic: I-prioritize #71416 `unsized_locals` fails to uphold alignme


triagebot (Apr 22 2020 at 14:01, on Zulip):

@WG-prioritization issue #71416 has been requested for prioritization.

Santiago Pastorino (Apr 22 2020 at 14:02, on Zulip):

I'd go with P-high

LeSeulArtichaut (Apr 22 2020 at 14:08, on Zulip):

If there are potential soundness issues in libstd/liballoc, we could also tag P-critical to investigate those libs?

LeSeulArtichaut (Apr 22 2020 at 14:09, on Zulip):

Oh, the plan is to separate the sound and unsound parts. Maybe not needed then

Santiago Pastorino (Apr 22 2020 at 15:32, on Zulip):

kind of also following what was done with #68304

Santiago Pastorino (Apr 22 2020 at 15:33, on Zulip):

which was the original issue and was P-high too

LeSeulArtichaut (Apr 22 2020 at 15:33, on Zulip):

But did P-critical exist then? :D

Santiago Pastorino (Apr 22 2020 at 15:33, on Zulip):

yeah, it could be P-critical mainly the thing you're mentioning

Santiago Pastorino (Apr 22 2020 at 15:34, on Zulip):

if used in libstd/liballoc

Santiago Pastorino (Apr 22 2020 at 15:34, on Zulip):

cc @Wesley Wiser @pnkfelix

Santiago Pastorino (Apr 22 2020 at 15:34, on Zulip):

I think I'd go with P-critical

Santiago Pastorino (Apr 22 2020 at 15:35, on Zulip):

release is happening tomorrow :P

Santiago Pastorino (Apr 22 2020 at 15:35, on Zulip):

so something critical would mean that this maybe needs to be rushed for tomorrow and unsure if this qualifies for that to be honest

LeSeulArtichaut (Apr 22 2020 at 15:36, on Zulip):

But we may want to add F-unsized_locals to the INCOMPLETE_FEATURES before then?

Santiago Pastorino (Apr 22 2020 at 15:37, on Zulip):

yeah, maybe something like that

LeSeulArtichaut (Apr 22 2020 at 15:37, on Zulip):

Just raising questions, because I don't even know what unsized_locals precisely are, I didn't take the time to check :sweat_smile:

Santiago Pastorino (Apr 22 2020 at 15:37, on Zulip):

let's see what others say about this, also cc @nikomatsakis @eddyb @RalfJ

Santiago Pastorino (Apr 22 2020 at 17:10, on Zulip):

@LeSeulArtichaut was taking a look at this and given https://github.com/rust-lang/rust/issues/71416#issuecomment-617575672 I don't think this is an urgent thing to do in a rush

Santiago Pastorino (Apr 22 2020 at 17:10, on Zulip):

I think I'd go with P-high and nominate it

LeSeulArtichaut (Apr 22 2020 at 17:11, on Zulip):

Agreed, this is probably enough

LeSeulArtichaut (Apr 22 2020 at 17:12, on Zulip):

LeSeulArtichaut said:

But we may want to add F-unsized_locals to the INCOMPLETE_FEATURES before then?

After thinking about it, I realized it's a nightly feature :face_palm:

triagebot (Apr 22 2020 at 17:26, on Zulip):

Issue #71416's prioritization request has been removed.

Santiago Pastorino (Apr 22 2020 at 17:42, on Zulip):

btw, created a PR for the INCOMPLETE_FEATURES part of this #71435

Last update: Jun 05 2020 at 23:10UTC