Stream: t-compiler/wg-prioritization

Topic: I-prioritize #70814 Running rustdoc on code using quote gene


triagebot (Apr 20 2020 at 20:00, on Zulip):

@WG-prioritization issue #70814 has been requested for prioritization.

Wesley Wiser (Apr 20 2020 at 20:54, on Zulip):

As a regression, it seems P-high to me.

LeSeulArtichaut (Apr 20 2020 at 20:56, on Zulip):

But at the same time it "only" affects lints and can potentially easily be worked around

Wesley Wiser (Apr 20 2020 at 20:57, on Zulip):

Very true

Wesley Wiser (Apr 20 2020 at 20:57, on Zulip):

I would have said P-medium but a few of the examples look pretty bad

Wesley Wiser (Apr 20 2020 at 20:58, on Zulip):

Oh, I guess all of the examples are in macro contexts...

Wesley Wiser (Apr 20 2020 at 20:58, on Zulip):

I'm torn, could be either P-medium or P-high to me

LeSeulArtichaut (Apr 20 2020 at 21:07, on Zulip):

Given that following the lint gives incorrect syntax, and that it only triggers when building docs, I’d go with P-medium

LeSeulArtichaut (Apr 20 2020 at 21:08, on Zulip):

Should we ping the Cleanup Crew for bisection too?

DPC (Apr 20 2020 at 21:09, on Zulip):

yes

LeSeulArtichaut (Apr 20 2020 at 22:09, on Zulip):

I can’t do it myself

LeSeulArtichaut (Apr 20 2020 at 22:10, on Zulip):

@DPC do you have the permission?

DPC (Apr 20 2020 at 22:10, on Zulip):

i think you should have as well via triagebot

DPC (Apr 20 2020 at 22:10, on Zulip):

if not i'll try in a few mins

LeSeulArtichaut (Apr 20 2020 at 22:11, on Zulip):

Error: Only Rust team members can ping teams.

DPC (Apr 20 2020 at 22:18, on Zulip):

aw.. doing it

DPC (Apr 20 2020 at 22:21, on Zulip):

done

LeSeulArtichaut (Apr 20 2020 at 22:22, on Zulip):

Thanks

DPC (Apr 20 2020 at 22:23, on Zulip):

@Santiago Pastorino can we get @LeSeulArtichaut the required permissions? :P

LeSeulArtichaut (Apr 20 2020 at 22:23, on Zulip):

I think we should ask @simulacrum instead

DPC (Apr 20 2020 at 22:23, on Zulip):

that'll work as well

simulacrum (Apr 20 2020 at 22:24, on Zulip):

ah you'll want to be added to wg-triage most likely (or we can special case wg-prioritization, I guess)

LeSeulArtichaut (Apr 20 2020 at 22:24, on Zulip):

In the triagebot code, there is an exception for the Triage WG (https://github.com/rust-lang/triagebot/blob/df95a780884271b158d0821a1e4693d9f988b393/src/github.rs#L58)

LeSeulArtichaut (Apr 20 2020 at 22:25, on Zulip):

Well it may be better to add another exception for this WG

LeSeulArtichaut (Apr 20 2020 at 22:26, on Zulip):

It would probably be handy to not add every prioritization member to the triage WG :P

simulacrum (Apr 20 2020 at 22:26, on Zulip):

:shrug: I can take a pr to add prioritization wg to triagebot no problem

LeSeulArtichaut (Apr 20 2020 at 22:27, on Zulip):

I’ll file one tomorrow if that’s OK

simulacrum (Apr 20 2020 at 22:27, on Zulip):

/me won't review it today anyway

LeSeulArtichaut (Apr 20 2020 at 22:31, on Zulip):

It isn’t urgent anyway :slight_smile:

DPC (Apr 20 2020 at 23:01, on Zulip):

It would probably be handy to not add every prioritization member to the triage WG :P

@LeSeulArtichaut why? :P

DPC (Apr 20 2020 at 23:02, on Zulip):

i mean it is just triagebot :P

LeSeulArtichaut (Apr 20 2020 at 23:16, on Zulip):

Oh you were serious? I thought you were kidding :eyes:

LeSeulArtichaut (Apr 20 2020 at 23:18, on Zulip):

Triagebot gets its data from rust-lang/team, so IIUC by « rust team members » it means either in a team (not a WG), or in the Triage WG

LeSeulArtichaut (Apr 20 2020 at 23:19, on Zulip):

So adding people to the triage WG would go beyond just triagebot

Santiago Pastorino (Apr 21 2020 at 13:30, on Zulip):

great that you've figured this out :)

LeSeulArtichaut (Apr 21 2020 at 13:30, on Zulip):

Santiago Pastorino said:

great that you've figured this out :slight_smile:

What are you talking about? :p

Santiago Pastorino (Apr 21 2020 at 13:31, on Zulip):

about the triagebot thing :)

Santiago Pastorino (Apr 21 2020 at 13:31, on Zulip):

I meant, that you're going to open a PR so you have rights

LeSeulArtichaut (Apr 21 2020 at 14:24, on Zulip):

We still need to decide whether this is P-medium or P-high though

Santiago Pastorino (Apr 21 2020 at 15:34, on Zulip):

@LeSeulArtichaut I'm right now going over all the pendings we have, we have 4 I-prioritize issues

Santiago Pastorino (Apr 21 2020 at 20:34, on Zulip):

for this one I think I'd go with P-medium if you agree :)

Santiago Pastorino (Apr 21 2020 at 20:34, on Zulip):

saw @Wesley Wiser was torn between P-high or P-medium

Wesley Wiser (Apr 21 2020 at 20:36, on Zulip):

P-medium sounds fine to me :)

triagebot (Apr 21 2020 at 20:39, on Zulip):

Issue #70814's prioritization request has been removed.

Last update: Jun 05 2020 at 21:35UTC