Stream: t-compiler/wg-prioritization

Topic: I-prioritize #71344 `broken MIR` `NoSolution` sized array in


triagebot (Apr 20 2020 at 10:27, on Zulip):

@WG-prioritization issue #71344 has been requested for prioritization.

LeSeulArtichaut (Apr 20 2020 at 15:35, on Zulip):

(deleted)

LeSeulArtichaut (Apr 20 2020 at 15:36, on Zulip):

Wrong thread :face_palm:‍♂️

LeSeulArtichaut (Apr 20 2020 at 17:29, on Zulip):

This one also seems quite bad

LeSeulArtichaut (Apr 20 2020 at 17:29, on Zulip):

Regressed 4 days ago

Santiago Pastorino (Apr 21 2020 at 15:47, on Zulip):

should we go with P-high for this one?

Santiago Pastorino (Apr 21 2020 at 15:47, on Zulip):

hmm or P-critical

Santiago Pastorino (Apr 21 2020 at 15:47, on Zulip):

cc @Wesley Wiser

Wesley Wiser (Apr 21 2020 at 20:36, on Zulip):

I'd say P-high only because there isn't a soundness issue here

LeSeulArtichaut (Apr 21 2020 at 20:37, on Zulip):

But at the same time it breaks code that is used

LeSeulArtichaut (Apr 21 2020 at 20:38, on Zulip):

We can also mark P-high but keep an eye out when we run Crater for the beta

Wesley Wiser (Apr 21 2020 at 20:38, on Zulip):

That's a great idea!

Santiago Pastorino (Apr 21 2020 at 20:40, on Zulip):

:+1:

LeSeulArtichaut (Apr 21 2020 at 20:40, on Zulip):

Maybe we should somehow organize the issues we need to come back to later

triagebot (Apr 21 2020 at 20:40, on Zulip):

Issue #71344's prioritization request has been removed.

LeSeulArtichaut (Apr 29 2020 at 09:22, on Zulip):

Crater is running (#71609), we should come back to it in 2 or 3 days when it's done

Santiago Pastorino (Apr 29 2020 at 11:14, on Zulip):

@LeSeulArtichaut sorry but I didn't get it, what's the relationship of that with this issue?

LeSeulArtichaut (Apr 29 2020 at 13:25, on Zulip):

LeSeulArtichaut said:

We can also mark P-high but keep an eye out when we run Crater for the beta

LeSeulArtichaut (Apr 29 2020 at 13:25, on Zulip):

I don't quite remember why I said that :big_smile:

LeSeulArtichaut (Apr 29 2020 at 13:25, on Zulip):

But I said it

Santiago Pastorino (Apr 29 2020 at 13:36, on Zulip):

anyway this issue is fixed

LeSeulArtichaut (Apr 29 2020 at 13:36, on Zulip):

It still went into beta right?

LeSeulArtichaut (Apr 29 2020 at 13:37, on Zulip):

When did beta branch? I don't remember :D

Santiago Pastorino (Apr 29 2020 at 13:39, on Zulip):

no idea either

Santiago Pastorino (Apr 29 2020 at 13:40, on Zulip):

cc @simulacrum

Santiago Pastorino (Apr 29 2020 at 13:41, on Zulip):

@simulacrum btw, how can we figure out when beta branches so we avoid bothering you every time this kind of conversation arises? :)

Santiago Pastorino (Apr 29 2020 at 13:41, on Zulip):

maybe that's documented somewhere?

simulacrum (Apr 29 2020 at 13:41, on Zulip):

Look at the origin/beta branch?

simulacrum (Apr 29 2020 at 13:42, on Zulip):

or test things on beta, which is the preferred way

LeSeulArtichaut (Apr 29 2020 at 13:43, on Zulip):

simulacrum said:

or test things on beta, which is the preferred way

Well I can't my computer is already busy (trying to) run tests :laughing:

simulacrum (Apr 29 2020 at 13:44, on Zulip):

playground says it still ices on beta

simulacrum (Apr 29 2020 at 13:44, on Zulip):
   Compiling playground v0.0.1 (/playground)
error: internal compiler error: broken MIR in DefId(0:9 ~ playground[d89e]::{{impl}}[0]::next[0]) ((_3.0: [u8; 12])): bad field access ([u8; _]: [u8; 12]): NoSolution
  --> src/main.rs:13:14
   |
13 |         let (outname,) = ([0u8; 12+0],);
   |              ^^^^^^^

thread 'rustc' panicked at 'no errors encountered even though `delay_span_bug` issued', src/librustc_errors/lib.rs:366:17
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

error: internal compiler error: unexpected panic

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports

note: rustc 1.44.0-beta.2 (b1162ed50 2020-04-25) running on x86_64-unknown-linux-gnu

note: compiler flags: -C codegen-units=1 -C debuginfo=2 --crate-type bin

note: some of the compiler flags provided by cargo are hidden

error: could not compile `playground`.

To learn more, run the command again with --verbose.
LeSeulArtichaut (Apr 29 2020 at 13:44, on Zulip):

This is what I thought. Thanks!

Santiago Pastorino (Apr 29 2020 at 13:45, on Zulip):

yeah was checking the branch and it's not included

Santiago Pastorino (Apr 29 2020 at 13:45, on Zulip):

I think this may be beta nominated

LeSeulArtichaut (Apr 29 2020 at 13:45, on Zulip):

I was about to say it :P

LeSeulArtichaut (Apr 29 2020 at 13:46, on Zulip):

It's 1 line long

Santiago Pastorino (Apr 29 2020 at 13:47, on Zulip):

yeah and risk zero because we need to normalize

LeSeulArtichaut (Apr 29 2020 at 13:47, on Zulip):

Should we beta-nominate already then?

Santiago Pastorino (Apr 29 2020 at 13:49, on Zulip):

yes

LeSeulArtichaut (Apr 29 2020 at 13:49, on Zulip):

Done

Santiago Pastorino (Apr 29 2020 at 13:49, on Zulip):

@simulacrum what's the procedure to do this?, sorry but I'm not 100% sure ...

simulacrum (Apr 29 2020 at 13:50, on Zulip):

just add the label to whatever PR fixed it on master

Santiago Pastorino (Apr 29 2020 at 13:50, on Zulip):

ahh @LeSeulArtichaut unsure what you did but if you know the way :+1:

LeSeulArtichaut (Apr 29 2020 at 13:50, on Zulip):

Well I just added the beta-nominated label on the fix PR

Santiago Pastorino (Apr 29 2020 at 13:50, on Zulip):

simulacrum said:

just add the label to whatever PR fixed it on master

we probably want to reopen it also?

LeSeulArtichaut (Apr 29 2020 at 13:50, on Zulip):

Not sure, I've seen merged PRs with the label

simulacrum (Apr 29 2020 at 13:50, on Zulip):

no need really but :shrug:

Santiago Pastorino (Apr 29 2020 at 13:51, on Zulip):

ok

simulacrum (Apr 29 2020 at 13:51, on Zulip):

if we have a beta-nom'd PR there's no need for an issue

LeSeulArtichaut (Apr 29 2020 at 13:51, on Zulip):

T-compiler meeting is tomorrow right?

LeSeulArtichaut (Apr 29 2020 at 13:52, on Zulip):

I'm a bit lost with the lockdown :big_smile:

simulacrum (Apr 29 2020 at 13:53, on Zulip):

yes, always thursdays

LeSeulArtichaut (Apr 29 2020 at 13:54, on Zulip):

This means we have pre-meeting today :eyes:

Santiago Pastorino (Apr 29 2020 at 14:06, on Zulip):

yes, we do :+1:

Last update: Jun 05 2020 at 22:50UTC