Stream: t-compiler/wg-prioritization

Topic: GitHub permissions for WG members


LeSeulArtichaut (Apr 14 2020 at 15:29, on Zulip):

I was wondering if members of the WG-prioritization should have triage permissions on the rust-lang/rust repo. According to the GitHub docs, it grants the following permissions:

So to me the question is: should we always let leaders assign those labels, which would make sense as they "represent" the WG and are responsible for the final decisions? Or should we give those permissions to all members so everyone can do it in case leaders are AFK/unavailible, or maybe just because is isn't fun for one person to always do the work.

cc @Santiago Pastorino @Wesley Wiser

Santiago Pastorino (Apr 14 2020 at 15:37, on Zulip):

I'd totally give this kind of access to the WG, cc @nikomatsakis @pnkfelix

DPC (Apr 14 2020 at 15:47, on Zulip):

Yeah i don't see why not. Even WG-Triage has some permissions, so definitely people here should have as well :slight_smile:

Santiago Pastorino (Apr 14 2020 at 16:23, on Zulip):

@LeSeulArtichaut can you open a PR on rust-lang/team about this and ping me?

LeSeulArtichaut (Apr 14 2020 at 16:24, on Zulip):

Is it possible to manage this in rust-lang/team?

LeSeulArtichaut (Apr 14 2020 at 16:24, on Zulip):

I don't see how you edit this

Santiago Pastorino (Apr 14 2020 at 16:25, on Zulip):

@DPC I don't see any special permission for triage https://github.com/rust-lang/team/blob/master/teams/wg-triage.toml

Santiago Pastorino (Apr 14 2020 at 16:25, on Zulip):

how is this handled?

LeSeulArtichaut (Apr 14 2020 at 16:25, on Zulip):

Probably in the organization settings?

Santiago Pastorino (Apr 14 2020 at 16:25, on Zulip):

LeSeulArtichaut said:

Is it possible to manage this in rust-lang/team?

yes, this is synced with github

DPC (Apr 14 2020 at 16:26, on Zulip):

It was done manually back then. Not sure if anything changes now

Santiago Pastorino (Apr 14 2020 at 16:26, on Zulip):

I think all the permissions of people, working groups and teams were moved to rust-lang/team

LeSeulArtichaut (Apr 14 2020 at 16:26, on Zulip):

Even in the T-compiler team I don't see any perms

Santiago Pastorino (Apr 14 2020 at 16:26, on Zulip):

let's have @Pietro Albini explaining this

DPC (Apr 14 2020 at 16:26, on Zulip):

They were added in the org so that they can close prs.

Santiago Pastorino (Apr 14 2020 at 16:27, on Zulip):

what's really there is https://github.com/rust-lang/team/blob/master/teams/compiler.toml#L26-L27

DPC (Apr 14 2020 at 16:27, on Zulip):

Compiler team is different. Because all compiler members are part of the rust org. For working group it's a different case.

Santiago Pastorino (Apr 14 2020 at 16:27, on Zulip):

unsure if the github perms are handled with some automation or we need to add those using Github UI

LeSeulArtichaut (Apr 14 2020 at 16:27, on Zulip):

Yes, but this is not a perm for the GH org

DPC (Apr 14 2020 at 16:28, on Zulip):

Do we have an entry in rust-lang/team?

DPC (Apr 14 2020 at 16:28, on Zulip):

With all the members

LeSeulArtichaut (Apr 14 2020 at 16:28, on Zulip):

For the prioritization WG? Yes

DPC (Apr 14 2020 at 16:28, on Zulip):

Then probably we have to discuss this on #infra

LeSeulArtichaut (Apr 14 2020 at 16:29, on Zulip):

On Discord?

Yuki Okushi (Apr 14 2020 at 16:41, on Zulip):

perms aren't managed in the team repo iirc, we should ping org owners or someone who has privilege

LeSeulArtichaut (Apr 14 2020 at 16:42, on Zulip):

Pietro Albini has been pinged above

Yuki Okushi (Apr 14 2020 at 16:44, on Zulip):

Then let's just wait or ping on Discord as well

Pietro Albini (Apr 14 2020 at 17:02, on Zulip):

so

Pietro Albini (Apr 14 2020 at 17:02, on Zulip):

the team repo manages the members of the teams, but permissions are handled in github's ui

Santiago Pastorino (Apr 14 2020 at 17:32, on Zulip):

@Pietro Albini so can we allow @WG-prioritization team to handle issues on rust-lang/rust?

Pietro Albini (Apr 14 2020 at 17:36, on Zulip):

gave wg-prioritization triage access to the repository

LeSeulArtichaut (Apr 14 2020 at 17:40, on Zulip):

That works, thanks!

Last update: Jun 05 2020 at 23:15UTC