hm, so I don't see anything being sent to zulip in logs
But the GitHub label is set correcly
So we reached the call to
ah maybe we just don't log raw requests, actually
Probably, I haven't added logs myself
Should we add them and test again?
we never authenticated that request
See the description for the E-needs-mcve label
too lazy :P
I'll give it to you then :P
Call for participation: This issue needs a Minimal Complete and Verifiable Example
@DPC There you have it :smirk:
You're welcome :slight_smile:
@simulacrum Let's try again?
CI is not that quick
It broke? :frown:
GitHub Actions has encountered an internal error when running your job.
trying to rerun
yah saw the same thing in #infra
The github issue is now resolved
yeah it should be deployed
I don't have a ready issue to mark but if you see something please try it
@simulacrum Can't we use #70934 like earlier?
I guess we can, just won't be a perfect test
okay, both worked
Titles are correct
Ping is there
I think this works as expected :slight_smile:
Thanks a lot for your help @simulacrum!
Thank you for implementing! :heart:
You did the painful job of refractoring though :slight_smile:
@Santiago Pastorino I think we might want to add a link to the Zulip thread on GitHub when using
I wanted to know what you think
or well, I meant whatever, what I usually do is after prioritizing it I add a comment pointing to the discussion on Zulip
I was wondering if it may be a good idea to make the bot also comment on github with a link to the zulip discussion about the prioritization of the issue
This is what I thought too
I can file a PR if @simulacrum is busy
we can also do here
@triagebot prioritize P-high from Zulip and have the bot on github removing
P-high and commenting with the link to the discussion :)
I was unable to find a nice way to get the Zulip URL, but I'm generally on board.
We should try to post links to both here and the read-only Zulip archive (which doesn't need authentication)
I don't have time but can review PRs
@LeSeulArtichaut do the bots open up topics in response to any addition of
I-prioritize to an issue? Or is it solely via the
@rustbot prioritize command that a topic gets opened up over here?
(either way in fine; I was expecting the latter because I didn't know if it would be hard to implement former. But if its the former, that is super cool !)
Now any addition of
I-prioritize opens a topic here
again, super cool!
Thank simulacrum :slight_smile: