Stream: t-compiler/wg-prioritization

Topic: triagebot prioritization


simulacrum (Apr 11 2020 at 13:32, on Zulip):

hm, so I don't see anything being sent to zulip in logs

LeSeulArtichaut (Apr 11 2020 at 13:32, on Zulip):

But the GitHub label is set correcly

LeSeulArtichaut (Apr 11 2020 at 13:32, on Zulip):

So we reached the call to futures::join!()

simulacrum (Apr 11 2020 at 13:33, on Zulip):

ah maybe we just don't log raw requests, actually

LeSeulArtichaut (Apr 11 2020 at 13:33, on Zulip):

Probably, I haven't added logs myself

LeSeulArtichaut (Apr 11 2020 at 13:33, on Zulip):

Should we add them and test again?

simulacrum (Apr 11 2020 at 13:33, on Zulip):

oh wait

simulacrum (Apr 11 2020 at 13:33, on Zulip):

we never authenticated that request

LeSeulArtichaut (Apr 11 2020 at 13:34, on Zulip):

Oops :eyes:

simulacrum (Apr 11 2020 at 13:35, on Zulip):

fixing now

LeSeulArtichaut (Apr 11 2020 at 13:35, on Zulip):

Thanks :big_smile:

DPC (Apr 11 2020 at 13:44, on Zulip):

See the description for the E-needs-mcve label

too lazy :P

simulacrum (Apr 11 2020 at 13:44, on Zulip):

alright pushing

LeSeulArtichaut (Apr 11 2020 at 13:44, on Zulip):

I'll give it to you then :P

LeSeulArtichaut (Apr 11 2020 at 13:45, on Zulip):

Call for participation: This issue needs a Minimal Complete and Verifiable Example

LeSeulArtichaut (Apr 11 2020 at 13:45, on Zulip):

@DPC There you have it :smirk:

DPC (Apr 11 2020 at 13:45, on Zulip):

:D

DPC (Apr 11 2020 at 13:46, on Zulip):

thanks :smile_cat:

LeSeulArtichaut (Apr 11 2020 at 13:46, on Zulip):

You're welcome :slight_smile:

LeSeulArtichaut (Apr 11 2020 at 13:47, on Zulip):

@simulacrum Let's try again?

simulacrum (Apr 11 2020 at 13:47, on Zulip):

CI is not that quick

LeSeulArtichaut (Apr 11 2020 at 13:48, on Zulip):

Right :eyes:

LeSeulArtichaut (Apr 11 2020 at 13:53, on Zulip):

It broke? :frown:

LeSeulArtichaut (Apr 11 2020 at 13:54, on Zulip):

GitHub Actions has encountered an internal error when running your job.

Nice

simulacrum (Apr 11 2020 at 14:00, on Zulip):

trying to rerun

simulacrum (Apr 11 2020 at 14:01, on Zulip):

ah https://www.githubstatus.com/incidents/2wx06v7dbzhg

DPC (Apr 11 2020 at 14:09, on Zulip):

yah saw the same thing in #infra

LeSeulArtichaut (Apr 11 2020 at 14:25, on Zulip):

Broke again

DPC (Apr 11 2020 at 16:08, on Zulip):

The github issue is now resolved

simulacrum (Apr 11 2020 at 16:21, on Zulip):

yeah it should be deployed

simulacrum (Apr 11 2020 at 16:21, on Zulip):

I don't have a ready issue to mark but if you see something please try it

LeSeulArtichaut (Apr 11 2020 at 16:57, on Zulip):

@simulacrum Can't we use #70934 like earlier?

simulacrum (Apr 11 2020 at 16:58, on Zulip):

I guess we can, just won't be a perfect test

LeSeulArtichaut (Apr 11 2020 at 16:58, on Zulip):

Or maybe...

LeSeulArtichaut (Apr 11 2020 at 16:58, on Zulip):

#70963 ?

simulacrum (Apr 11 2020 at 16:59, on Zulip):

okay, both worked

LeSeulArtichaut (Apr 11 2020 at 17:00, on Zulip):

Titles are correct

LeSeulArtichaut (Apr 11 2020 at 17:00, on Zulip):

Ping is there

LeSeulArtichaut (Apr 11 2020 at 17:00, on Zulip):

I think this works as expected :slight_smile:

LeSeulArtichaut (Apr 11 2020 at 17:01, on Zulip):

Thanks a lot for your help @simulacrum!

simulacrum (Apr 11 2020 at 17:15, on Zulip):

Thank you for implementing! :heart:

LeSeulArtichaut (Apr 11 2020 at 17:15, on Zulip):

You did the painful job of refractoring though :slight_smile:

LeSeulArtichaut (Apr 13 2020 at 18:27, on Zulip):

@Santiago Pastorino I think we might want to add a link to the Zulip thread on GitHub when using @rustbot prioritize

LeSeulArtichaut (Apr 13 2020 at 18:27, on Zulip):

I wanted to know what you think

Santiago Pastorino (Apr 13 2020 at 18:43, on Zulip):

yes, :+1:

Santiago Pastorino (Apr 13 2020 at 18:44, on Zulip):

or well, I meant whatever, what I usually do is after prioritizing it I add a comment pointing to the discussion on Zulip

Santiago Pastorino (Apr 21 2020 at 19:16, on Zulip):

I was wondering if it may be a good idea to make the bot also comment on github with a link to the zulip discussion about the prioritization of the issue

LeSeulArtichaut (Apr 21 2020 at 19:17, on Zulip):

This is what I thought too

LeSeulArtichaut (Apr 21 2020 at 19:17, on Zulip):

I can file a PR if @simulacrum is busy

Santiago Pastorino (Apr 21 2020 at 19:19, on Zulip):

we can also do here @triagebot prioritize P-high from Zulip and have the bot on github removing I-prioritize,adding P-high and commenting with the link to the discussion :)

simulacrum (Apr 21 2020 at 19:21, on Zulip):

I was unable to find a nice way to get the Zulip URL, but I'm generally on board.

We should try to post links to both here and the read-only Zulip archive (which doesn't need authentication)

simulacrum (Apr 21 2020 at 19:21, on Zulip):

I don't have time but can review PRs

pnkfelix (Apr 27 2020 at 15:50, on Zulip):

@LeSeulArtichaut do the bots open up topics in response to any addition of I-prioritize to an issue? Or is it solely via the @rustbot prioritize command that a topic gets opened up over here?

pnkfelix (Apr 27 2020 at 15:50, on Zulip):

(either way in fine; I was expecting the latter because I didn't know if it would be hard to implement former. But if its the former, that is super cool !)

LeSeulArtichaut (Apr 27 2020 at 15:50, on Zulip):

Now any addition of I-prioritize opens a topic here

pnkfelix (Apr 27 2020 at 15:50, on Zulip):

again, super cool!

LeSeulArtichaut (Apr 27 2020 at 15:51, on Zulip):

Thank simulacrum :slight_smile:

Last update: Jun 05 2020 at 22:50UTC