Stream: t-compiler/wg-prioritization

Topic: pre-meeting triage 2020-05-14 #54818


Santiago Pastorino (May 13 2020 at 19:00, on Zulip):

@WG-prioritization let's start the pre-triage

Santiago Pastorino (May 13 2020 at 19:03, on Zulip):

The triage meeting will happen in #t-compiler > weekly meeting 2020-05-14 #54818

Santiago Pastorino (May 13 2020 at 19:03, on Zulip):

I have created the agenda we will be building during this meeting

Santiago Pastorino (May 13 2020 at 19:04, on Zulip):

Remove I-nominated leftovers

Unnominate leftover I-nominated
Remove I-nominated tag from issues discussed on the last meeting.

Issues

Santiago Pastorino (May 13 2020 at 19:06, on Zulip):

let's take a look if in last meeting we've discussed that one

Santiago Pastorino (May 13 2020 at 19:06, on Zulip):

I remember we did but don't remember if we wanted to leave that one nominated for some reason

Santiago Pastorino (May 13 2020 at 19:07, on Zulip):

ok that one is nominated for T-lang, so we should add it to the agenda and neither remove as a leftover

Santiago Pastorino (May 13 2020 at 19:08, on Zulip):

Unprioritized I-prioritize

Go over unprioritized I-prioritize issues. We should also go over I-nominated meanwhile we migrate, we were using I-nominated sometimes as an implicit request for prioritization.

No team assigned
Add T-compiler tag when it corresponds.

Issues

Empty

T-compiler
Prioritize issues and remove nomination of the ones not worth discussing.
Tag regressions accordingly.
Ping appropriate people and/or ICE-breakers.

Issues

Empty

All teams
No action required. It's nice to look at this for comparison.

Issues

Empty

Santiago Pastorino (May 13 2020 at 19:08, on Zulip):

that section everything is empty, as expected :heart:, given that we are prioritizing async

Santiago Pastorino (May 13 2020 at 19:08, on Zulip):

I-nominated T-compiler

I-nominated T-compiler
Do a sanity check on them.
Add them to the agenda.

Issues

Santiago Pastorino (May 13 2020 at 19:09, on Zulip):

again this one is nominated for T-lang, I wonder how should we get rid of this problem

Santiago Pastorino (May 13 2020 at 19:09, on Zulip):

my take on this is that we should tag just one team on not both?

Santiago Pastorino (May 13 2020 at 19:09, on Zulip):

cc @pnkfelix

Santiago Pastorino (May 13 2020 at 19:09, on Zulip):

let's move on

Santiago Pastorino (May 13 2020 at 19:09, on Zulip):

Check I-nominated all-teams.

Issues

Santiago Pastorino (May 13 2020 at 19:10, on Zulip):

for this case, given the lack of metadata better to check using the link

Santiago Pastorino (May 13 2020 at 19:10, on Zulip):

talking about ... Check I-nominated all-teams.

Santiago Pastorino (May 13 2020 at 19:11, on Zulip):

anyway, doesn't seem to be anything for us

Santiago Pastorino (May 13 2020 at 19:11, on Zulip):

Critical and High priority issues

Santiago Pastorino (May 13 2020 at 19:11, on Zulip):

there's no automation for this one

Santiago Pastorino (May 13 2020 at 19:11, on Zulip):

there's one P-critical, assigned to me

Santiago Pastorino (May 13 2020 at 19:12, on Zulip):

adding to agenda ...

Santiago Pastorino (May 13 2020 at 19:15, on Zulip):

done

Santiago Pastorino (May 13 2020 at 19:15, on Zulip):

there are 42 P-high issues

Santiago Pastorino (May 13 2020 at 19:15, on Zulip):

22 unassigned

Santiago Pastorino (May 13 2020 at 19:16, on Zulip):

gonna note that in the agenda later

Santiago Pastorino (May 13 2020 at 19:16, on Zulip):

Regressions

Beta regressions without P-label
Prioritize.
Ping appropriate people and/or ICE-breakers.
Assign if possible; if it remains unassigned, add it to agenda so we can assign during the meeting.

Issues

Empty

Nightly regressions without P-label
Prioritize.
Ping appropriate people and/or ICE-breakers.
Assign if possible; if it remains unassigned, add it to agenda so we can assign during the meeting.

Issues

Santiago Pastorino (May 13 2020 at 19:17, on Zulip):

we need to prioritize this one

Santiago Pastorino (May 13 2020 at 19:17, on Zulip):

it has a PR open already

DPC (May 13 2020 at 19:18, on Zulip):

should I request prioritisation?

Santiago Pastorino (May 13 2020 at 19:18, on Zulip):

we should do it now I guess

Santiago Pastorino (May 13 2020 at 19:19, on Zulip):

I think it's not a huge deal

Santiago Pastorino (May 13 2020 at 19:19, on Zulip):

P-medium?

Santiago Pastorino (May 13 2020 at 19:19, on Zulip):

thoughts?

DPC (May 13 2020 at 19:20, on Zulip):

(deleted)

Santiago Pastorino (May 13 2020 at 19:23, on Zulip):

ok, let's move on meanwhile we prioritize this one

Santiago Pastorino (May 13 2020 at 19:23, on Zulip):

Beta nominations

No team assigned
Add T-compiler tag when it corresponds.

Issues

Santiago Pastorino (May 13 2020 at 19:24, on Zulip):

done

Santiago Pastorino (May 13 2020 at 19:24, on Zulip):

All teams
Add T-compiler tag when it corresponds.

Issues

Santiago Pastorino (May 13 2020 at 19:25, on Zulip):

done too #71960 was missing

Santiago Pastorino (May 13 2020 at 19:28, on Zulip):

T-compiler
Add these issues to the meeting agenda.

Issues

Santiago Pastorino (May 13 2020 at 19:28, on Zulip):

adding those to the agenda

Santiago Pastorino (May 13 2020 at 19:29, on Zulip):

done

Santiago Pastorino (May 13 2020 at 19:29, on Zulip):

Stable nominations

No team assigned
Add T-compiler tag when it corresponds.

Issues

Empty

All teams
Add T-compiler tag when it corresponds.

Issues

Empty

T-compiler
Add these issues to the meeting agenda.

Issues

Empty

Santiago Pastorino (May 13 2020 at 19:29, on Zulip):

no stable nominations

Santiago Pastorino (May 13 2020 at 19:29, on Zulip):

PR's waiting for our team

PR's waiting for our team
Add them to the meeting agenda explaining what they are waiting for.
Explicitly nominate any that you think may be able to be resolved quickly in triage meeting.

Issues

Empty

Santiago Pastorino (May 13 2020 at 19:29, on Zulip):

no PR's waiting for our team

Santiago Pastorino (May 13 2020 at 19:29, on Zulip):

Stable to beta regressions

Stable-to-beta regressions (all! not just T-compiler)
Check if there are relevant issues that are worth raising awareness.
Assign if possible; if it remains unassigned, add it to agenda so we can assign during the meeting.

Issues

Santiago Pastorino (May 13 2020 at 19:32, on Zulip):

there's one p-high unassigned

Santiago Pastorino (May 13 2020 at 19:32, on Zulip):

anything worth raising awareness?

Santiago Pastorino (May 13 2020 at 19:32, on Zulip):

going to review one by one

lcnr (May 13 2020 at 19:33, on Zulip):

The first 4 seem fine IMO

lcnr (May 13 2020 at 19:34, on Zulip):

don't know enough about #70098

Santiago Pastorino (May 13 2020 at 19:34, on Zulip):

@lcnr what do you mean by seem fine?

lcnr (May 13 2020 at 19:35, on Zulip):

anything worth raising awareness?

That I believe they do not need additional awareness

Santiago Pastorino (May 13 2020 at 19:35, on Zulip):

yeah it seems like that and the one you pointed out is already handled by async wg

Santiago Pastorino (May 13 2020 at 19:35, on Zulip):

let's move on

Santiago Pastorino (May 13 2020 at 19:36, on Zulip):

Stable to nightly regressions

Stable-to-nightly regressions (all! not just T-compiler)
Check if there are relevant issues that are worth raising awareness.
Assign if possible; if it remains unassigned, add it to agenda so we can assign during the meeting.

Issues

Santiago Pastorino (May 13 2020 at 19:37, on Zulip):

same thing here

Santiago Pastorino (May 13 2020 at 19:38, on Zulip):

I don't think there's any relevant stuff there

Santiago Pastorino (May 13 2020 at 19:38, on Zulip):

thoughts?

Santiago Pastorino (May 13 2020 at 19:38, on Zulip):

Announcements

Santiago Pastorino (May 13 2020 at 19:39, on Zulip):

there's "design meeting: survey overview and discussion" on friday

Santiago Pastorino (May 13 2020 at 19:40, on Zulip):

is there something else?

Santiago Pastorino (May 13 2020 at 19:40, on Zulip):

will process the to-announce stuff because I need to consider some changes that nikomatsakis asked for

Santiago Pastorino (May 13 2020 at 19:40, on Zulip):

will add that to my script

Santiago Pastorino (May 13 2020 at 19:41, on Zulip):

and will also work in the script and publish it soon :)

Santiago Pastorino (May 13 2020 at 19:41, on Zulip):

it's really a shame of a thing to share :P

Santiago Pastorino (May 13 2020 at 19:41, on Zulip):

CCCVDD

Santiago Pastorino (May 13 2020 at 19:41, on Zulip):

ctrl-c + ctrl-v driven development :joy:

Santiago Pastorino (May 13 2020 at 19:42, on Zulip):

let's move on

Santiago Pastorino (May 13 2020 at 19:42, on Zulip):

Toolstate

Santiago Pastorino (May 13 2020 at 19:42, on Zulip):

nomicon and clippy-driver are failing

DPC (May 13 2020 at 19:42, on Zulip):

clipy is being updated

Santiago Pastorino (May 13 2020 at 19:42, on Zulip):

still far from the release

Santiago Pastorino (May 13 2020 at 19:43, on Zulip):

and last

Santiago Pastorino (May 13 2020 at 19:43, on Zulip):

Performance regressions

Check perf regressions.

Santiago Pastorino (May 13 2020 at 19:43, on Zulip):

what happened in summary-opt

Santiago Pastorino (May 13 2020 at 19:45, on Zulip):

image.png

Santiago Pastorino (May 13 2020 at 19:45, on Zulip):

started in #72074

lcnr (May 13 2020 at 19:46, on Zulip):

Probably https://github.com/rust-lang/rust/pull/71840?

Santiago Pastorino (May 13 2020 at 19:46, on Zulip):

@simulacrum sorry to bother you, but are you aware of this?

Santiago Pastorino (May 13 2020 at 19:46, on Zulip):

also I'm not sure what's incr-patched

simulacrum (May 13 2020 at 19:47, on Zulip):

there's descriptions at the top :/

yes it's known don't worry about it

Santiago Pastorino (May 13 2020 at 19:47, on Zulip):

:+1:

Santiago Pastorino (May 13 2020 at 19:49, on Zulip):

thanks Mark

Santiago Pastorino (May 13 2020 at 19:49, on Zulip):

doesn't seem to be anything else

Santiago Pastorino (May 13 2020 at 19:49, on Zulip):

this is record time for this meeting :)

Santiago Pastorino (May 13 2020 at 19:49, on Zulip):

I guess this is all

Santiago Pastorino (May 13 2020 at 19:49, on Zulip):

thanks everyone for helping out

Santiago Pastorino (May 13 2020 at 19:49, on Zulip):

:wave:

Santiago Pastorino (May 13 2020 at 19:49, on Zulip):

going to finish and polish the agenda now

DPC (May 13 2020 at 19:50, on Zulip):

from 2 hours to 49 mins.. achievement xD

Wesley Wiser (May 13 2020 at 19:52, on Zulip):

Santiago Pastorino said:

it's really a shame of a thing to share :P

The nice thing about open source is that people will fix that for you :laughing:

Santiago Pastorino (May 13 2020 at 19:52, on Zulip):

:)

Santiago Pastorino (May 13 2020 at 19:54, on Zulip):

DPC said:

from 2 hours to 49 mins.. achievement xD

although one big pending thing is that the agenda is pretty small

Santiago Pastorino (May 13 2020 at 19:54, on Zulip):

it may make sense to check harder to see if there's something to nominate

Santiago Pastorino (May 13 2020 at 19:54, on Zulip):

@WG-prioritization :point_up:

Wesley Wiser (May 13 2020 at 19:55, on Zulip):

I think it might be good to talk about "vec macro into_boxed codegen regression" #71861

Santiago Pastorino (May 13 2020 at 19:55, on Zulip):

to be clear, my take on this is that it's better to have a smaller agenda and having a faster meeting that adding useless things and making everyone waste time

Wesley Wiser (May 13 2020 at 19:55, on Zulip):

How severe are code-quality regressions and what priority should they get?

Santiago Pastorino (May 13 2020 at 19:56, on Zulip):

at the same time, it may be good to talk about important things that we usually lack time to do

Wesley Wiser (May 13 2020 at 19:56, on Zulip):

That's fair :thumbs_up:

Santiago Pastorino (May 13 2020 at 19:56, on Zulip):

@Wesley Wiser do you mind to nominate?

Santiago Pastorino (May 13 2020 at 19:57, on Zulip):

also may be interesting to know if @nikomatsakis wants to spend some meeting time on #71550

Wesley Wiser (May 13 2020 at 19:57, on Zulip):

Done

Santiago Pastorino (May 13 2020 at 19:57, on Zulip):

adding it to the agenda ...

Santiago Pastorino (May 13 2020 at 19:58, on Zulip):

done

Santiago Pastorino (May 13 2020 at 21:50, on Zulip):

final agenda https://hackmd.io/xIMXNk4cQ1m6rdGl-XWhGg?both

Santiago Pastorino (May 13 2020 at 21:50, on Zulip):

it's a little bit short, may worth investigating some more P-high issues

Santiago Pastorino (May 13 2020 at 21:50, on Zulip):

just in case we have more time or something

Santiago Pastorino (May 14 2020 at 13:09, on Zulip):

@WG-prioritization I was contemplating on nominating some P-high issues

Santiago Pastorino (May 14 2020 at 13:09, on Zulip):

maybe #70924 could be one

o0Ignition0o - Jeremy Lempereur (May 14 2020 at 13:13, on Zulip):

Oh yeah the one that requires a clean! definitely

Santiago Pastorino (May 14 2020 at 13:22, on Zulip):

are there more you would nominate? ...

Santiago Pastorino (May 14 2020 at 13:22, on Zulip):

I'm checking ...

LeSeulArtichaut (May 14 2020 at 13:24, on Zulip):

I was about to propose #72051 but it has a fix

Santiago Pastorino (May 14 2020 at 13:25, on Zulip):

:+1:, let's probably skip it then

LeSeulArtichaut (May 14 2020 at 13:30, on Zulip):

@Santiago Pastorino does #71694 need discussion?

Santiago Pastorino (May 14 2020 at 13:32, on Zulip):

not really

Santiago Pastorino (May 14 2020 at 13:33, on Zulip):

maybe the dynamic alloca part of this

Santiago Pastorino (May 14 2020 at 13:33, on Zulip):

#70502 is waiting on team

Santiago Pastorino (May 14 2020 at 13:33, on Zulip):

but this is really T-libs, I think it's actually libs-impl

Santiago Pastorino (May 14 2020 at 13:33, on Zulip):

going to add to agenda

Santiago Pastorino (May 14 2020 at 13:33, on Zulip):

but would be nice to confirm how this one should be tagged, I'd say libs-impl

Santiago Pastorino (May 14 2020 at 13:33, on Zulip):

cc @pnkfelix

LeSeulArtichaut (May 14 2020 at 13:37, on Zulip):

Given it is about "internal state" I'd also say it's libs-impl

Santiago Pastorino (May 14 2020 at 13:39, on Zulip):

yes, pretty sure it is, let me label it and comment about it

Santiago Pastorino (May 14 2020 at 13:42, on Zulip):

done

Santiago Pastorino (May 14 2020 at 13:42, on Zulip):

may be a good idea to check https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3AI-nominated+label%3AT-libs

Santiago Pastorino (May 14 2020 at 13:42, on Zulip):

to see if there's something wrongly tagged that should be libs-impl really

Santiago Pastorino (May 14 2020 at 13:43, on Zulip):

I'd say this one #71359

simulacrum (May 14 2020 at 13:44, on Zulip):

yeah that's an implementation issue

LeSeulArtichaut (May 14 2020 at 13:45, on Zulip):

Maybe #55005?

Santiago Pastorino (May 14 2020 at 13:47, on Zulip):

#68709 this one too, right?

Santiago Pastorino (May 14 2020 at 13:47, on Zulip):

I'm kind of quickly checking ...

Santiago Pastorino (May 14 2020 at 13:47, on Zulip):

LeSeulArtichaut said:

Maybe #55005?

let me see

Santiago Pastorino (May 14 2020 at 13:48, on Zulip):

#55005 too, yeah

Santiago Pastorino (May 14 2020 at 13:49, on Zulip):

@LeSeulArtichaut hmm looking again at the issue was nominated for T-lang

Santiago Pastorino (May 14 2020 at 13:50, on Zulip):

#68536 ?

Santiago Pastorino (May 14 2020 at 13:50, on Zulip):

that last one for sure

Santiago Pastorino (May 14 2020 at 13:53, on Zulip):

Santiago Pastorino said:

#68709 this one too, right?

I think this should probably be T-libs

Santiago Pastorino (May 14 2020 at 13:57, on Zulip):

added the following ...

Santiago Pastorino (May 14 2020 at 13:57, on Zulip):

libs-impl nominations ...

Last update: Jun 05 2020 at 23:10UTC