Stream: t-compiler/wg-prioritization

Topic: cargo-bisect-rustc automation


Santiago Pastorino (May 21 2020 at 14:34, on Zulip):

opening this for discussion

Santiago Pastorino (May 21 2020 at 14:34, on Zulip):

was talking with @bjorn3

Santiago Pastorino (May 21 2020 at 14:34, on Zulip):

Santiago Pastorino: I wonder ... can we activate cargo-bisect-rustc-bot in rust-lang/rust repo or in zulip in some way?
bjorn3: On zulip it works if you previously left any comment on the github repo, so heroku starts it. After 30min I believe heroku will stop it again though.
bjorn3: For rust-lang/rust it would be a matter of whitelisting the repo in the source code and adding a webhook for comments.
bjorn3: The zulip integration uses long polling, as I am not allowed to add a webhook myself.
Santiago Pastorino: let me open a topic on Zulip so other, in particular @simulacrum can see this and discuss :)
bjorn3: You can copy my messages

Santiago Pastorino (May 21 2020 at 14:35, on Zulip):

@pnkfelix @simulacrum

simulacrum (May 21 2020 at 14:35, on Zulip):

I don't want to add further automation before we integrate into triagebot. I've been bogged down with perf.rlo work so haven't had time to work on triagebot lately

LeSeulArtichaut (May 21 2020 at 14:36, on Zulip):

I maybe can take a look myself?

LeSeulArtichaut (May 21 2020 at 14:36, on Zulip):

I can try to integrate it into triagebot until you find time to review it?

simulacrum (May 21 2020 at 14:37, on Zulip):

I can probably find time for review yeah

Santiago Pastorino (May 21 2020 at 14:37, on Zulip):

cool, happy to help also :)

LeSeulArtichaut (May 21 2020 at 14:38, on Zulip):

My main concern is that you told us triagebot doesn't have a file system?

bjorn3 (May 21 2020 at 14:39, on Zulip):

The current architecture uses github actions to run the bisection. This means that there are no filesystem accesses by the bot.

LeSeulArtichaut (May 21 2020 at 14:39, on Zulip):

Oh, right. That makes things simpler :slight_smile:

LeSeulArtichaut (May 21 2020 at 14:39, on Zulip):

@bjorn3 Would you mind sharing the code you wrote? Is it pushed somewhere?

bjorn3 (May 21 2020 at 14:40, on Zulip):

https://github.com/bjorn3/cargo-bisect-rustc-bot is the repo

bjorn3 (May 21 2020 at 14:40, on Zulip):

https://github.com/bjorn3/cargo-bisect-rustc-bot/blob/4e9827dc4e885e3a78bb08de9829b9aa66127a84/src/main.rs#L251-L342 is the part that pushes the actual job

LeSeulArtichaut (May 21 2020 at 14:40, on Zulip):

Alright, thanks!

Last update: Jun 05 2020 at 22:20UTC