Stream: t-compiler/wg-prioritization

Topic: pre-meeting triage 2020-04-30 #54818


Santiago Pastorino (Apr 29 2020 at 19:02, on Zulip):

@WG-prioritization let's start the pre-triage

DPC (Apr 29 2020 at 19:03, on Zulip):

@o0Ignition0o - Jeremy Lempereur :P

DPC (Apr 29 2020 at 19:03, on Zulip):

(we probably need to add jeremy to the role)

Santiago Pastorino (Apr 29 2020 at 19:04, on Zulip):

The triage meeting will happen in #t-compiler > weekly meeting 2020-04-30 #54818

Santiago Pastorino (Apr 29 2020 at 19:05, on Zulip):

DPC said:

o0Ignition0o - Jeremy Lempereur :P

just added to the zulip group

Santiago Pastorino (Apr 29 2020 at 19:07, on Zulip):

ok back here

Santiago Pastorino (Apr 29 2020 at 19:07, on Zulip):

did all the basic setup

Santiago Pastorino (Apr 29 2020 at 19:08, on Zulip):

this takes like 5 minutes

Santiago Pastorino (Apr 29 2020 at 19:08, on Zulip):

was working on automating this for a little bit but couldn't finish something that makes some sense

Santiago Pastorino (Apr 29 2020 at 19:08, on Zulip):

maybe for next meeting

Santiago Pastorino (Apr 29 2020 at 19:08, on Zulip):

anyway, let's follow the process manually

Santiago Pastorino (Apr 29 2020 at 19:08, on Zulip):

Remove I-nominated leftovers

Santiago Pastorino (Apr 29 2020 at 19:08, on Zulip):
Santiago Pastorino (Apr 29 2020 at 19:09, on Zulip):

the only one that may make sense to check what we want to do is #71416

Santiago Pastorino (Apr 29 2020 at 19:10, on Zulip):

@pnkfelix as stated there you wanted to leave the nomination on to open some fresh issues if I'm not wrong?

Santiago Pastorino (Apr 29 2020 at 19:10, on Zulip):

anyway, meanwhile Felix answers this let's move on

Santiago Pastorino (Apr 29 2020 at 19:10, on Zulip):

Unprioritized I-prioritize

Santiago Pastorino (Apr 29 2020 at 19:10, on Zulip):

Go over unprioritized I-prioritize issues. We should also go over I-nominated meanwhile we migrate, we were using I-nominated sometimes as an implicit request for prioritization.

Santiago Pastorino (Apr 29 2020 at 19:10, on Zulip):
  1. No team assigned
    - Add T-compiler tag when it corresponds.
Santiago Pastorino (Apr 29 2020 at 19:11, on Zulip):

empty

Santiago Pastorino (Apr 29 2020 at 19:11, on Zulip):
  1. T-compiler
    - Prioritize issues and remove nomination of the ones not worth discussing.
    - Tag regressions accordingly.
    - Ping appropriate people and/or ICE-breakers.
Santiago Pastorino (Apr 29 2020 at 19:11, on Zulip):

empty

Santiago Pastorino (Apr 29 2020 at 19:11, on Zulip):
  1. All teams
    - No action required. It's nice to look at this for comparison.
Santiago Pastorino (Apr 29 2020 at 19:11, on Zulip):

empty

Santiago Pastorino (Apr 29 2020 at 19:11, on Zulip):

this is all as expected because we are tracking it async :)

Santiago Pastorino (Apr 29 2020 at 19:11, on Zulip):

Regressions

Santiago Pastorino (Apr 29 2020 at 19:12, on Zulip):
  1. Beta regressions without P-label
    - Prioritize.
    - Ping appropriate people and/or ICE-breakers.
    - Assign if possible; if it remains unassigned, add it to agenda so we can assign during the meeting.
Santiago Pastorino (Apr 29 2020 at 19:12, on Zulip):

empty

Santiago Pastorino (Apr 29 2020 at 19:12, on Zulip):
  1. Nightly regressions without P-label
    - Prioritize.
    - Ping appropriate people and/or ICE-breakers.
    - Assign if possible; if it remains unassigned, add it to agenda so we can assign during the meeting.
Santiago Pastorino (Apr 29 2020 at 19:12, on Zulip):

empty

Santiago Pastorino (Apr 29 2020 at 19:12, on Zulip):

we also just had a release which may explain this :)

Santiago Pastorino (Apr 29 2020 at 19:12, on Zulip):

Beta nominations

Santiago Pastorino (Apr 29 2020 at 19:12, on Zulip):
  1. No team assigned
    - Add T-compiler tag when it corresponds.
Santiago Pastorino (Apr 29 2020 at 19:12, on Zulip):

empty

Santiago Pastorino (Apr 29 2020 at 19:13, on Zulip):
  1. All teams
    - Add T-compiler tag when it corresponds.
Santiago Pastorino (Apr 29 2020 at 19:13, on Zulip):

there are some there, let's check if there's somewhere we can add T-compiler

Santiago Pastorino (Apr 29 2020 at 19:14, on Zulip):

added to this one #71488

Santiago Pastorino (Apr 29 2020 at 19:14, on Zulip):

also this one #71517

Santiago Pastorino (Apr 29 2020 at 19:15, on Zulip):

also #71426

Santiago Pastorino (Apr 29 2020 at 19:15, on Zulip):

also #71268

DPC (Apr 29 2020 at 19:16, on Zulip):

why are we adding to closed prs? :thinking:

o0Ignition0o - Jeremy Lempereur (Apr 29 2020 at 19:16, on Zulip):

71268 has been merged aiui

Santiago Pastorino (Apr 29 2020 at 19:16, on Zulip):

these are beta nominated

Santiago Pastorino (Apr 29 2020 at 19:17, on Zulip):

let me check things anyway because I'm kind in an automated state :)

o0Ignition0o - Jeremy Lempereur (Apr 29 2020 at 19:17, on Zulip):

oh ok my bad, i m not too accustomed to how things go yet ^^

Santiago Pastorino (Apr 29 2020 at 19:17, on Zulip):

so here we care about things that are beta nominated and not beta accepted

DPC (Apr 29 2020 at 19:18, on Zulip):

ah ok

Santiago Pastorino (Apr 29 2020 at 19:18, on Zulip):

and in this particular step if we should add T-compiler or not

Santiago Pastorino (Apr 29 2020 at 19:18, on Zulip):

I've added all the missing ones

Santiago Pastorino (Apr 29 2020 at 19:18, on Zulip):

let's continue

Santiago Pastorino (Apr 29 2020 at 19:18, on Zulip):
  1. T-compiler
    - Add these issues to the meeting agenda.
Santiago Pastorino (Apr 29 2020 at 19:18, on Zulip):

now the ones I've added should show up here :)

Santiago Pastorino (Apr 29 2020 at 19:18, on Zulip):

and also the ones that were already tagged as T-compiler

Santiago Pastorino (Apr 29 2020 at 19:19, on Zulip):

well I don't trust the result ;)

Santiago Pastorino (Apr 29 2020 at 19:19, on Zulip):

there's always caching issues here, unsure how much time it takes to propagate

Santiago Pastorino (Apr 29 2020 at 19:19, on Zulip):

anyway, going to add all this things to the meeting agenda

Santiago Pastorino (Apr 29 2020 at 19:19, on Zulip):

will do manually, will be back in some minutes

Santiago Pastorino (Apr 29 2020 at 19:19, on Zulip):

we should be tracking with a clock how much time do we waste for not having this automated :P

Santiago Pastorino (Apr 29 2020 at 19:24, on Zulip):

done

Santiago Pastorino (Apr 29 2020 at 19:24, on Zulip):

5 minutes more :joy:

Santiago Pastorino (Apr 29 2020 at 19:24, on Zulip):

Stable nominations

Santiago Pastorino (Apr 29 2020 at 19:25, on Zulip):
  1. No team assigned
    - Add T-compiler tag when it corresponds.
Santiago Pastorino (Apr 29 2020 at 19:25, on Zulip):

empty

Santiago Pastorino (Apr 29 2020 at 19:25, on Zulip):
  1. All teams
    - Add T-compiler tag when it corresponds.
Santiago Pastorino (Apr 29 2020 at 19:25, on Zulip):

there are 2 t-libs

Santiago Pastorino (Apr 29 2020 at 19:26, on Zulip):

also @pnkfelix I'm adding things about t-libs given the latest discussions we had that we may consider them, anyway, if we shouldn't it's easy to remove them :)

Santiago Pastorino (Apr 29 2020 at 19:26, on Zulip):

going to add this to the agenda then

Santiago Pastorino (Apr 29 2020 at 19:27, on Zulip):

done

Santiago Pastorino (Apr 29 2020 at 19:27, on Zulip):
  1. T-compiler
    - Add these issues to the meeting agenda.
Santiago Pastorino (Apr 29 2020 at 19:27, on Zulip):

empty

Santiago Pastorino (Apr 29 2020 at 19:27, on Zulip):

PR's waiting for our team

Santiago Pastorino (Apr 29 2020 at 19:28, on Zulip):
Santiago Pastorino (Apr 29 2020 at 19:28, on Zulip):

there are two

Santiago Pastorino (Apr 29 2020 at 19:28, on Zulip):

going to add them into the agenda

Santiago Pastorino (Apr 29 2020 at 19:30, on Zulip):

we need to explain a bit what they are waiting for

Santiago Pastorino (Apr 29 2020 at 19:31, on Zulip):

#70655 @simulacrum you tagged it as waiting on team, I guess it's major of the MCP?

simulacrum (Apr 29 2020 at 19:31, on Zulip):

Uh hm. I think that was before we approved the FCP

simulacrum (Apr 29 2020 at 19:32, on Zulip):

Ping me on it please? I should review and probably merge

Santiago Pastorino (Apr 29 2020 at 19:32, on Zulip):

so we should just switch those labels

simulacrum (Apr 29 2020 at 19:32, on Zulip):

Yeah, should be waiting on review

Santiago Pastorino (Apr 29 2020 at 19:32, on Zulip):

remove waiting on team and add waiting on review or whatever is called

Santiago Pastorino (Apr 29 2020 at 19:32, on Zulip):

:+1:

Santiago Pastorino (Apr 29 2020 at 19:33, on Zulip):

well it's actually on a conflict

Santiago Pastorino (Apr 29 2020 at 19:33, on Zulip):

but yeah

DPC (Apr 29 2020 at 19:33, on Zulip):

conflict => waiting-on-author

Santiago Pastorino (Apr 29 2020 at 19:35, on Zulip):

yes :+1:

Santiago Pastorino (Apr 29 2020 at 19:36, on Zulip):

Critical and High priority issues

Santiago Pastorino (Apr 29 2020 at 19:36, on Zulip):
Santiago Pastorino (Apr 29 2020 at 19:37, on Zulip):

adding the summary to the agenda ...

Santiago Pastorino (Apr 29 2020 at 19:43, on Zulip):

summary done

Santiago Pastorino (Apr 29 2020 at 19:44, on Zulip):

we need to list every single P-critical and P-high regressions unassigned there

Santiago Pastorino (Apr 29 2020 at 19:48, on Zulip):

listed and added everything to the agenda

Santiago Pastorino (Apr 29 2020 at 19:48, on Zulip):

I guess we may want to explain briefly some things

Santiago Pastorino (Apr 29 2020 at 19:48, on Zulip):

the unassigned issues

Santiago Pastorino (Apr 29 2020 at 19:48, on Zulip):

going to check the status of each

Santiago Pastorino (Apr 29 2020 at 19:49, on Zulip):

in particular #70314, @pnkfelix seems to be working on it

Santiago Pastorino (Apr 29 2020 at 19:50, on Zulip):

ok done

Santiago Pastorino (Apr 29 2020 at 19:50, on Zulip):

Stable to beta regressions

Santiago Pastorino (Apr 29 2020 at 19:50, on Zulip):
Santiago Pastorino (Apr 29 2020 at 19:51, on Zulip):

there's nothing obvious IMHO to raise awareness

Santiago Pastorino (Apr 29 2020 at 19:51, on Zulip):

we can do another check at the end once we see how packed is the agenda

Santiago Pastorino (Apr 29 2020 at 19:52, on Zulip):

Stable to nightly regressions

Santiago Pastorino (Apr 29 2020 at 19:52, on Zulip):
Santiago Pastorino (Apr 29 2020 at 19:52, on Zulip):

same

Santiago Pastorino (Apr 29 2020 at 19:53, on Zulip):

Stable to stable regressions

Santiago Pastorino (Apr 29 2020 at 19:53, on Zulip):
Santiago Pastorino (Apr 29 2020 at 19:53, on Zulip):

oh I forgot to remove this, this is already in the summary

Santiago Pastorino (Apr 29 2020 at 19:53, on Zulip):

removed from the procedure

Santiago Pastorino (Apr 29 2020 at 19:54, on Zulip):

I-nominated T-compiler

Santiago Pastorino (Apr 29 2020 at 19:54, on Zulip):
Santiago Pastorino (Apr 29 2020 at 19:55, on Zulip):

adding to the agenda

Santiago Pastorino (Apr 29 2020 at 20:01, on Zulip):

Announcements

Santiago Pastorino (Apr 29 2020 at 20:01, on Zulip):
Santiago Pastorino (Apr 29 2020 at 20:07, on Zulip):

done

Santiago Pastorino (Apr 29 2020 at 20:07, on Zulip):

Toolstate

Santiago Pastorino (Apr 29 2020 at 20:07, on Zulip):
DPC (Apr 29 2020 at 20:07, on Zulip):

looks good

Santiago Pastorino (Apr 29 2020 at 20:08, on Zulip):

clippy-driver and miri, anyway, far from the release :)

DPC (Apr 29 2020 at 20:08, on Zulip):

since we are a week after release so doesn't matter

Santiago Pastorino (Apr 29 2020 at 20:08, on Zulip):

yep

DPC (Apr 29 2020 at 20:08, on Zulip):

yeh and clippy is being fixed

Santiago Pastorino (Apr 29 2020 at 20:08, on Zulip):

Performance regressions

Santiago Pastorino (Apr 29 2020 at 20:09, on Zulip):

Check perf regressions.

Santiago Pastorino (Apr 29 2020 at 20:09, on Zulip):

something happened here ...

Santiago Pastorino (Apr 29 2020 at 20:09, on Zulip):

image.png

o0Ignition0o - Jeremy Lempereur (Apr 29 2020 at 20:11, on Zulip):

it seems it got fixed ?

DPC (Apr 29 2020 at 20:11, on Zulip):

this looks odd

DPC (Apr 29 2020 at 20:11, on Zulip):

image.png

Santiago Pastorino (Apr 29 2020 at 20:13, on Zulip):

it looks good :)

o0Ignition0o - Jeremy Lempereur (Apr 29 2020 at 20:13, on Zulip):

https://github.com/rust-lang/rust/commit/4bfd62acb12a5e628d28950f9f94c3499216f10c are we looking a tthis ?

Santiago Pastorino (Apr 29 2020 at 20:13, on Zulip):

that means that it's better

o0Ignition0o - Jeremy Lempereur (Apr 29 2020 at 20:13, on Zulip):

because it seems to do exactly what it advertised ^^

DPC (Apr 29 2020 at 20:13, on Zulip):

ah lol

o0Ignition0o - Jeremy Lempereur (Apr 29 2020 at 20:14, on Zulip):

(might have picked the wrong commit tho)

Santiago Pastorino (Apr 29 2020 at 20:14, on Zulip):

o0Ignition0o - Jeremy Lempereur said:

https://github.com/rust-lang/rust/commit/4bfd62acb12a5e628d28950f9f94c3499216f10c are we looking a tthis ?

unsure, why are you looking that that one?

Santiago Pastorino (Apr 29 2020 at 20:14, on Zulip):

anyway, it doesn't seem to be anything outstanding

Santiago Pastorino (Apr 29 2020 at 20:15, on Zulip):

or important

o0Ignition0o - Jeremy Lempereur (Apr 29 2020 at 20:15, on Zulip):

image.png might be wrong tho. let s move on :)

Santiago Pastorino (Apr 29 2020 at 20:15, on Zulip):

that was the last thing

Santiago Pastorino (Apr 29 2020 at 20:16, on Zulip):

one thing that is clear to me is that we need a couple of things

Santiago Pastorino (Apr 29 2020 at 20:16, on Zulip):

we need to automate this meeting

Santiago Pastorino (Apr 29 2020 at 20:16, on Zulip):

and move more parts of this async

Santiago Pastorino (Apr 29 2020 at 20:16, on Zulip):

otherwise would be very hard for a lot of people to participate

Santiago Pastorino (Apr 29 2020 at 20:16, on Zulip):

people that try to get involved would get lost easily because we try to check a bunch of things in 1h or 2h

Santiago Pastorino (Apr 29 2020 at 20:17, on Zulip):

going to see if I can spend some time on the very very very bad code I'm trying to write to have some automation

DPC (Apr 29 2020 at 20:17, on Zulip):

maybe we could skip the empty bits?

Santiago Pastorino (Apr 29 2020 at 20:17, on Zulip):

yeah, the only way to do that is with automation :)

Santiago Pastorino (Apr 29 2020 at 20:17, on Zulip):

otherwise we need to open the links

Santiago Pastorino (Apr 29 2020 at 20:18, on Zulip):

or someone needs to go over things before the meeting

Santiago Pastorino (Apr 29 2020 at 20:18, on Zulip):

but nothing make any sense more than automating this and making it more async

Santiago Pastorino (Apr 29 2020 at 20:18, on Zulip):

in particular, we could make issues tagged as waiting on team open a topic here so we add those to the agenda

Santiago Pastorino (Apr 29 2020 at 20:18, on Zulip):

same for beta nominations, stable nominations, i-nominated and all that

DPC (Apr 29 2020 at 20:19, on Zulip):

yeh

Santiago Pastorino (Apr 29 2020 at 20:19, on Zulip):

this should be easy to do because it's almost the same as @LeSeulArtichaut have already done with I-prioritize

pnkfelix (Apr 29 2020 at 20:53, on Zulip):

sorry for my absence

pnkfelix (Apr 29 2020 at 21:01, on Zulip):

okay I've created fresh issues for #71416

pnkfelix (Apr 29 2020 at 21:03, on Zulip):

we should probably be linking to the agenda somewhere at the start of these topics, right?

pnkfelix (Apr 29 2020 at 21:04, on Zulip):

(did I somehow miss that? Or do I need to go through a level of indirection, back to the topic for tomorrow's meeting itself?)

pnkfelix (Apr 29 2020 at 21:04, on Zulip):

((seems like it was indeed a level-of-indirection issue))

Santiago Pastorino (Apr 29 2020 at 21:06, on Zulip):

pnkfelix said:

sorry for my absence

no worries, left those pings so you could answer async :)

pnkfelix (Apr 29 2020 at 21:06, on Zulip):

worked out pretty well I think/hope

pnkfelix (Apr 29 2020 at 21:06, on Zulip):

thanks for doing this

Santiago Pastorino (Apr 29 2020 at 21:07, on Zulip):

pnkfelix said:

we should probably be linking to the agenda somewhere at the start of these topics, right?

the agenda is linked in the main meeting but yeah we should link from there too

Santiago Pastorino (Apr 29 2020 at 21:07, on Zulip):

adding that to the procedure

Santiago Pastorino (Apr 29 2020 at 21:22, on Zulip):

@pnkfelix I was wondering how useful is being this https://hackmd.io/pHb6eTZ2Sjy6XZmwXZHIBA?both#Day-of-the-meeting for you and what parts specifically

Santiago Pastorino (Apr 29 2020 at 21:23, on Zulip):

for instance, the issues of note section doesn't make sense there, I've changed it a bunch of times and what we build in the agenda is the thing that makes sense

Santiago Pastorino (Apr 29 2020 at 21:24, on Zulip):

consider that that section is for you :), so feel free to kill whatever you don't want but in particular the issues of note part doesn't make sense anymore

Santiago Pastorino (Apr 29 2020 at 21:25, on Zulip):

I think all that section should just be what's in the agenda and shouldn't exist anymore :)

Santiago Pastorino (Apr 29 2020 at 21:25, on Zulip):

what may be useful are the first 4 sentences

pnkfelix (Apr 30 2020 at 00:33, on Zulip):

okay I'll try to review, and compare against what I do in practice during the actual meeting itself tomorrow

Santiago Pastorino (Apr 30 2020 at 16:03, on Zulip):

@pnkfelix did finally something from https://hackmd.io/pHb6eTZ2Sjy6XZmwXZHIBA?view#Day-of-the-meeting serve any purpose?

pnkfelix (Apr 30 2020 at 16:18, on Zulip):

I did use it at the outset

pnkfelix (Apr 30 2020 at 16:18, on Zulip):

but I stopped (forgot) after the announcements

pnkfelix (Apr 30 2020 at 16:18, on Zulip):

whoops

Santiago Pastorino (Apr 30 2020 at 16:53, on Zulip):

yeah in my opinion starting from announcements that doesn't make sense anymore

Santiago Pastorino (Apr 30 2020 at 16:54, on Zulip):

it should be more clear to follow what's in the agenda, that's exactly the purpose of the agenda :)

pnkfelix (Apr 30 2020 at 17:22, on Zulip):

I suppose its a question of how mechanical we want the whole process to be

pnkfelix (Apr 30 2020 at 17:23, on Zulip):

in terms of how much of a script to provide to people who are facilitating the meeting

pnkfelix (Apr 30 2020 at 17:24, on Zulip):

In theory, laying out a step-by-step procedure means we could swap in other facilitators for any meeting

pnkfelix (Apr 30 2020 at 17:24, on Zulip):

Such a step-by-step procedure doesn't belong in the agenda itself, because it makes the agenda too heavy-weight for on-lookers

pnkfelix (Apr 30 2020 at 17:25, on Zulip):

So that raises the question of whether a step-by-step procedure is actually of any real utility at all

pnkfelix (Apr 30 2020 at 17:25, on Zulip):

I've embedded much of the routine in my own mind

pnkfelix (Apr 30 2020 at 17:27, on Zulip):

and i mostly know at which points I want to cut-and-paste items (from the step-by-step procedure doc, or from the agenda itself). And I have to remember to add the "voting emojis" for :back: / :stop: / :shrug:

pnkfelix (Apr 30 2020 at 17:27, on Zulip):

but trying to perfect all of that in a document doesn't help someone who's trying to run the meeting on the fly; its too much work to read the document while the meeting itself is going on

pnkfelix (Apr 30 2020 at 17:29, on Zulip):

Embedding it all in a document and making it perfectly reflect our desired meeting format would serve, at best, two goals: 1. it would let other meeting organizers have something to study ahead of time (which I consider to be extremely unlikely), and 2. it would inform someone trying to make a robot to facilitate the meeting.

pnkfelix (Apr 30 2020 at 17:29, on Zulip):

Item 2. is perhaps the most realistic goal. But honestly, I think I'd rather spend my time hacking on the code for such a robot rather than try to make such a document perfect.

Last update: Jun 05 2020 at 22:45UTC