Stream: t-compiler/wg-prioritization

Topic: async meetings


Santiago Pastorino (Apr 09 2020 at 18:41, on Zulip):

so during our planning meeting we haven't decide exactly what to do async exactly and how things would look like

Santiago Pastorino (Apr 09 2020 at 18:42, on Zulip):

I'm going over our Pre-triage section on the procedure document

Santiago Pastorino (Apr 09 2020 at 18:42, on Zulip):

as I've stated during the planning meeting, I think we should still have the pre-triage sync meeting and mainly doing it as a sanity check for things

Santiago Pastorino (Apr 09 2020 at 18:43, on Zulip):

also we want to have a close as possible to the triage meeting a check about nominations and all that

Santiago Pastorino (Apr 09 2020 at 18:43, on Zulip):

the part we can move to async is the prioritization part

Santiago Pastorino (Apr 09 2020 at 18:46, on Zulip):

so I'd say, let's start to create topics in this stream about issues with labels I-prioritize and also about regressions and let's start prioritizing async as much as we can

Santiago Pastorino (Apr 09 2020 at 18:46, on Zulip):

at some point once we have @rustbot prioritize command this will happen more naturally but meanwhile we would need to proactively create topics here

Santiago Pastorino (Apr 09 2020 at 18:46, on Zulip):

@WG-prioritization :point_up:

Santiago Pastorino (Apr 09 2020 at 18:47, on Zulip):

I guess there's not much more to do about this :)

LeSeulArtichaut (Apr 09 2020 at 18:47, on Zulip):

Santiago Pastorino said:

at some point once we have @rustbot prioritize command this will happen more naturally but meanwhile we would need to proactively create topics here

Alright I got it, I'll work faster :sweat: :joy:

Santiago Pastorino (Apr 09 2020 at 18:47, on Zulip):

haha

Santiago Pastorino (Apr 09 2020 at 18:47, on Zulip):

no no, it was not the intention to put pressure on you :smiling_devil:

Santiago Pastorino (Apr 09 2020 at 18:48, on Zulip):

hehe, seriously, the automation will be great, but meanwhile we can do this manually

Santiago Pastorino (Apr 09 2020 at 18:48, on Zulip):

and anyway, meanwhile this is coded, merged, communicated, etc, we will have a bunch to do manually still so everything I've said above still applies

LeSeulArtichaut (Apr 09 2020 at 18:49, on Zulip):

Joking aside, I already have the implementation almost done, but I have no way of testing it. I'll ask Mark-Simulacrum once I (and he) have time

Santiago Pastorino (Apr 09 2020 at 18:49, on Zulip):

let's do it live :joy:

simulacrum (Apr 09 2020 at 18:55, on Zulip):

oh yes definitely I would test live

simulacrum (Apr 09 2020 at 18:55, on Zulip):

(saying that completely honestly, no sarcasm)

simulacrum (Apr 09 2020 at 18:55, on Zulip):

I test everything on triagebot live pretty much

simulacrum (Apr 09 2020 at 18:56, on Zulip):

@LeSeulArtichaut ^

LeSeulArtichaut (Apr 09 2020 at 18:57, on Zulip):

Well there’s nothing I could do to test it

LeSeulArtichaut (Apr 09 2020 at 18:57, on Zulip):

I don’t have a Zulip and GitHub playground myself :eyes:

bjorn3 (Apr 09 2020 at 18:58, on Zulip):

Can you try it on a repo of your own?

simulacrum (Apr 09 2020 at 18:59, on Zulip):

there's no reason to test things most of the time

LeSeulArtichaut (Apr 09 2020 at 19:00, on Zulip):

I’ll open a WIP PR when I’m ready for testing

LeSeulArtichaut (Apr 09 2020 at 19:00, on Zulip):

It’ll probably need some refractoring

LeSeulArtichaut (Apr 10 2020 at 11:59, on Zulip):

Done! rust-lang/triagebot#456

Santiago Pastorino (Apr 10 2020 at 12:23, on Zulip):

@LeSeulArtichaut cool, left some comments

LeSeulArtichaut (Apr 10 2020 at 12:24, on Zulip):

:+1:

LeSeulArtichaut (Apr 10 2020 at 12:42, on Zulip):

Also thanks @simulacrum for reviewing :slight_smile:

LeSeulArtichaut (Apr 10 2020 at 13:40, on Zulip):

When #70988 lands we'll be able to test the feature

pnkfelix (Apr 10 2020 at 18:36, on Zulip):

simulacrum said:

there's no reason to test things most of the time

(so tempted to tweet this with "overhead on rust development chat channel: ...")

simulacrum (Apr 10 2020 at 19:15, on Zulip):

Heh :)

simulacrum (Apr 10 2020 at 19:15, on Zulip):

If someone knows how to write tests that depend on GitHub webhooks and API in general and aren't manual, I'm all for it

simulacrum (Apr 10 2020 at 19:16, on Zulip):

So far my best thought is to basically have the whole chain of expected requests and responses in json files or something but that seems super brittle and painful to write

LeSeulArtichaut (Apr 10 2020 at 23:21, on Zulip):

#70988 landed!

LeSeulArtichaut (Apr 11 2020 at 13:24, on Zulip):

@simulacrum Should I open a dummy issue to test things?

simulacrum (Apr 11 2020 at 13:24, on Zulip):

ah hm, let's try it on a real issue

simulacrum (Apr 11 2020 at 13:24, on Zulip):

I'm sure I can find something :)

LeSeulArtichaut (Apr 11 2020 at 13:24, on Zulip):

x)

LeSeulArtichaut (Apr 11 2020 at 13:26, on Zulip):

Maybe #70934?

LeSeulArtichaut (Apr 11 2020 at 13:26, on Zulip):

It was triaged P-high because we didn't have a MCVE

LeSeulArtichaut (Apr 11 2020 at 13:26, on Zulip):

But now we have one

DPC (Apr 11 2020 at 13:27, on Zulip):

what's mcve btw?

LeSeulArtichaut (Apr 11 2020 at 13:27, on Zulip):

Minimal Complete Verifiable Example iirc

DPC (Apr 11 2020 at 13:27, on Zulip):

ah

LeSeulArtichaut (Apr 11 2020 at 13:27, on Zulip):

See the description for the E-needs-mcve label

simulacrum (Apr 11 2020 at 13:27, on Zulip):

hm okay no zulip message

simulacrum (Apr 11 2020 at 13:27, on Zulip):

let me go dig up logs

LeSeulArtichaut (Apr 11 2020 at 13:27, on Zulip):

:confused:

simulacrum (Apr 11 2020 at 13:29, on Zulip):

maybe because there was already a stream with that name

LeSeulArtichaut (Apr 11 2020 at 13:29, on Zulip):

But then it would have posted in that topic

simulacrum (Apr 11 2020 at 13:29, on Zulip):

pulling up logs...

LeSeulArtichaut (Apr 11 2020 at 13:29, on Zulip):

I see two things

LeSeulArtichaut (Apr 11 2020 at 13:29, on Zulip):

Either the zulip_stream ID is wrong

LeSeulArtichaut (Apr 11 2020 at 13:30, on Zulip):

Or I just messed up something in my code :innocent:

Last update: Jun 05 2020 at 22:20UTC