Stream: t-release/triagebot

Topic: glacier integration


simulacrum (May 12 2020 at 20:58, on Zulip):

(Moved this to a new topic)

That seems reasonable, yes. I'm not sure -- does glacier need a playground URL? I have no insight into how it works unfortunately

Elinvynia (May 12 2020 at 21:00, on Zulip):

This is my first time using Zulip, so sorry if I do something wrong!

I picked up on the work that was done already, but we can make it accept any input - github comment, gist, playground link, pastebin link, I'm fine with implementing any of those.

The harder part is going to be the actual opening of the PR on glacier, is there a guide somewhere for setting this bot in a testing environment?

simulacrum (May 12 2020 at 21:02, on Zulip):

there's not really a guide unfortunately

simulacrum (May 12 2020 at 21:03, on Zulip):

my recommendation is to add a new "main" function probably that will just hard code a comment to run through the "open a PR" bit for testing

simulacrum (May 12 2020 at 21:03, on Zulip):

(in a new src/bin/glacier-test.rs for example)

Elinvynia (May 12 2020 at 21:04, on Zulip):

That seems like a good idea! What should be restrictions for the usage of this command?

simulacrum (May 12 2020 at 21:04, on Zulip):

oh, it'd just be for local usage

simulacrum (May 12 2020 at 21:04, on Zulip):

i.e. just for testing

simulacrum (May 12 2020 at 21:05, on Zulip):

or you mean the actual @rustbot invocation?

Elinvynia (May 12 2020 at 21:05, on Zulip):

I mean for when it's done, I suppose we don't want anyone able to just spam the glacier repo with PRs.

simulacrum (May 12 2020 at 21:05, on Zulip):

oh, probably the standard "must be on a rust team" check, like most of the handlers

Elinvynia (May 13 2020 at 21:37, on Zulip):

Hmmm, I see an issue - currently there is no way to create a pull request/submit a commit. I noticed we are using a custom GitHub API wrapper, which means I'll have to implement this myself, this is going to take a while.

simulacrum (May 14 2020 at 11:10, on Zulip):

Yes, there's not yet a good github api wrapper in Rust AFAIK, though I know @XAMPPRocky is working on one we'll likely explore switching to once that's ready

XAMPPRocky (May 14 2020 at 11:10, on Zulip):

Stay tuned later today :slight_smile:

simulacrum (May 14 2020 at 11:12, on Zulip):

I'm not that fast :)

Elinvynia (May 14 2020 at 13:03, on Zulip):

Alright, should I consider it blocked then?

simulacrum (May 14 2020 at 13:15, on Zulip):

hm no I would probably try to add them to the existing thing

simulacrum (May 14 2020 at 13:15, on Zulip):

I don't imagine it'd be too hard to do if a bit annoying

XAMPPRocky (May 14 2020 at 16:58, on Zulip):

https://github.com/XAMPPRocky/octocrab

Elinvynia (May 14 2020 at 20:27, on Zulip):

@XAMPPRocky Do you plan to refactor triagebot to use it, or shall I open up a PR myself?

XAMPPRocky (May 14 2020 at 20:28, on Zulip):

@Elinvynia Well I didn't plan to, I would love it if you did and gave me any feedback you have with using it!

Elinvynia (May 14 2020 at 20:29, on Zulip):

Alright, I'll do my best! I'm still a beginner, so get ready for stupid questions.

XAMPPRocky (May 15 2020 at 04:56, on Zulip):

@Elinvynia Even better, I want it to be easily usable for beginners :slight_smile:

LeSeulArtichaut (May 15 2020 at 08:38, on Zulip):
while let Some(page) = octocrab.get_page::<models::Issue>(&page.next).await? {
    for issue in page {
        println!("{}", issue.title);
    }
}

There's pagination in octocrab? This will save my life for triagebot#477 :heart:

LeSeulArtichaut (May 15 2020 at 08:40, on Zulip):

@Elinvynia I'd like to help you transition triagebot to use octocrab. Have you started yet? If not I can create a fork and give you write access so we can do it together.

Elinvynia (May 15 2020 at 12:19, on Zulip):

@XAMPPRocky Sure, you can start a fork! I'm gonna work on it later today, had some IRL business to deal with.

XAMPPRocky (May 15 2020 at 12:31, on Zulip):

I think you meant to ping @LeSeulArtichaut :slight_smile:

XAMPPRocky (May 15 2020 at 12:49, on Zulip):

@LeSeulArtichaut
Yes, but I believe that example was actually incorrect, this is should be correct.

let mut next_page = page.next;
while let Some(page) = octocrab.get_page::<models::Issue>(&next_page).await? {
    next_page = page.next;
    for issue in page {
        println!("{}", issue.title);
    }
}
Elinvynia (May 22 2020 at 08:33, on Zulip):

@simulacrum a lot of progress has been done, could you have a look if this is what you had in mind when you have the time?

simulacrum (May 22 2020 at 10:37, on Zulip):

Yes, I plan to do so first thing today, probably in around half an hour or so.

Elinvynia (May 30 2020 at 20:18, on Zulip):

The command should hopefully be fixed now in my latest PR! cc @XAMPPRocky @simulacrum

Last update: Jun 05 2020 at 22:55UTC