Stream: wg-cli

Topic: clap-discussions

pksunkara (Apr 01 2020 at 17:02, on Zulip):

So, I finally got github to activate the discussions feature for our repo.

pksunkara (Apr 01 2020 at 17:03, on Zulip):

I am moving some issues to discussion and it looks github is going to send email when thats being done. So, please be ready to get spam emailed :D

pksunkara (May 06 2020 at 16:15, on Zulip):

clap-rs logo just got shown in github satellite keynote. :party_ball:

Degausser (May 06 2020 at 16:24, on Zulip):

That’s so awesome!!

Leo Le Bouter (Jul 17 2020 at 20:19, on Zulip):

hey there! tried to contribute something!

pksunkara (Jul 19 2020 at 10:40, on Zulip):

@Leo Le Bouter Thanks. I reviewed it. Let's get it merged soon! :grinning:

Leo Le Bouter (Jul 21 2020 at 12:18, on Zulip):

@pksunkara the issue with the Generator trait as it is, is that it can list "flags", "shorts" and "longs" but it can't link those back to the actual clap::Arg which means for some shells like fish, zsh or elvish, it can't use the interface for providing in-line help during completion (by including the clap::Arg description)

Leo Le Bouter (Jul 21 2020 at 12:19, on Zulip):

for bash, it is fine because it doesnt support or do inline help, but for other shells it's an issue

Leo Le Bouter (Jul 21 2020 at 12:26, on Zulip):

this is the reason no other impl of Generator other than the bash one uses the shorts_and_visible_aliases method

Leo Le Bouter (Jul 21 2020 at 12:28, on Zulip):

I want to give clap-generate a rewrite entirely for much clearer code but I am a bit scared by the Generator impl for zsh, it looks so complicated

Leo Le Bouter (Jul 21 2020 at 12:30, on Zulip):

it seems it just doesnt make sense to provide interfaces that list shorts, longs, or "flags" (whatever that means in this context, it actually is a clap::Arg but not sure why it's called "flag")

Leo Le Bouter (Jul 21 2020 at 12:30, on Zulip):

you always need the actual Arg to provide useful completions

Leo Le Bouter (Jul 21 2020 at 12:32, on Zulip):

the subcommand system makes it complex to provide completions it seems

pksunkara (Jul 21 2020 at 12:48, on Zulip):

Sounds good then. Thanks for looking into it.

Last update: Apr 16 2021 at 22:15UTC