Stream: wg-cli

Topic: clap


pksunkara (Jan 30 2020 at 23:44, on Zulip):

Also, I am working on a PR for refactoring the travis and the CI process.

pksunkara (Jan 30 2020 at 23:45, on Zulip):

I have also set that all PR's need approval and should pass CI before being merged

pksunkara (Jan 30 2020 at 23:48, on Zulip):

Also, I am going to archive the clap_derive repo once I look over the existing issues and PRs and move them over to clap

pksunkara (Jan 30 2020 at 23:48, on Zulip):

And we need to plan for porting over the rest of structopt commits

DPC (Jan 31 2020 at 00:41, on Zulip):

Let's not lock nightly for clippy. We can remove that now

pksunkara (Jan 31 2020 at 06:53, on Zulip):

@DPC Any reasons for that? Shouldn't we have stable linting?

pksunkara (Jan 31 2020 at 08:48, on Zulip):

Also, What do you guys think about using http://bors.tech and https://dependabot.com

DPC (Jan 31 2020 at 13:29, on Zulip):

Stable is fine.

DPC (Jan 31 2020 at 13:30, on Zulip):

Bors is okay if you can set it up. Dependabot might be too noisy for now

pksunkara (Feb 01 2020 at 09:02, on Zulip):

Working on bors setup now.

pksunkara (Feb 01 2020 at 09:03, on Zulip):

I have made 2 milestones, 3.0 and 3.1 and will slowly triage issues

DPC (Feb 01 2020 at 13:57, on Zulip):

_slowly_
I'm getting a dozen clap notifications at a time :rolling_on_the_floor_laughing:

pksunkara (Feb 01 2020 at 18:29, on Zulip):

We live in exciting times :D

pksunkara (Feb 01 2020 at 18:30, on Zulip):

Btw, @CreepySkeleton I think we should open https://github.com/clap-rs/clap/issues/1387

pksunkara (Feb 01 2020 at 18:32, on Zulip):

Nevermind, I just saw that https://github.com/clap-rs/clap/issues/1569 is a duplicate of it

pksunkara (Feb 01 2020 at 18:36, on Zulip):

@CreepySkeleton Can you triage these 3 and see if you want to open them? https://github.com/clap-rs/clap/issues?q=label%3A%22W%3A+after+v3+release%22+is%3Aclosed. Thanks

pksunkara (Feb 01 2020 at 18:52, on Zulip):

And are you using the not sure label as a personal marker of things you want to come back to?

pksunkara (Feb 01 2020 at 19:57, on Zulip):

And are you planning to work on https://github.com/clap-rs/clap/issues/1644? If not, please write what you meant by fixing the error messages in debug builds

pksunkara (Feb 01 2020 at 20:13, on Zulip):

Reading https://github.com/clap-rs/clap/issues/1485#issuecomment-581064984, looks like we should change the no_cargo feature to cargo and enable it by default. What do you think?

CreepySkeleton (Feb 02 2020 at 02:05, on Zulip):

Yeah, not-sure is some sort of "ugh, I don't get anything but I'll take another look later". You can take those issues if you want :slight_smile:

CreepySkeleton (Feb 02 2020 at 02:23, on Zulip):

Regarding no-cargo - good idea :+1:

pksunkara (Feb 02 2020 at 05:51, on Zulip):

Could you rename the label to P: CreepySkeleton to mark it as your personal?

CreepySkeleton (Feb 03 2020 at 03:17, on Zulip):

What do you think about renaming labels from L: name to L-name form? It's much easier to type label:C-subcommands thanlabel:"C: subcommands".

pksunkara (Feb 03 2020 at 09:04, on Zulip):

Type where?

pksunkara (Feb 03 2020 at 09:31, on Zulip):

Btw, where are you using help wanted lable? For easy stuff?

pksunkara (Feb 03 2020 at 11:40, on Zulip):

@CreepySkeleton Want your feedback on https://github.com/clap-rs/clap/issues/1603

CreepySkeleton (Feb 03 2020 at 12:34, on Zulip):

type in github search
pasted image

CreepySkeleton (Feb 03 2020 at 12:35, on Zulip):

help wanted is for stuff where would like some help from others

CreepySkeleton (Feb 03 2020 at 12:36, on Zulip):

good-first-issue is for easy stuff

CreepySkeleton (Feb 05 2020 at 08:36, on Zulip):

So, what about renaming labels? I would also propose to remove whitespace from all labels, e.g derive macros => derive-macros

pksunkara (Feb 05 2020 at 11:47, on Zulip):

It's easier to search by "Label" button than to write in search bar, isn't it? I know we are just bikesheding, but I really like the spaces in the labels :frown:

DPC (Feb 06 2020 at 00:50, on Zulip):

You don't need to do all that. On the right you can click the labels drop-down and choose what label you want to be filtered on

CreepySkeleton (Feb 06 2020 at 06:01, on Zulip):

The thing is that sometimes I want more complex search queries, like -label:help-messages label:subcommand, this cannot be achieved with drop-down lists AFAIK. I also use keyboard mostly and switching between it and the mouse is annoying.

DPC (Feb 06 2020 at 19:34, on Zulip):

It can :p yeah the mouse part is annoying though

pksunkara (Feb 07 2020 at 10:47, on Zulip):

You can do alt-click to exclude labels. But yeah, mouse is annoying

pksunkara (Feb 07 2020 at 10:48, on Zulip):

Btw, I am planning to get familiar with clap internals this weekend

DPC (Feb 07 2020 at 13:59, on Zulip):

I'd like if someone can work on the rustup aliasing issie

pksunkara (Feb 08 2020 at 05:47, on Zulip):

Yeah, I will be looking into how parsing happens and figure out the best way for this

CreepySkeleton (Feb 13 2020 at 19:00, on Zulip):

What do you think about making different templates for issues and PRs? Like https://github.com/rust-lang/cargo/issues/new/choose

CreepySkeleton (Feb 13 2020 at 19:03, on Zulip):

@DPC @pksunkara

pksunkara (Feb 13 2020 at 20:16, on Zulip):

Sure

DPC (Feb 13 2020 at 20:44, on Zulip):

I'm okay with it. Though we have a good template already just have to put it in the GitHub template

pksunkara (Feb 17 2020 at 09:33, on Zulip):

@CreepySkeleton Let's push for an alpha release soon. What are the important stuff left?

DPC (Feb 17 2020 at 17:43, on Zulip):

Wait

DPC (Feb 17 2020 at 17:43, on Zulip):

@pksunkara

pksunkara (Feb 17 2020 at 17:43, on Zulip):

?

DPC (Feb 17 2020 at 17:45, on Zulip):

I'll do the release in a few days. Need to go through it and do some checks. Also it will be a beta and not a alpha

pksunkara (Feb 17 2020 at 17:46, on Zulip):

Not a beta please. We still need to change yaml API which would be breaking

pksunkara (Feb 17 2020 at 17:47, on Zulip):

And what checks are we talking about?

DPC (Feb 17 2020 at 17:48, on Zulip):

It's fine if we break things.

CreepySkeleton (Feb 20 2020 at 16:22, on Zulip):

@DPC What are the checks you were taking about? Is there something going in background we are not aware of?

DPC (Feb 20 2020 at 16:23, on Zulip):

Nope

CreepySkeleton (Feb 20 2020 at 16:23, on Zulip):

Also, why do you insist on beta?

DPC (Feb 20 2020 at 16:23, on Zulip):

Just want to go through it once

CreepySkeleton (Feb 20 2020 at 16:23, on Zulip):

I'm really hesitant to call it beta, honestly. Maybe, pre-beta?

DPC (Feb 20 2020 at 17:29, on Zulip):

We always had a beta in mind since months. I don't see much stuff changing to ask for an alpha release

pksunkara (Feb 22 2020 at 21:29, on Zulip):

We should do one final alpha release and then go with rc directly afterwards

DPC (Feb 23 2020 at 00:13, on Zulip):

then there is no difference between that and a beta

Last update: Feb 25 2020 at 03:55UTC