Also, I am working on a PR for refactoring the travis and the CI process.
I have also set that all PR's need approval and should pass CI before being merged
Also, I am going to archive the clap_derive repo once I look over the existing issues and PRs and move them over to clap
And we need to plan for porting over the rest of structopt commits
Let's not lock nightly for clippy. We can remove that now
@DPC Any reasons for that? Shouldn't we have stable linting?
Stable is fine.
Bors is okay if you can set it up. Dependabot might be too noisy for now
Working on bors setup now.
I have made 2 milestones, 3.0 and 3.1 and will slowly triage issues
I'm getting a dozen clap notifications at a time :rolling_on_the_floor_laughing:
We live in exciting times :D
Btw, @CreepySkeleton I think we should open https://github.com/clap-rs/clap/issues/1387
Nevermind, I just saw that https://github.com/clap-rs/clap/issues/1569 is a duplicate of it
@CreepySkeleton Can you triage these 3 and see if you want to open them? https://github.com/clap-rs/clap/issues?q=label%3A%22W%3A+after+v3+release%22+is%3Aclosed. Thanks
And are you using the
not sure label as a personal marker of things you want to come back to?
And are you planning to work on https://github.com/clap-rs/clap/issues/1644? If not, please write what you meant by fixing the error messages in debug builds
Reading https://github.com/clap-rs/clap/issues/1485#issuecomment-581064984, looks like we should change the
no_cargo feature to
cargo and enable it by default. What do you think?
not-sure is some sort of "ugh, I don't get anything but I'll take another look later". You can take those issues if you want :slight_smile:
no-cargo - good idea :+1:
Could you rename the label to
P: CreepySkeleton to mark it as your personal?
What do you think about renaming labels from
L: name to
L-name form? It's much easier to type
Btw, where are you using
help wanted lable? For easy stuff?
@CreepySkeleton Want your feedback on https://github.com/clap-rs/clap/issues/1603
type in github search
help wanted is for stuff where would like some help from others
good-first-issue is for easy stuff
So, what about renaming labels? I would also propose to remove whitespace from all labels, e.g
derive macros => derive-macros
It's easier to search by "Label" button than to write in search bar, isn't it? I know we are just bikesheding, but I really like the spaces in the labels :frown:
You don't need to do all that. On the right you can click the labels drop-down and choose what label you want to be filtered on
The thing is that sometimes I want more complex search queries, like
-label:help-messages label:subcommand, this cannot be achieved with drop-down lists AFAIK. I also use keyboard mostly and switching between it and the mouse is annoying.
It can :p yeah the mouse part is annoying though
You can do alt-click to exclude labels. But yeah, mouse is annoying
Btw, I am planning to get familiar with clap internals this weekend
I'd like if someone can work on the rustup aliasing issie
Yeah, I will be looking into how parsing happens and figure out the best way for this
What do you think about making different templates for issues and PRs? Like https://github.com/rust-lang/cargo/issues/new/choose
I'm okay with it. Though we have a good template already just have to put it in the GitHub template
@CreepySkeleton Let's push for an alpha release soon. What are the important stuff left?
I'll do the release in a few days. Need to go through it and do some checks. Also it will be a beta and not a alpha
Not a beta please. We still need to change yaml API which would be breaking
And what checks are we talking about?
It's fine if we break things.
@DPC What are the checks you were taking about? Is there something going in background we are not aware of?
Also, why do you insist on beta?
Just want to go through it once
I'm really hesitant to call it beta, honestly. Maybe, pre-beta?
We always had a beta in mind since months. I don't see much stuff changing to ask for an alpha release
We should do one final alpha release and then go with rc directly afterwards
then there is no difference between that and a beta