I want to help move this forward. What's the best way to do so?
I suspect the next step here is to prepare an implementation for std (to be landed in an unstable fashion). You can register your interest to do so on the tracking issue -- https://github.com/rust-lang/rust/issues/58533.
to my knowledge there's not been major discussion since the RFC landed so I suspect that implementing it is the next step
@Charles Lew If you have any questions, just ask here! Do you think you wanna take a stab at implementing this?
No one wrote down mentoring instructions yet. I could do that. @Charles Lew Would you like mentoring instructions? The other possibility would be to talk about all your questions in chat, which might be more appropriate now. Mentoring instructions are usually useful when we don't have a specific person working on it yet.
Thanks! I've put up my PR at https://github.com/rust-lang/rust/pull/68123
@Charles Lew Thanks a bunch :) I'm looking forward to this feature
@Amanieu Regarding the changed method name you suggested: should I create a PR for the rfc repo fixing the RFC text? I can do that if you think it's a good idea.
@Lukas Kalbertodt Yes that's a good idea.
@Amanieu I just read the RFC again and am currently renaming. For most of your suggestions everyone agrees, but the story around
remove seems less clear. Should I use your
remove suggestion anyway and we will discuss this on the tracking issue?
Furthermore, I would actually name it
remove_current. All other operations have an explicit "direction" and
cursor.remove_current() seems more readable to me than
@Lukas Kalbertodt Sure,
remove_current sounds good.
I can create a PR expanding the documentation of the cursor API, if you want! I don't mind writing docs ^_^
Or did someone else already plan on doing that?
Go ahead, I don't think anyone is working on it at the moment.