Stream: t-libs

Topic: Permission to start FCP merges?


Lukas Kalbertodt (Feb 08 2020 at 12:45, on Zulip):

Hi there. I am currently not included in rfcbot's t-libs list. And this is good for now, as I don't think I currently have the time for that. However, I often need to FCP merge PRs but I can't do that. See this attempt for example, where someone needed to help me.

Is there a way for me to start FCP merges without being included in the "signoff list"? I would like to avoid having to ping someone else all the time. Or should I just reassign PRs requiring FCP merges to someone else?

XAMPPRocky (Feb 08 2020 at 12:54, on Zulip):

@Lukas Kalbertodt rfcbot's list is based on rust-lang/team so right now you're not marked as being on the libs team at all. You should make a PR that adds yourself to the team. https://github.com/rust-lang/team

Lukas Kalbertodt (Feb 08 2020 at 12:56, on Zulip):

@XAMPPRocky I am already in the libs team there: https://github.com/rust-lang/team/blob/master/teams/libs.toml
I'm simply excluded from the rfcbot.

Lukas Kalbertodt (Feb 08 2020 at 12:57, on Zulip):

I wonder if there is a way for this hybrid.

Lukas Kalbertodt (Feb 08 2020 at 12:57, on Zulip):

@BurntSushi Can you start an FCP merge? Or is it just me who can't?

XAMPPRocky (Feb 08 2020 at 13:01, on Zulip):

@Lukas Kalbertodt That would feel like a weird hybrid to me. You want to be able to start a voting process, but not be a voting member is that correct?

simulacrum (Feb 08 2020 at 13:09, on Zulip):

@Lukas Kalbertodt Is your exclusion from the rfcbot list intentional? We could just drop that exclusion...

simulacrum (Feb 08 2020 at 13:10, on Zulip):

Looks like yes, though there's no rationale given in the PR

Lukas Kalbertodt (Feb 08 2020 at 13:20, on Zulip):

Yeah this was intentional. We discussed this on the mailing list briefly and concluded that it would be a good idea to not add me to everything at once, but start slowly. I.e. just review rotation first, but not rfcbot.

Lukas Kalbertodt (Feb 08 2020 at 13:21, on Zulip):

But I agree, it would be a weird hybrid. It's also just strange right now as part of the "review job" is to start FCP merges.

Simon Sapin (Feb 08 2020 at 22:31, on Zulip):

If you want to take this on I think it’s fine to remove the exclusion

Simon Sapin (Feb 08 2020 at 22:31, on Zulip):

At the moment rfcbot considers that proposing FCP is itself a vote in favor of that proposal

Lukas Kalbertodt (Feb 09 2020 at 09:49, on Zulip):

At the moment rfcbot considers that proposing FCP is itself a vote in favor of that proposal

That makes sense, I guess

Lukas Kalbertodt (Feb 09 2020 at 09:51, on Zulip):

If you want to take this on I think it’s fine to remove the exclusion

Unfortunately, I don't think I'm ready to take this on yet. Currently, I don't yet have the feeling I am reviewing my PRs in a timely fashion, so I first want to get that under control before taking on more tasks.

BurntSushi (Feb 13 2020 at 16:28, on Zulip):

Ah sorry, I didn't see this. I haven't tried to start an fcp merge. Generally I don't have the bandwidth to keep up with std PRs/reviews and such. Although I'm happy to be pinged on demand. :)

Last update: Feb 25 2020 at 04:25UTC