Stream: t-libs

Topic: Reassigning PRs of others to myself?


Lukas Kalbertodt (Jan 11 2020 at 11:52, on Zulip):

Just a general question (I don't have a specific PR in mind): is it OK to reassign a PR to myself if the original reviewer didn't reply for some time? Or is it considered impolite? Anything I should look out for?

XAMPPRocky (Jan 11 2020 at 12:10, on Zulip):

@Lukas Kalbertodt You can read about the triage procedure that the release team does for PRs. Forge should cover that under the S-waiting-for-review section. https://forge.rust-lang.org/release/triage-procedure.html

Lukas Kalbertodt (Jan 11 2020 at 12:12, on Zulip):

Thanks! I guess I should read the full forge docs before asking more questions ^_^

centril (Jan 11 2020 at 15:03, on Zulip):

@Lukas Kalbertodt it's a great idea to r? yourself if you can review it and the reviewer hasn't reviewed it for some time

centril (Jan 11 2020 at 15:03, on Zulip):

you can also eagerly review-steal things if you don't think there's any controversy in doing so

simulacrum (Jan 11 2020 at 15:03, on Zulip):

(and even if it's just opened, too)

varkor (Jan 11 2020 at 15:13, on Zulip):

especially if it was assigned by rust-highfive, there's going to be no controversy at all

Lukas Kalbertodt (Jan 11 2020 at 15:30, on Zulip):

Ok, thank y'all. That helps :)

Last update: Jul 02 2020 at 11:25UTC