Stream: t-compiler/cargo-bisect-rustc

Topic: release a new version


Santiago Pastorino (Feb 24 2020 at 16:15, on Zulip):

and some other things that @Chris Simpkins added

pnkfelix (Feb 24 2020 at 16:15, on Zulip):

maybe fork to new topic to discuss a release?

Santiago Pastorino (Feb 24 2020 at 16:18, on Zulip):

moved everything to a new topic

Santiago Pastorino (Feb 24 2020 at 16:18, on Zulip):

current version is 0.2.1, we can release 0.3.0 I guess with all this stuff :)

pnkfelix (Feb 24 2020 at 19:16, on Zulip):

yeah, I started looking at trying to make something to query github.com directly to get the PR's in a commit range. But I don't think I'll have anything I'm happy with in the short term.

pnkfelix (Feb 24 2020 at 19:17, on Zulip):

(I was briefly considering saying "oh lets hold on until I get this done", but I've abandoned that optimism now)

pnkfelix (Feb 24 2020 at 19:18, on Zulip):

should we check in with @simulacrum before doing a release?

pnkfelix (Feb 24 2020 at 19:18, on Zulip):

/me wishes we had a test suite.

pnkfelix (Feb 24 2020 at 19:19, on Zulip):

actually I guess it wouldn't be that hard to make a test suite, if we're willing to use --end for all the tests, and just cross our finges that the behavior without --end does not break.

simulacrum (Feb 24 2020 at 19:26, on Zulip):

I think making a release is a good idea, can always bugfix in .1 or so.

I have not reviewed changelog or anything like that though :)

Chris Simpkins (Feb 24 2020 at 19:56, on Zulip):

actually I guess it wouldn't be that hard to make a test suite,

I've been thinking through how to approach this. The commit level rustc caches expire at the 167 day mark so the tests covering this part of the source would need to be updated periodically.

pnkfelix (Feb 24 2020 at 20:01, on Zulip):

hmm. that is a good point.

pnkfelix (Feb 24 2020 at 20:04, on Zulip):

we might at least be able to make the update process relatively painless, by using rustversion and #[rustc_error]...

Chris Simpkins (Feb 24 2020 at 21:24, on Zulip):

Do you have a suggestion about how to refactor the source to best support tests? I discussed moving most of the source that currently lives in main.rs into a library and adding unit/integration tests with Santiago last week. He supports this and Mark indicated that he is deferring the review to Santiago due to other time commitments.

The error handling PR is a first step in that direction. It only refactors custom errors out of main.rs and doesn't address the testing issue. At the moment, the git functionality and the least_satisfying nightly/commit testing approach live outside of main.rs. We can move everything else from the run() function up into a lib.rs at this stage or use a more modular approach, then begin the work on the tests.

Santiago Pastorino (Feb 24 2020 at 21:25, on Zulip):

btw, I can release but we do not have a CHANGELOG

Santiago Pastorino (Feb 24 2020 at 21:25, on Zulip):

I think is worth adding that

Santiago Pastorino (Feb 24 2020 at 21:25, on Zulip):

can't do that today if someone can meanwhile would be great otherwise I can make it tomorrow

Chris Simpkins (Feb 24 2020 at 21:26, on Zulip):

np, I can add one now

Chris Simpkins (Feb 24 2020 at 21:27, on Zulip):

@Santiago Pastorino This will be v0.3.0?

Santiago Pastorino (Feb 24 2020 at 21:29, on Zulip):

yes

Santiago Pastorino (Feb 24 2020 at 21:29, on Zulip):

thanks when you do I can merge and release

Chris Simpkins (Feb 24 2020 at 21:31, on Zulip):

I don't see any tagged releases for previous versions. It looks like the Cargo.toml change history has commits for v0.2.1 and v0.2.0. I will see if I can track down changes that happened between those releases and add them too

Chris Simpkins (Feb 24 2020 at 22:02, on Zulip):

https://github.com/rust-lang/cargo-bisect-rustc/pull/59

Santiago Pastorino (Feb 25 2020 at 14:29, on Zulip):

seems like previous versions are not tagged :(

Santiago Pastorino (Feb 25 2020 at 14:29, on Zulip):

we could tag backwards I guess

Santiago Pastorino (Feb 25 2020 at 14:38, on Zulip):

have tagged previous versions

Santiago Pastorino (Feb 25 2020 at 14:38, on Zulip):

and releasing 0.3.0 ...

Santiago Pastorino (Feb 25 2020 at 14:40, on Zulip):

done

Chris Simpkins (Feb 25 2020 at 14:58, on Zulip):

thanks Santiago!

Last update: Nov 25 2020 at 02:30UTC